From: Ashish Gupta <ashishg@marvell.com>
To: Sameer Vaze <svaze@qti.qualcomm.com>,
Sunila Sahu <ssahu@marvell.com>,
Fan Zhang <fanzhang.oss@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXTERNAL] [PATCH v1] compress/zlib: fix UDC checksum logic
Date: Thu, 18 Dec 2025 07:32:48 +0000 [thread overview]
Message-ID: <SJ0PR18MB4495316B3067E67528DC5685B7A8A@SJ0PR18MB4495.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20251216193616.373430-1-svaze@qti.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 4212 bytes --]
From: Sameer Vaze <svaze@qti.qualcomm.com>
Sent: Wednesday, December 17, 2025 1:06 AM
To: Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com>
Cc: dev@dpdk.org; Sameer Vaze <svaze@qti.qualcomm.com>; stable@dpdk.org
Subject: [EXTERNAL] [PATCH v1] compress/zlib: fix UDC checksum logic
Fixes bugs with casting and checksum calculation for UDC checksum Fixes: 0dc314debb22 ("compress/zlib: support dictionaries and PDCP checksum") Cc: stable@ dpdk. org Signed-off-by: Sameer Vaze <svaze@ qti. qualcomm. com> --- drivers/compress/zlib/zlib_pmd. c
ZjQcmQRYFpfptBannerStart
Prioritize security for external emails:
Confirm sender and content safety before clicking links or opening attachments
Report Suspicious <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!ti3Z1f8UAlWa1M-dmb2aTtrSCkcdEIRIFWg-YVjcPEhmOerTATSVvntd2S9OqvFQwGz2AuKqJLO-tb0Pf2JxhUZLz0GegAL_$>
ZjQcmQRYFpfptBannerEnd
Fixes bugs with casting and checksum calculation for
UDC checksum
Fixes: 0dc314debb22 ("compress/zlib: support dictionaries and PDCP checksum")
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com<mailto:svaze@qti.qualcomm.com>>
---
drivers/compress/zlib/zlib_pmd.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 1d7651dd7d..bb970912cb 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -48,12 +48,12 @@ process_zlib_deflate_chksum(struct rte_comp_op *op,
return;
}
- dictionary_start = (uint32_t)(*dictionary);
- dictionary_end = (uint32_t)(*(dictionary + dictionary_len - 4));
+ dictionary_start = *(uint32_t *)dictionary;
+ dictionary_end = *(uint32_t *)(dictionary + dictionary_len - 4);
sum = (dictionary_start & BOTTOM_NIBBLE_OF_BYTES_IN_DOUBLE_WORD)
- + (dictionary_start & (TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD >> 4))
+ + ((dictionary_start & TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD) >> 4)
+ (dictionary_end & BOTTOM_NIBBLE_OF_BYTES_IN_DOUBLE_WORD)
- + (dictionary_end & (TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD >> 4));
+ + ((dictionary_end & TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD) >> 4);
op->output_chksum = ~(sum_bytes[0] + sum_bytes[1] + sum_bytes[2] + sum_bytes[3])
& BOTTOM_NIBBLE_OF_BYTE;
@@ -98,12 +98,12 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
return;
}
- dictionary_start = (uint32_t)(*dictionary);
- dictionary_end = (uint32_t)(*(dictionary + dictionary_len - 4));
+ dictionary_start = *(uint32_t *)dictionary;
+ dictionary_end = *(uint32_t *)(dictionary + dictionary_len - 4);
sum = (dictionary_start & BOTTOM_NIBBLE_OF_BYTES_IN_DOUBLE_WORD)
- + (dictionary_start & (TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD >> 4))
+ + ((dictionary_start & TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD) >> 4)
+ (dictionary_end & BOTTOM_NIBBLE_OF_BYTES_IN_DOUBLE_WORD)
- + (dictionary_end & (TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD >> 4));
+ + ((dictionary_end & TOP_NIBBLE_OF_BYTE_IN_DOUBLE_WORD) >> 4);
op->output_chksum = ~(sum_bytes[0] + sum_bytes[1] + sum_bytes[2] + sum_bytes[3])
& BOTTOM_NIBBLE_OF_BYTE;
--
2.31.1
Acked-by: Ashish Gupta <ashishg@marvell.com>
[-- Attachment #2: Type: text/html, Size: 19172 bytes --]
prev parent reply other threads:[~2025-12-18 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 19:36 Sameer Vaze
2025-12-18 7:32 ` Ashish Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR18MB4495316B3067E67528DC5685B7A8A@SJ0PR18MB4495.namprd18.prod.outlook.com \
--to=ashishg@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=ssahu@marvell.com \
--cc=stable@dpdk.org \
--cc=svaze@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).