From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7C2C45AE2; Tue, 8 Oct 2024 16:26:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 44B1F4025C; Tue, 8 Oct 2024 16:26:24 +0200 (CEST) Received: from mx0a-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 5FFC24021E for ; Tue, 8 Oct 2024 16:26:22 +0200 (CEST) Received: from pps.filterd (m0431384.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 498DOc3p015395; Tue, 8 Oct 2024 07:26:11 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2170.outbound.protection.outlook.com [104.47.58.170]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 4255kb84ey-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Oct 2024 07:26:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pPOhXYHOUSAohT6HhHVxskCIeG5uhz72E0zBOmGg5zzXcLHgO/BEf1G8fB0XbFDlImIT1Wu8zQrTw+EAUWVuFnQtCEGbmx6qZjbKDQ+wmrkp+V1ukdHuMybNe2pRYU7HbASby43U4Q1m6Y+BzSMDZE6KoKbtAgqK3whDtPXdDgU1pspGT6GQLhS9iM+D4Kdkfl3c+aiZuZ5OHsbLJbQPHNAcjraZVYYIjDLJ95AYlUK6uumFwby0EJdL1RuHMuSXJe+f/rqn4nS5cQUHXsdJ9TVzHCvTFCniU6eCv2+fB6/PzliOmzsFbVS3TsPjQEfyvru3ZEegEYY/70dqwsC2EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EfwpbeGBCFGExPlhN7lbgNyJ56Gcirx3rtUZv2praY0=; b=pLrKGkOeQEmB2Cp+1R7pJ+WFmptFQAQUJinVnSlVSfUkjnnGqHXJ+JhyPR/9bZJcCN/zIYx7k6xRsqcUOJPzOhhdQeUpoO7X6OFKbTzG58fZGwV4P+fml9KRCZ+Udbv0OjUKiWDU696EcW0GbMDW9BpHL+0CBuIndPxas/5lsuw8n7Hq79QjKdiXVFF42puYD9Dmms6sZ1Iix+tqUFEUB4m1i2+4NiZzNnGM1pPfZ5vRUAuLlQn41Qu6vnEzHO0o901+D8fxjPcFSMbo0Xw2GmhaWlR1YVdrDzduie6EuwzXrpC2a/RJ2F/1U81p8CP39EvBb2+oEP7fcGwasb5RlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfwpbeGBCFGExPlhN7lbgNyJ56Gcirx3rtUZv2praY0=; b=MNTnl0hzE9yvV0ut7KXWmELqWusm54HeopW6FVE+1ITr/0yZ7qLj3RIp3orEttBF4oC2ZSIMHnmYNhxpxzrbeCzBwDE21PgXsA6Cr2HBRuOgg8o/P/GstRcvv5wDyl3vILLqLoSTi4OnOiZ1boDnJKMAmnHoRIziJKAsqL9/1uI= Received: from SJ0PR18MB5111.namprd18.prod.outlook.com (2603:10b6:a03:43a::22) by BY3PR18MB4740.namprd18.prod.outlook.com (2603:10b6:a03:3cb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Tue, 8 Oct 2024 14:26:05 +0000 Received: from SJ0PR18MB5111.namprd18.prod.outlook.com ([fe80::d5aa:18b:1998:77b7]) by SJ0PR18MB5111.namprd18.prod.outlook.com ([fe80::d5aa:18b:1998:77b7%4]) with mapi id 15.20.8026.020; Tue, 8 Oct 2024 14:26:04 +0000 From: Nitin Saxena To: David Marchand CC: Jerin Jacob , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Zhirun Yan , "dev@dpdk.org" , Nitin Saxena , Robin Jarry , Christophe Fontaine Subject: RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph Thread-Topic: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph Thread-Index: AQHbGVi5LRXcm4D870aU/sBpd7FMo7J86QpQ Date: Tue, 8 Oct 2024 14:26:04 +0000 Message-ID: References: <20240907073115.1531070-1-nsaxena@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR18MB5111:EE_|BY3PR18MB4740:EE_ x-ms-office365-filtering-correlation-id: c3722694-a498-4d4c-e8e0-08dce7a52451 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?RWpiSndjVWs0MUgyTjY3ZSt1MmRqOUlSNzVlekRhdmk4SGlXSjlmQm45KzRr?= =?utf-8?B?aVFmVHlIREs1T1NJd1kyRk9JZU5xZWZDWFVqMzI4VUlSNWtsdW4rOGlORTRs?= =?utf-8?B?VHlGZFo5ek0rK2tFMUUzT1pOd2x2NkRPRjRpSkEvWjBkWVFJVXhrMFJLbGoy?= =?utf-8?B?TXA4TXhBV1hoMXdYTDNjYlI1QXp3dkYxUXhZZFRGMjF3ZVArTFhjS1ZpQmV4?= =?utf-8?B?SWprWFYwdnNvTTJlcno5dVhNTkQ3K3NHTFRSYjhzajg5L2tldkFyV1dzdXBF?= =?utf-8?B?eHZ5SnE1bFRIbjB6Wk1abXluaUxyU2EwWk1EcGhOU3VEWDlLRUo3Z3l6TmRu?= =?utf-8?B?Vlk4eExhcElCV1hhOUJneXBJdklUVlpUOXJWZlJTcDIzdE15ekUrZUJyTk9T?= =?utf-8?B?VmZjcUdBUVc2aFpyUVQ2K1ZJQWhNbGJzb3k4NU40M3k1SEtJSSsrTEVaT0Zw?= =?utf-8?B?RzlUV2F3c1JoSEV6TVVCV25PRmlWRGEyNTdHYlVkZ1RLZWxucTVabW9XcjdE?= =?utf-8?B?cGZHTzN1RnBBdVZwMnZSeWYxTnFRNmZlbFBZc2NLbmlmWTcxRVVVM1haRGgw?= =?utf-8?B?Tm1MM0dJZGFybWhxV29jVmNQcVdvVGhNRWpHa3MvdGNUQURVZDlkSzlYK3Mv?= =?utf-8?B?V1FCbzZoRmFPQytPUzJrNUxab3JTZFlYSHIwaWxtZmV6dm1hMFozV3krL3Ba?= =?utf-8?B?aDFrQUlVdFpTamhhbkR3SUUwTG82Z3RacnJQaU5DSUQ5VG8wVkUrblFCV0sx?= =?utf-8?B?K3RhVm9nckdHUXJYSTM1WGIwZ1B1Z1J4dFYwLzZhcU5XcFZEMHhENHFiVVUz?= =?utf-8?B?Z0FJWUI0Z1V6T2dsaVUyNm1pQmg4L1RSQlozWVhvdDdRejlNYllRUWJBbzk3?= =?utf-8?B?UGEzaktDTk9FWktsY0RNM2NiZjM1azYvME15M3BFa0EzN1lzWm03NVliWkJR?= =?utf-8?B?ZEViVUNQRlkxQWRXb2l2aXgyL2NhaE41OFZVaHE4cHVoaDlVTndlQkI3VU8x?= =?utf-8?B?UHpOWVBWQmZyVndOa2tOWWtaN2t3b3lZdEhlTy96K3RWSlA3VlZBdHdnZWVE?= =?utf-8?B?SXpTYWhkeTE0S01jaHhWUUk3ditJWGhTUzNIbllGOWFqU0NEeDZMaWxPTkVo?= =?utf-8?B?Y2RzYUkwNHJ2Yml2NEJZRHUxMkJ3QjU2WWpJMzNVUTl1bUZrUTZMNm9LK0tt?= =?utf-8?B?UWtyWHRydFhXZUF2THF6Z0pDWnlNNkdMV3MrT0pWUjlYYmtwS3AxeFRYbnV3?= =?utf-8?B?OHVCaUVDTytvQ3Y1TVJzT1dUWDdWV3ZLdVg0bStFVFFMaTY5L0c3aktxS0dx?= =?utf-8?B?TEgxQlgxNmJjMEw4NTlieW9BMVB6VXE0a0RSenNveHRnTVg3K2NmMVluR1pL?= =?utf-8?B?OUUway9xbUtaaE00eEY1YmJkUENVNVFDMnU4RDg4aXphN2x6UllMM0NlNTlt?= =?utf-8?B?TFRtRXRNWXlTT2xUbHp0TkFqK2JGVXZVM0htY1haYXRGRTdrbzNsZFg4VnBu?= =?utf-8?B?dnRQcFN0bjlBYkUvYStVN1FqdWk0OVZqYVhTbFY0eDIwdUtNai9pS0FqSWM4?= =?utf-8?B?bVgwbjU4VGxUSVZxRWE1M1lyTHJ5cVFWOTcwOVltWTd6WlVmcWFhaWhTOUcz?= =?utf-8?B?cld2M2FWTzlMSFVEeWcycHlSN2dJMXJVcVFSODF0d1l3dnY3ZWh4TlBVTUtt?= =?utf-8?B?WlR4TFR0YndsNHpoc1B1dG1ZcGVyRGt1VVdOU1gxOGt2emNmdm9uSFdjUXZo?= =?utf-8?Q?lfWAXIMqAb6+YDy41k=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR18MB5111.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWVpUzgrZ0VvTDZ2OVVxNnBzTGJWbjNwbEZnMEZ1WmZCL1Rwb1E1NzF6QUxt?= =?utf-8?B?ZlFFaWYrWEViajlhTnplL092WG9URk9KNlNGNTUvdFpBdnNaVlc4VmkvazYy?= =?utf-8?B?QnJuMnN0NVkxYkdXQkVyRUl3NnVuZkY3ZmJybStMV3ZrQjlpbHoveEo5TDR3?= =?utf-8?B?ei9SRy9pZ2tDTjNwVFQ4Z0hMREdqdk54RThOK3ZWMHdhenNxZjVZWVBmWFFS?= =?utf-8?B?MFpOOU8rR2oralMrRmJCeVFrLzE4aDA4UFE5dXhoYmhDYzBHVS9TRW9UVk12?= =?utf-8?B?dWxOc1kyK0VQZWdrRGozQjAvSDZjaS9uZnE1dUhqT1IvVExubXVpMmlvVWVF?= =?utf-8?B?aytVcklCZlNqU0RFeGZBUURXV1RSb0lVUDZhd0NjY3Vza296VjlIRUVPR1lr?= =?utf-8?B?SkdVdjZZVmNPazc4VVVVWDF0VFpENllKS0pMb25nMThaTE1INUtyMWNsQTAx?= =?utf-8?B?VjBDM3diM002M3MxTDZEM3UxZ21ZWHZWYUowV3VpZFQzaUZ5NzBNYUVZcUx3?= =?utf-8?B?OUFXVGQzWk9vTExmcnpXZGpTM3RCZEQ5UTZNdmw2dVZja3JVRUVyeldFem82?= =?utf-8?B?MUpVUlo0SndVbkluZkZFTWp4WUNkaXZSM1NDT0hQU3V4dThNWkZxWlUrbXAx?= =?utf-8?B?WmFMNVFlVEp1eHNvaEFhaUgrcmlrYTJQcnhvY3NyOE0wNGMrUVBiRW5QWFU4?= =?utf-8?B?RlpTWkxnWmtEWXJKM3pzYkpKVXFKU3FyOW4wREpXL3REWE5ZMmlJMFZZV3pt?= =?utf-8?B?elczaFFGam5STDkzU0dPSWhneXFOSmQvcUJuOXk0dmNWTi9kL0xGMEZMYmRY?= =?utf-8?B?UjZUbmZPV3d6SHQxdmtVVmhWNkllRHB5bllORVhaRmRPcmFyNEtadDNrZjB0?= =?utf-8?B?eExCaGFIR0srTllnSmpNdVRjWjNDaElwalYvR1p2Z0NvVFBFNnlsTVgxZHhl?= =?utf-8?B?OHdmN3dWOEZ1UU50YXdlRGh6bXpmWllMTnpxTXljdFBUOVRKSnhUUDZtYnRE?= =?utf-8?B?dWNyT21WSzE4cGM5RVdXY2pIeGhGRzVxMmtSQmJMNUtQZVBOaFl5QnFvc1BE?= =?utf-8?B?RzhlZHIzS3pNMHZ6Uno3NWR4dnJIWjJoVUpqREdZZ0dEV2FrTGY3SnBYRTRn?= =?utf-8?B?bFlvTWJlTFpBWWVoVDV4NlUxZXZzVGJrcCtYTjhKN2Ezc0FTU0lDY21OeCtP?= =?utf-8?B?UW1DK0ZhU085QXBYU25PaWY1cUpYd2JsOVBEZWthVCtNRi9IeG5jRnRqY2hv?= =?utf-8?B?NDdDTlE5NkR2L1pZc1MxQU1RUlJTY3o0VDZHNWk0NFE1cHA0ZzdzZ1QrUXpS?= =?utf-8?B?ZG83VWZhUW1nb2xUV2hHT1dPT0ZSSjhZTXpnaWFnR2sxcGFNbkk1d2didzZp?= =?utf-8?B?RjZiYncwbjhBTFZqbE9pZHZVNGc5Unh0S0ZlTkJVWWJPL2dTZzNqOEdIa2Ra?= =?utf-8?B?N21tV0FqUDJxMmlaa3MrOEQ1bm8vc3IwQWczVzJqTEtVVHZscmhLMk9Jcmxr?= =?utf-8?B?UnlybWhHUDA3NzhhTW00Q3I3bXNyVlEzSVZaWXdPMzZpZzVyRTFWNXJURWlO?= =?utf-8?B?TlJOUk5ocXl1bG4xMVNUa0xXMmxKQmcvV3kydE1paVhCNDdZR3k0VnlDaklp?= =?utf-8?B?VFU3OVgzRWZLN3p1Mk1FamtJTnpWQmdBY2dvbDJON2RZZUZUMU11eENCUXp5?= =?utf-8?B?UGpmTUlCRnFPc2RNdjJwMHF5NXY3ODJYbFo3SHlJZVlVMHRSVlhnTGc3SU1L?= =?utf-8?B?VkcxVmJQL3k5OUh3OEtXa3hHYStGK1hMRjErYmJGcGlXRUx0dWZVNElxSWds?= =?utf-8?B?cGgrb0szTXNZdDJnZkd1K1NFOWQ1aEI2NUFVZkNFWC96bW84ZHBsS3pTY1Rp?= =?utf-8?B?WjNhZUhyQkpDWjBMN1Z1bStKOXI3ZzQvMGI5Zy9lKzRzaTAvd1FiUk96Y3ZY?= =?utf-8?B?Rzl4cGF1VE01bDRiaDBwV2pVNExjK2FLaUxPeFdHekhkaHNoSFRKa1J0T1Np?= =?utf-8?B?OUxGNUhYb2w5VzNzaFhlL1o1b0lBUmo4ZDhLYzhwcEtRNFM0OENmQ3VUOUlu?= =?utf-8?B?VmpqU3pLekpVTEhXZzJtdmxJbXhFaEsvY013TU9nYWdXQUl3aVdRL3RwT2lP?= =?utf-8?Q?ypBzh2aJPsuYDitoIajC2LG/J?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5111.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3722694-a498-4d4c-e8e0-08dce7a52451 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2024 14:26:04.4000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5gEDcUXhRUwIg4Og8rPS2k9pErwI73/kH20UTRwzFkenCL1La77fna7gI0he3vGqMSVkNBmUxU29neiP1QuQPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR18MB4740 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 1q5PQ1MaByK5f_EPPpGZHLwjKT0J5s0M X-Proofpoint-ORIG-GUID: 1q5PQ1MaByK5f_EPPpGZHLwjKT0J5s0M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, I just sent v2 version for this patch series. Will add Robin and Christophe from next version onwards Thanks, Nitin > -----Original Message----- > From: David Marchand > Sent: Tuesday, October 8, 2024 1:34 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan ; > dev@dpdk.org; Nitin Saxena ; Robin Jarry > ; Christophe Fontaine > Subject: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph >=20 > Hi graph guys, On Sat, Sep 7, 2024 at 9:=E2=80=8A31 AM Nitin Saxena > wrote: > > Feature arc represents= an ordered list of > features/protocols at a given > networking layer. It is a high level abst= raction > to connect=20 > Hi graph guys, >=20 > On Sat, Sep 7, 2024 at 9:31=E2=80=AFAM Nitin Saxena = wrote: > > > > Feature arc represents an ordered list of features/protocols at a > > given networking layer. It is a high level abstraction to connect > > various rte_graph nodes, as feature nodes, and allow packets steering > > across these nodes in a generic manner. > > > > Features (or feature nodes) are nodes which handles partial or > > complete handling of a protocol in fast path. Like ipv4-rewrite node, > > which adds rewrite data to an outgoing IPv4 packet. > > > > However in above example, outgoing interface(say "eth0") may have > > outbound IPsec policy enabled, hence packets must be steered from > > ipv4-rewrite node to ipsec-outbound-policy node for outbound IPsec > > policy lookup. On the other hand, packets routed to another interface > > (eth1) will not be sent to ipsec-outbound-policy node as IPsec feature > > is disabled on eth1. Feature-arc allows rte_graph applications to > > manage such constraints easily > > > > Feature arc abstraction allows rte_graph based application to > > > > 1. Seamlessly steer packets across feature nodes based on wheter > > feature is enabled or disabled on an interface. Features enabled on > > one interface may not be enabled on another interface with in a same > > feature arc. > > > > 2. Allow enabling/disabling of features on an interface at runtime, so > > that if a feature is disabled, packets associated with that interface > > won't be steered to corresponding feature node. > > > > 3. Provides mechanism to hook custom/user-defined nodes to a feature > > node and allow packet steering from feature node to custom node > > without changing former's fast path function > > > > 4. Allow expressing features in a particular sequential order so that > > packets are steered in an ordered way across nodes in fast path. For > > eg: if IPsec and IPv4 features are enabled on an ingress interface, > > packets must be sent to IPsec inbound policy node first and then to > > ipv4 lookup node. > > > > This patch series adds feature arc library in rte_graph and also adds > > "ipv4-output" feature arc handling in "ipv4-rewrite" node. > > > > Nitin Saxena (3): > > graph: add feature arc support > > graph: add feature arc option in graph create > > graph: add IPv4 output feature arc > > > > lib/graph/graph.c | 1 + > > lib/graph/graph_feature_arc.c | 959 +++++++++++++++++++++++ > > lib/graph/graph_populate.c | 7 +- > > lib/graph/graph_private.h | 3 + > > lib/graph/meson.build | 2 + > > lib/graph/node.c | 2 + > > lib/graph/rte_graph.h | 3 + > > lib/graph/rte_graph_feature_arc.h | 373 +++++++++ > > lib/graph/rte_graph_feature_arc_worker.h | 548 +++++++++++++ > > lib/graph/version.map | 17 + > > lib/node/ip4_rewrite.c | 476 ++++++++--- > > lib/node/ip4_rewrite_priv.h | 9 +- > > lib/node/node_private.h | 19 +- > > lib/node/rte_node_ip4_api.h | 3 + > > 14 files changed, 2325 insertions(+), 97 deletions(-) create mode > > 100644 lib/graph/graph_feature_arc.c create mode 100644 > > lib/graph/rte_graph_feature_arc.h create mode 100644 > > lib/graph/rte_graph_feature_arc_worker.h >=20 > I see no non-RFC series following this original submission. > It will slip to next release unless there is an objection. >=20 > Btw, I suggest copying Robin (and Christophe) for graph related changes. >=20 >=20 > -- > David Marchand