From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCDEB45B37; Mon, 14 Oct 2024 13:12:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9180B402D7; Mon, 14 Oct 2024 13:12:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 0F710402D3 for ; Mon, 14 Oct 2024 13:12:08 +0200 (CEST) Received: from pps.filterd (m0431383.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49E9PHWZ005909; Mon, 14 Oct 2024 04:12:00 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 428xmu8e36-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 04:12:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ylUiTcromCvYp5MkvOxZYiphLjlIkfsOtmEIIJVqieltXjYnAfzHAPFgh9lbwZhDEpHll0UuLXP2GotJVse0VSgJmiolVrndGxBwHgF94BTLgn7LuQMIfz9mYkVplQHzy/UoLKQ04QMDkayS9kANq+p1xbP4m1HdhTuzW+FlsNPqNNv2EQ22PLusytCX/qdsEYkUe4xQ2OjDAv7AQZLpqvAHEKfEqVKv96/yngBof0Zvgb6TnZWbVJxiBThM1sTMqk2V+cgQHN9ZhinkiVhpMOp/Qzkh5PYkaFL1hEqSmW9YNgvpntmrD0uA1ErAopFsPh+WaKleOKBvMr6hH5+kBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1b8chW8MSJDKhxaCyFHEtjRtb5NI8bQy9a5VDUsm70=; b=ppndRx5rPkpgMW4LHVveNExpGPu4Kmk8ECh+3qsJl4iGd3AuAVGIddzrGw9EYFuY0LQzHkBIuMzUr09SblFwjNB5WEzB3Jpt5kDasLPwa+es52kgZ9UMufVy7bp8dRC5oqYkuO8UM+Vm838+cHVqYV2gu9ia4ZR3d5achjbdtiF9iCES1QbywINPmTxioTDJw/CgQfD9Mkd8qlrCcB9YrzDghiC4l3zppayEIdnNM8YwH32YPCoUd5H/mi0YTUjrQksYUSJsIm7w7asGlHaxw5Xq6IPbQ3x+D6zcphguf9zp9jkdbiD4Hm+FrqibgL0tiWAUFz12hAfasencn/BneA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1b8chW8MSJDKhxaCyFHEtjRtb5NI8bQy9a5VDUsm70=; b=dyhpvCHvXFD+OjgxQ/Lssyug5omXCacM0mfnLCLrZGkk+2dIAFmjYOcl8UUtn1FRSsMyPjbB+6RZCZbNotvGRrYfZDfoJNG/Axyl6BO98uQBxUdvk/FBXYkJ8yryGrRUWZFrvgPiGOkNMSUBmb+sWI3YOYz8ts8fGrXPshckzBA= Received: from SJ0PR18MB5111.namprd18.prod.outlook.com (2603:10b6:a03:43a::22) by DS1PR18MB6147.namprd18.prod.outlook.com (2603:10b6:8:1f0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.26; Mon, 14 Oct 2024 11:11:58 +0000 Received: from SJ0PR18MB5111.namprd18.prod.outlook.com ([fe80::d5aa:18b:1998:77b7]) by SJ0PR18MB5111.namprd18.prod.outlook.com ([fe80::d5aa:18b:1998:77b7%4]) with mapi id 15.20.8048.020; Mon, 14 Oct 2024 11:11:57 +0000 From: Nitin Saxena To: David Marchand CC: Jerin Jacob , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Zhirun Yan , "dev@dpdk.org" , Nitin Saxena , Robin Jarry , Christophe Fontaine Subject: RE: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph Thread-Topic: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph Thread-Index: AQHbGVi5LRXcm4D870aU/sBpd7FMo7KGH8zg Date: Mon, 14 Oct 2024 11:11:57 +0000 Message-ID: References: <20240907073115.1531070-1-nsaxena@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR18MB5111:EE_|DS1PR18MB6147:EE_ x-ms-office365-filtering-correlation-id: 9620bbaa-4ea3-4da5-1d0f-08dcec4104db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?utf-8?B?Wm4zV2dpcTJpMWU4bEcvUWh1ZmEvN0dvT2VQcDJ3V3hVOHJUYVVoTW40Wld1?= =?utf-8?B?TUhjaXZiUERTS1JHRUxlNk9oYzdJZ0EvVHkxdkFzUHloVmtZMFE5YWRMYkI5?= =?utf-8?B?WGRDZFRrSWJPU2F5SE9ZNUdBWWJ6aWxQUk5RWWJkd3p2d0hDMzZ5eHVKNzRY?= =?utf-8?B?SXR2aVVUVjIzb3JZaDZvaDhHU0psWUZDT2ZsTWVWamd0VVVKSmI2MEd5ZzNN?= =?utf-8?B?Qk93NGY2ak9WVWYxS09ybXNGdHRESFVvN2tsUkVoMDdNMFVOZDVLbkI4WEFi?= =?utf-8?B?V2lXMlpXVXZBUjQ2cXZ1alNaeEF4ZXZNcXMwaGN5ZHdXTitRbGlGQ2FEMlVo?= =?utf-8?B?MXlGM3Y2VXNPTlRIUnVnUGJLeXdYNzhCSzBjTWR1dWh3VkRDc09Nc0V5RTJ4?= =?utf-8?B?Zk1WeXJYNi96L0hyalp3THdxRFFvRGs4cFRkMHVndGVvM0xZdG42ZjkrTk5t?= =?utf-8?B?Tncyd0l5YXNxMUsxK1lDSnQvcGd4N29LN3FSbm9adWxpSzh0WCt6bmxNTVYw?= =?utf-8?B?bCtSTTVkYUxJdWRDLzNYczk5akl6VUpKSDhIUzR2NC9jUnQxQlJxdW9jbVFN?= =?utf-8?B?NVN5Njd3UXcrdHRwVVluZlpoNzVHeWRybXRYbjl6RlNJN2lsSDJianh0OUJG?= =?utf-8?B?QU9QNlA1WWRRa2ZRb21NVEhsZWUvQ3pBUjgyOStUUSs3bVBPZVRwRHBNNGxB?= =?utf-8?B?M3lHenQwVkFxVlNZNEh3NDdGaTF6cCtiemNDanN6UjZweHZ5dXZSTDVEaU5I?= =?utf-8?B?L1ZOTmV1OWdOM09HL3gyc0NDZ3dsSHRPWGh4RjhOUTZWeklzUUJuZVZjeEI1?= =?utf-8?B?RjYzSmkxTjhFWndWQjVISU1oRGc0dlpYOUovVk5zbnJlNFhNK0Q5OFRwZ2dH?= =?utf-8?B?bWZmZVJJc1ovOFB5Tm5uZTZBSDY1cEY0cGZGbXBKUkdjQVd0OCtVVm4zZmll?= =?utf-8?B?L1Y1dDVPRFlHakJTRnY2Q3ZFQU56VWlKcnpnM01DQmZ4VzJaRHRiZTJVc2Jy?= =?utf-8?B?UnN4blV0WGpkNW9SZ0Zkd3lMUzJWK2FOdno5enpobk85eHpqZm1jdmhYRkJI?= =?utf-8?B?SlZSamNlTUl1YUViTExJSklnUk5YMzRacDR3Z0J3aHUwei9ETkZCcWlYejRw?= =?utf-8?B?WFNydkNYUzI5WEx3VzBtbXl4L2IyMVRZdysvbjhHQklzSncveExtajU2Qndi?= =?utf-8?B?aDlUbmI1SHRuZWNlL0VSN0lwZ3AvbVUxUEV0bGI1RzlrbitPbFVmd0s4aDNJ?= =?utf-8?B?YjJsT0RxWVpsbkJ6OVhZM0dRZ2lkQlpQM3VFOGVoZFJDbHI0cG5DdDI0SEpM?= =?utf-8?B?dmYzc0Z6bVRaM2xCVCtvQ3lrdTA2RTk0NVdZd1BFblZkNXVON2IxOUx2V1U0?= =?utf-8?B?cDFNSGhwMCsvL3lZaXRaTFBWbldUSi84K0JYRFU2KzB1SFd6bzhaNVdtTHlN?= =?utf-8?B?S3V3dUp5akJaelVRaDVtK0duNkN4SjI1Zk5EbkRHTEhFWVlVYVp5dlFSM0xP?= =?utf-8?B?R3BaUjlGSzBMWWM5RVFhQk9PckorTkJ5b3d1b2JPNkVNSjhqeTdlMFk1TEht?= =?utf-8?B?N3JXRTBWaDBhN05ENnhqb25RL0VSenRtUW85NjE2VHlFaDhYN0dITSt2KzZB?= =?utf-8?B?bkZHNGxVV1I0djFmODNMZXIwYi82NXdoVmJMVC81ejlqMWJuZmh2b3ZTVnRB?= =?utf-8?B?eURmZ0ZsRk9vMDZwVFk4bHZpUll2VzU4ZUVXOFN3Q3p4L1pVOE9QekMxL05J?= =?utf-8?Q?AITPGtaHfeKlQNW1yc=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR18MB5111.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SWhYVVFvczFvMDQzUC9KVW44ZUU0aTdSUDAyd3RGcmFPMUhKQ25CbTRYQVFz?= =?utf-8?B?eEczS3R5bmZ1TFI2OWZRZFV3djN4bFJlU2FxdHppdHBtSy9BTnBWR2dKR0g1?= =?utf-8?B?U0VkUngxTTFjUzN0S2NSb2Z5cEhkZDJjKzZpeUtWVkUvTi92M095ODVpeE1m?= =?utf-8?B?VXI0T1VRY3cxYTlJanJiTkFmVHNRcHBxS0dTL0xac0J0MFQvV3JqaFVJSzRG?= =?utf-8?B?VDROdkNmUno2MTRzaEdmT1Z0dXNhcStyOUhESzd5VzIxT2c0QlpnRWw0Y21a?= =?utf-8?B?UTNtVWhrLzQzKzhpQlNQeCtkOHhpbG81OEhrbGJZMjFIbTVTRndQaWJId2hL?= =?utf-8?B?MGs5QytaUkt1YU5OM1lyZ3VNaTZSNU5jSmRUZTU0TmI4ME1GUkZ5dGVrR0Zw?= =?utf-8?B?OStXODhBRWdaMzlpTG41ZHpERjhBVlJhVG5PNjQvQTBpRExSNGpuTUhQc0dE?= =?utf-8?B?YkZaUEVPVDdnSlNoZmM4cTMvWlNsYk4xRHcvU2NCbEltUDFVWSs5Rm9xWFp6?= =?utf-8?B?cnF3NE5Scyt0d2FBS0tWUGpDVHFYeitIRGE5V1hUQVhGY1JKQk1NbjVUZXNu?= =?utf-8?B?a3JOaEU4bEhYMStNQk9qNmF4ek9JcHRqd0RjZXVxMWxuQXBxVzFpZmhlNzlv?= =?utf-8?B?SlpUQXkvSkRKdjZ2NzFaSjFpQWF2TWJsTEt2VGJCdVlhajZndkhDemlIOUNt?= =?utf-8?B?amlodHBrMFROVStzU3lYRnJJdkw3aFkzcUd0MHV5bWlpb3pyQVdLQm9FTjR5?= =?utf-8?B?UU5uVkhLaE5sY3FHNWFyYWFsTmYxUDAxRTZkQmdYZjlpR1lZa1VWRFpKd045?= =?utf-8?B?QWJNWW5XZXpOczN3bEovdkpYUVlkUDl6TWtnQmxFLzIxMHdjSVZ6cTFteUxV?= =?utf-8?B?ZFlmQTZuRktvUnMwRnFmMmxVcU40bDIrRXdpZDMzclJMcG1OemRCcE5CVGYy?= =?utf-8?B?Q1VIVUk3Y2xpbFF6RFJVVTNsd2cwU0hUVkIvb3FoclVzSE93clcvOU5nYUxr?= =?utf-8?B?eDlDclRwcmhXMWwwWXB0NDcwMDE1aWd6NVBpM3pBdDV1bkZsbmI0cDA1czBz?= =?utf-8?B?S1hCOS8xY2x6bDhzZVFYa0RLbDJZZ3ZPZEkzdVlSZ093OWgvZG9kd3A2dDM4?= =?utf-8?B?UnZlU0t0ZU5ETWNMUjJaUENSUFdIOXFMdlpYL21Fd2VWaEUxb0ZWSjNLa2dI?= =?utf-8?B?M1lTbVNPZjhWSk14aHVFVUhqRGRiQlg5VHdidktFMENRUTVybXE2YnZSdk5Z?= =?utf-8?B?ejJGTEhvY3hqLzhUU2VxcHhQZHc3WVYxc3RBSVN6QllHeTdaOXZLdjR1Q1Fa?= =?utf-8?B?Q241N01NbkdsTk02c2JHYStnekx3elJsNlVYQ0szNGF2UmNiR2FYOWRpSlZK?= =?utf-8?B?VkFWdVN3akpjVzg0Si8yZS9MOWN6MWdVYlBGRHQ3QjQ4RlFCeElPMm9vUjl3?= =?utf-8?B?bnltQi8wWWpMWVAzOWZyQU1La3VwbUNPVm9YSXhMcTVHa1pzQktNaUg2c0p5?= =?utf-8?B?WTkwWlVHcUs4VXpCWHB2YWVZRGRiMzFpOHFkZ3pySDcvYVI0UHpFNmJZL0ZH?= =?utf-8?B?TGQ1QkI2OExUMG9tUkcwblVpcTNQUmVYdTl4TGF4amQwTzRCM0IyRUZRZHVm?= =?utf-8?B?MVhNMUY4dlVoN0Z0SHdHZVBUK0prL0JrWndKU0dLTmFLclFFaFJ6WWZ0Q0o0?= =?utf-8?B?ZUswNlJSQTlQTnJmbkoyL25iR0NlY3VoWXJSaUNmdVdhRFdreFA4dkVKVk02?= =?utf-8?B?bUhUZkh2RVFidWJVS3kvU0ZzMExodVhwVDJKZnJEek1ra00zLzJLZE02RHVZ?= =?utf-8?B?Y1FqZFZ5UnJQeXNlOEQxT3VQcEFHdG9oQmZzZnZkL0NXNjRZMTRtTFpWdXhk?= =?utf-8?B?L3o0cHhKNDV4VEg4U3NIMENSNlFUeXNrN3FmMndRRWNDUWNXNXBGbnBoV3Z1?= =?utf-8?B?V3JiYk44ajdvUFN2cmIzTXo4WTA2WWplZ25GemJHWTBCWFlIOVIvQ29wdnh4?= =?utf-8?B?eFFUajhrUldsTGxlM2ZCSGhjQ2JEdXhJeDRtellXT0xFaWt4ZlhENXplQlhH?= =?utf-8?B?N1RFcU0zZHg5elRybXh4M2dHbEgvdVJxMm1xanJJRHdVRkxjSjREUHRpUFVU?= =?utf-8?Q?wgZVBf7oWYjLvv1cAyKVo2Y5C?= MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5111.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9620bbaa-4ea3-4da5-1d0f-08dcec4104db X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2024 11:11:57.8159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OATfsIQfeTDhjq2wb4YQprfVv9GajHim2oaYLfyIBegxPKZ6yKeaIImamrteEa4UAXgJN4g/v+P/CfXdoXumqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS1PR18MB6147 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: sNiF_56lhl1HNV3lQIlykZnncel_vpku X-Proofpoint-ORIG-GUID: sNiF_56lhl1HNV3lQIlykZnncel_vpku X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.687,Hydra:6.0.235,FMLib:17.0.607.475 definitions=2020-10-13_15,2020-10-13_02,2020-04-07_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David and all, >> I see no non-RFC series following this original submission. >> It will slip to next release unless there is an objection. I had pushed non RFC patch series before -rc1 date (11th oct).=20 We have an ABI change in this patch series https://patches.dpdk.org/project= /dpdk/patch/20241010133111.2764712-3-nsaxena@marvell.com/ Could you help merge this patch series in rc2 otherwise it has to wait for = next LTS Thanks, Nitin > -----Original Message----- > From: David Marchand > Sent: Tuesday, October 8, 2024 1:34 PM > To: Nitin Saxena > Cc: Jerin Jacob ; Kiran Kumar Kokkilagadda > ; Nithin Kumar Dabilpuram > ; Zhirun Yan ; > dev@dpdk.org; Nitin Saxena ; Robin Jarry > ; Christophe Fontaine > Subject: [EXTERNAL] Re: [RFC PATCH 0/3] add feature arc in rte_graph >=20 > Hi graph guys, On Sat, Sep 7, 2024 at 9:=E2=80=8A31 AM Nitin Saxena > wrote: > > Feature arc represents= an ordered list of > features/protocols at a given > networking layer. It is a high level abst= raction > to connect=20 > Hi graph guys, >=20 > On Sat, Sep 7, 2024 at 9:31=E2=80=AFAM Nitin Saxena = wrote: > > > > Feature arc represents an ordered list of features/protocols at a > > given networking layer. It is a high level abstraction to connect > > various rte_graph nodes, as feature nodes, and allow packets steering > > across these nodes in a generic manner. > > > > Features (or feature nodes) are nodes which handles partial or > > complete handling of a protocol in fast path. Like ipv4-rewrite node, > > which adds rewrite data to an outgoing IPv4 packet. > > > > However in above example, outgoing interface(say "eth0") may have > > outbound IPsec policy enabled, hence packets must be steered from > > ipv4-rewrite node to ipsec-outbound-policy node for outbound IPsec > > policy lookup. On the other hand, packets routed to another interface > > (eth1) will not be sent to ipsec-outbound-policy node as IPsec feature > > is disabled on eth1. Feature-arc allows rte_graph applications to > > manage such constraints easily > > > > Feature arc abstraction allows rte_graph based application to > > > > 1. Seamlessly steer packets across feature nodes based on wheter > > feature is enabled or disabled on an interface. Features enabled on > > one interface may not be enabled on another interface with in a same > > feature arc. > > > > 2. Allow enabling/disabling of features on an interface at runtime, so > > that if a feature is disabled, packets associated with that interface > > won't be steered to corresponding feature node. > > > > 3. Provides mechanism to hook custom/user-defined nodes to a feature > > node and allow packet steering from feature node to custom node > > without changing former's fast path function > > > > 4. Allow expressing features in a particular sequential order so that > > packets are steered in an ordered way across nodes in fast path. For > > eg: if IPsec and IPv4 features are enabled on an ingress interface, > > packets must be sent to IPsec inbound policy node first and then to > > ipv4 lookup node. > > > > This patch series adds feature arc library in rte_graph and also adds > > "ipv4-output" feature arc handling in "ipv4-rewrite" node. > > > > Nitin Saxena (3): > > graph: add feature arc support > > graph: add feature arc option in graph create > > graph: add IPv4 output feature arc > > > > lib/graph/graph.c | 1 + > > lib/graph/graph_feature_arc.c | 959 +++++++++++++++++++++++ > > lib/graph/graph_populate.c | 7 +- > > lib/graph/graph_private.h | 3 + > > lib/graph/meson.build | 2 + > > lib/graph/node.c | 2 + > > lib/graph/rte_graph.h | 3 + > > lib/graph/rte_graph_feature_arc.h | 373 +++++++++ > > lib/graph/rte_graph_feature_arc_worker.h | 548 +++++++++++++ > > lib/graph/version.map | 17 + > > lib/node/ip4_rewrite.c | 476 ++++++++--- > > lib/node/ip4_rewrite_priv.h | 9 +- > > lib/node/node_private.h | 19 +- > > lib/node/rte_node_ip4_api.h | 3 + > > 14 files changed, 2325 insertions(+), 97 deletions(-) create mode > > 100644 lib/graph/graph_feature_arc.c create mode 100644 > > lib/graph/rte_graph_feature_arc.h create mode 100644 > > lib/graph/rte_graph_feature_arc_worker.h >=20 > I see no non-RFC series following this original submission. > It will slip to next release unless there is an objection. >=20 > Btw, I suggest copying Robin (and Christophe) for graph related changes. >=20 >=20 > -- > David Marchand