From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DDBDA00C2; Mon, 23 May 2022 15:35:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC69D410E8; Mon, 23 May 2022 15:35:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 215DE40E78 for ; Mon, 23 May 2022 15:35:09 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24NBMW8x027049; Mon, 23 May 2022 06:35:09 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2168.outbound.protection.outlook.com [104.47.57.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3g6wepe7tq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 23 May 2022 06:35:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D97AI2kJiGBPUfERsbVSIl1AzZXPg9Bls+agPR/cfgPbGYXhn7nanT+ZaDxDsXRosYe0EozPLHiJ9nKl2DPZE64JmxNcP/G16XsbDgccl7r52/jV88gFxVUds7OIGfXzR7cboPv1uqpdvFOmUXu3W6NXwQsdan6eoyAIpTgcgiscmgiweLPsfFkTsOgjWkxvz+tuaatGYCGdO/lT9DG2NtQB/vQVqs8vVzUsgzeIsXkCnjjsdvE+gn/PHgWM+OGD0Rrui8E49G2oZE/71p562PeN5ahq4BhZz91JT54fVzkVfC+JsFkuT70EYxJSut1nSLh7o0hyfYMdZ2ENXjrdNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z15z2yITawW9sQLoD17N2G8MQ7djNu1dnTgkGTKlHmo=; b=VheFboW3ZxeFvXJXgM1dQVg443SBiYQIK+hB+O7i/42cfJqs8aioZksTs+kloFmJP00+9ehyXoF6ae3qrkFXkP2G2HsLhVfpig+y2XSSLwk0zMa65qAiszgQwboBIKIRFxH0T/bLnVCd9Y2Zzt95iX6fU/w+zG2ThCVVfzMfXaIVrzoZzjzvDIm93Ry7pPDL1ItqrtwPVz4MxeeibGQD797YiWmdpmFyMAU3PEjenEPoj+ZDpPJiLvF0NfPGbuDneDwTcoDfw//fbO2MG1y49fkLkkq+tK+eKLHK4RFfCM9BEzAaRykTS7QXD3iMEgeUPoXNdgqmoc/Qeg7I3fosNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z15z2yITawW9sQLoD17N2G8MQ7djNu1dnTgkGTKlHmo=; b=SwNRayw46sUqNeMWAIkpFmWduWviodwdwW4vqzUZ50x0u1uk1ESuWzcgt06NHIJYalwpR4JzNKYF/h+ird5x6xhNuwkyzp6BlnOEoHssavaKV5xqdHtJkyEM34Jod9I6rfIDwkSMmcLgK6YY1DRCHlH3h9ie3JlxjVHnpI8N1o4= Received: from SJ0PR18MB5161.namprd18.prod.outlook.com (2603:10b6:a03:438::6) by DM6PR18MB3388.namprd18.prod.outlook.com (2603:10b6:5:1cc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.22; Mon, 23 May 2022 13:35:06 +0000 Received: from SJ0PR18MB5161.namprd18.prod.outlook.com ([fe80::8866:23dc:684:3f1f]) by SJ0PR18MB5161.namprd18.prod.outlook.com ([fe80::8866:23dc:684:3f1f%7]) with mapi id 15.20.5273.022; Mon, 23 May 2022 13:35:06 +0000 From: Amit Prakash Shukla To: Bruce Richardson CC: Anatoly Burakov , Ciara Power , "dev@dpdk.org" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] Re: [PATCH v2] mem: telemetry support for memseg and element information Thread-Topic: [EXT] Re: [PATCH v2] mem: telemetry support for memseg and element information Thread-Index: AQHYa7JP9/+d0+9qfUOmRTFHaqS34a0sVSYAgAAl/lA= Date: Mon, 23 May 2022 13:35:06 +0000 Message-ID: References: <20220519063038.637836-1-amitprakashs@marvell.com> <20220519185712.879487-1-amitprakashs@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f440ce86-8ffe-409b-fdb2-08da3cc10c6c x-ms-traffictypediagnostic: DM6PR18MB3388:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IRGJ6to0YSX5fwLYioQt9fHyQj1pPmHyoghE9J3qnQu09I9mgrIt23k1mvsIZ7/Lse3Z2mWTYKoRbQR0521uYzbHJ5AaQNQE5cZ9poAJbBnS0MtrfGXavyac3pjj28nAHzIECcdQIDwm6wlTRNtpyvZEsK/lqG7E/XlRHHgPKBGiK2wo//mCy7880RJ/SFLyZb9VeW3HPkgXjJH55MtKkpfur4Uy9VSAzGZQawTziH5OG9bpE5Dz4S8tRw063d9MWCDwmbd0XIZp59QrYXORv44404A3Gz47rDrfjGfsqSRIONbGzi0D8CYJN2bxvlYsAPsXnYe2qZlCtvtpYCGI46OzfNTMYN7IjbCprkGvrXIzaARjTNqyh1vTV4OS9w7HDPNxBXcz568O3gMaVqlhmyPKPfB7EgthPqx6xQ4OA7yoh2vxvZXH6hR8K7W+mYB6d9hjejEyaSENYK8zeE4CgiFoQa515VreFdsNvxc4zRZRy7XUxo2ATKwd78xHWb14Lyn3AZxDBlpCpTe/MabxLPNL8xgrG/5DR86ndU8r6cUTl3ML9rVaqciFkE73+Apf/yRN+FOXkPcgk0C/ngpT7SFwv96engwUWRgaxtd2G0o23N4/ApdYeD+gf0XZvyitbXqqVMbBcNZtrhF8DVF32Y368Ga890i11CiVPBQF8HOjx9Y97BlUBmhLm8Fw5kVkHn8OFa53hOecs9CbZ10v2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR18MB5161.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(53546011)(186003)(54906003)(33656002)(316002)(76116006)(52536014)(8936002)(8676002)(64756008)(66446008)(66946007)(4326008)(6916009)(66556008)(66476007)(7696005)(107886003)(6506007)(122000001)(9686003)(71200400001)(55016003)(86362001)(5660300002)(83380400001)(508600001)(38100700002)(38070700005)(26005)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?i0FPzKFET+WLz3Aj7IU7D6Qy5BuNqxcRVEbBLqf7dSlqd79G2TGKOHm0Z1cS?= =?us-ascii?Q?WIgo7OWErGZX1qpVAtVtGeQCGH+4qo0Qg/sM9lg1J0P8ItjeysQXxbV0OT9U?= =?us-ascii?Q?VV7WsOiNkPULnW9GepdvZSdGLKfJc8mhC0PntjE200dm4uOK+34XOkl41CAk?= =?us-ascii?Q?22eSXnXXL/yWQRkLnYsEf6HppfRz0ZkeW/fZK6w1qhTX2hCdImUFT2YuTH4H?= =?us-ascii?Q?WwMgWKwe9wpGK/KLZzoDXu/3cDkU/Oxo1RO74oJTgN7qW/YmOTgQhdstdFr1?= =?us-ascii?Q?UsJazsi5/FM0570u2QUYtqG56jeS0lcSk/RT7eBIXwPVj11Yibjj1DmnOFtC?= =?us-ascii?Q?1xJEYEYrfwUy04crQfXVKEknwnW1zlYs2AkN8jgnVTpAEvHl3t8cqVdxg4/Y?= =?us-ascii?Q?CVKFyKZiEoiu/MrLEmCHSx7XeL5W1D1fjeo2nc4+JpAhG64ogR9qJ7wr4DqG?= =?us-ascii?Q?nplzJqCFHcGIRdqqIlvTdyH33/RVEg3nqqc6zcv9mUONJ0h3qgQZv7U0cASi?= =?us-ascii?Q?H5bNgvS0wKa9WYaGq/e+zgAhVx6zgw+KqLCpNRJlIRLxNhrXCvt9E7h7Vy9d?= =?us-ascii?Q?G6G9ivEgNfBAlP5H4kFapYU455Fl5kmcF6+U5YwjbaGAacshQrY/M+aHMn8x?= =?us-ascii?Q?5UIxF9n6ct07E3mhAGO1DBHwMBHYurIxPbeimhjnym8RDlWXV5XbWPNuqZKi?= =?us-ascii?Q?vg68GGISZVCg0H31IVBrKI8tcHUdiFUpV+XgOcA+GeCZwSpdNiMXNRVCR8Jr?= =?us-ascii?Q?CEx+zF7ejseAbQ3W1gcr40JSyMpsDiOaP72DKaK+mjwJ6qK7dbS/6OrJnPfC?= =?us-ascii?Q?T44EKY/CQn4w42ctFLYfR28yhKQVQsUsiatVGoWoFmNG5gsh2u2XUtKm5E9n?= =?us-ascii?Q?cVRUGpmTo7bXd4MWDOLAB04zVBQ0bRhkdKKM7Jl1D2DGxqdAv6zwAS8QEodJ?= =?us-ascii?Q?TZCcwSamL763QXlnTN2mjquu+MZ/gCl36HlWmf21omuiTYWXzfP81Pzxoii9?= =?us-ascii?Q?h1BYDXFuTn/kWYlQXXK2N/PZiPjSBo4rCtgNYlzt4/1bTtpmAytTZeZvLdnL?= =?us-ascii?Q?MFRBJ/WI39MqHC8S+cUj99H/RGsnH1ae0PsAuCeaJG+zWo/DUoBEbDlCY9dW?= =?us-ascii?Q?4maBvTKeo0vAwxnXda7E0WXIPeyBEGAT5u9x7iAFqZs/F/DB0w/GUVxG8CFB?= =?us-ascii?Q?RsZURLqdbxTRTe7sGjxnggN74z5MjnFP1k1p1QkKvodCpUkREwevV86jM93z?= =?us-ascii?Q?ZhYguXJBeV0/oCpuHlNdz6LKh5SoirrGOeSxqVLuvgjQKCoCmtTHcQw6VWzP?= =?us-ascii?Q?01IROd+8IcXspVle2C1uQnz6pfxuQlJAJ4BE121z80/UfvAqTgBZl38UIweL?= =?us-ascii?Q?NHa4jW7HThS1vN3vJOfbbzdOTmNlsd4+mPED1vjnQ+Ir8zQsh0jzb+GIvn0d?= =?us-ascii?Q?a7lsT76ss2QP7SD7lfZafgrEpFrTtrhEE8tuc1iHrwkkbrCnjxU1s19IKqo+?= =?us-ascii?Q?UD8NJQ1L19fdC5uEJxDZAS/dfZIOciGtAiVRvxvp+RCal4LqY+MucJEpUheN?= =?us-ascii?Q?ZEVnRCkEdI8Lk5YgcsLEmautCXxfAAGnRK5qZLJ7g4dgyilXt6XwQPT/dPdD?= =?us-ascii?Q?PQO47A/xDEufAcJbTHdJXBZ2b+8xtzbdYEyAHuqbe5vFJlPspKW7OFvlUcPQ?= =?us-ascii?Q?M+DSFQn5DZ779RKh1qXRRy1Z3Gzdrt+H4tqmY+/DydZAMGpvMMxKlt/QzxzY?= =?us-ascii?Q?Vvj8+KwvBr7gAtmsBMQianB9mv4BdQA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5161.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f440ce86-8ffe-409b-fdb2-08da3cc10c6c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 13:35:06.0858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PetjnU74GCGdDE4d2AbzZkt1AMLZRRkxdF/qhGu5cpvDiEtIwpIR1C9MjPQvQed7SMJlIhRxzVDb8gEwSKojjHHeeBUlNkBMAAinC2Dqkmk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3388 X-Proofpoint-GUID: tNASRwMo_jQxEC08z3SVWlQB5iG1tEC3 X-Proofpoint-ORIG-GUID: tNASRwMo_jQxEC08z3SVWlQB5iG1tEC3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-23_06,2022-05-23_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Bruce for the review suggestions. I make the changes as suggested in= next version of the patch. > -----Original Message----- > From: Bruce Richardson > Sent: Monday, May 23, 2022 4:45 PM > To: Amit Prakash Shukla > Cc: Anatoly Burakov ; Ciara Power > ; dev@dpdk.org; Jerin Jacob Kollanukkaran > > Subject: [EXT] Re: [PATCH v2] mem: telemetry support for memseg and > element information >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Fri, May 20, 2022 at 12:27:12AM +0530, Amit Prakash Shukla wrote: > > Changes adds telemetry support to display memory occupancy in memseg > > and the information of the elements allocated from a memseg based on > > arguments provided by user. This patch adds following endpoints: > > > > 1. /eal/active_memseg_list > > The command displays the memseg list from which the memory has been > > allocated. > > Example: > > --> /eal/active_memseg_list > > {"/eal/active_memseg_list": [0, 1]} > > > > 2. /eal/memseg_list, > > The command outputs the memsegs, from which the memory is allocated, > > for the memseg_list given as input. Command also supports help. > > Example: > > --> /eal/memseg_list,help > > {"/eal/memseg_list": "/eal/memseg_list,"} > > > > --> /eal/memseg_list,1 > > {"/eal/memseg_list": [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, \ 12, 13, > > 14, 15]} > > >=20 > This is really confusing because, if I understand this correctly, we hav= e a > conflict of terms here - in telemetry "list" is generally used to get the= possible > values of ids at the top level, with the info and other commands used to = get > the next level of detail down, while the initial command here returns det= ails > on the memseg lists, i.e. it should really be "memseg_list_list" command,= i.e. > list the memseg lists. Can we perhaps come up with a different term for t= he > memseg list, because right now I think the above commands should be > "memseg_list_list" and "memseg_list_info"? >=20 Sure, will change the naming. >=20 > > 3. /eal/memseg_info,: > > The command outputs the memseg information based on the memseg-list > > and the memseg-id given as input. Command also supports help. > > Example: > > --> /eal/memseg_info,help > > {"/eal/memseg_info": "/eal/memseg_info,: \ > > "} > > > > --> /eal/memseg_info,0:10 > > {"/eal/memseg_info": {"Memseg_list_index": 0, \ > > "Memseg_index": 10, "Memseg_list_len": 64, \ > > "Start_addr": "0x260000000", "End_addr": "0x280000000", \ > > "Size": 536870912}} > > > > --> /eal/memseg_info,1:15 > > {"/eal/memseg_info": {"Memseg_list_index": 1, \ > > "Memseg_index": 15, "Memseg_list_len": 64, \ > > "Start_addr": "0xb20000000", "End_addr": "0xb40000000", \ > > "Size": 536870912}} > > >=20 > For telemetry library, the parameters should all be comma-separated rathe= r > than colon-separated. >=20 Sure, will change it to comma-separated. > > 4. /eal/elem_list,:: > > The command outputs number of elements in a memseg based on the > > heap-id, memseg-list-id and memseg-id given as input. > > Command also supports help. > > Example: > > --> /eal/elem_list,help > > {"/eal/elem_list": "/eal/elem_list,: \ > > :"} > > > > --> /eal/elem_list,0:0:63 > > {"/eal/elem_list": {"Element_count": 52}} > > > > --> /eal/elem_list,0:1:15 > > {"/eal/elem_list": {"Element_count": 52}} > > > > 5. /eal/elem_info,::: \ > > - > > The command outputs element information like element start address, > > end address, to which memseg it belongs, element state, element size. > > User can give a range of elements to be printed. Command also supports > > help. > > Example: > > --> /eal/elem_info,help > > {"/eal/elem_info": "/eal/elem_info,: \ > > :: -"} > > The last 2 arguments "-" is to print range of e= lements. Can I use hyphen here ? > > --> /eal/elem_info,0:1:15:1-2 > > {"/eal/elem_info": {"elem_info.1": {"msl_id": 1, \ > > "ms_id": 15, "memseg_start_addr": "0xb20000000", \ > > "memseg_end_addr": "0xb40000000", \ > > "element_start_addr": "0xb201fe680", \ > > "element_end_addr": "0xb20bfe700", \ > > "element_size": 10485888, "element_state": "Busy"}, \ > > "elem_info.2": {"msl_id": 1, "ms_id": 15, \ > > "memseg_start_addr": "0xb20000000", \ > > "memseg_end_addr": "0xb40000000", \ > > "element_start_addr": "0xb20bfe700", \ > > "element_end_addr": "0xb215fe780", "element_size": 10485888, \ > > "element_state": "Busy"}, "Element_count": 2}} > > >=20 > The "elem" name is ambiguous, I think. Are these malloc elements or some > other type of elements. >=20 These are malloc elements. I will change the naming. >=20 > > Increased telemetry output buffer to 64K to support large size > > telemetry data output. > > >=20 > That's a 4x increase in max size. Is it really necessary? Is telemetry th= e best > way to output this info, and do you see users really needing it? This change is not required now. The code has been internally optimized. I = will revert this change.