From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2A3D43AC4; Fri, 9 Feb 2024 12:30:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BAC5942E64; Fri, 9 Feb 2024 12:30:41 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 2CEC640697 for ; Fri, 9 Feb 2024 12:30:40 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41956DYk014606; Fri, 9 Feb 2024 03:30:39 -0800 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2041.outbound.protection.outlook.com [104.47.74.41]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3w4qsq56rc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Feb 2024 03:30:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JT+unoQkyfEfkMIzHEBWa29Zx0K4iLQF5zjVeCvLr/Qwl+qMmbCfqC5bcfRb6a8e1A28ozR/32oHoCE4HNxK/zcToM2fEExQus9mq6/GWNqkWWM7tLCv6Am6TsQ7fSnQFP5h1/Y+NehSUmzBSvutVVd8UnbYqg66Pg21GzqgRxKsVw0hOlXF9kUlzMd/vkft9YKy7HYJoJYf783AtnO44aUMwVLd1DTq8qsCnQWkNEXn7qGCTbCQ7kNsecB+xtvEmTTReAGup37BlMuko/FXTnYUtDLMVk5oi5YBjnzr7xdHp9/JuaTvmALuYL0ogMzsOELLn4r5i6nmJ9XJOuKzKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lXrJfPoOW4F+lGNQR3E1hnfQIHDQ76xjMiDZLI32XtY=; b=CRfFTJbap0bPjx8lj6s0FBdoZdeUH0a2AZXfDz/tx9hTPT8ApvWfsHtLcxaZP8f5qVyrGTIFqy8q/9zvlVpm411nbAW+GMYXA6xLzUdlLirbxNvn+06BHD37WO1w02Hgf8fV8wZvm+OahwZ2pVujfZUC51JfGXNClYYq5Aipfza2W3sh+/KMaY3SLt9n9gkOSaRW7XY3wfXiv6u0o8GAixfFfip33Ax9crxbvqyjTTddhUiWj6/tXRU6kbdvmeuryhUEVVh75UuN2V6+QYC59bGMZ8aYl/MLRXe4drfiSI1xrDK717n5pH9yRrmv6MzVDAfo8y+WfYq/UROmTwgX3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lXrJfPoOW4F+lGNQR3E1hnfQIHDQ76xjMiDZLI32XtY=; b=V/XGJ4QrkV94eCDZKxqkFAvuQ6+KvWJY/0vgg+2OXJAbrNqjTXQAwolxDoLP8vrhC5ab0EGnoGqMpd51Hb+ZQsqRnV6FbESbyIcLn877GmRpcpX4Ham/hYDC0kvHAVB2k6Mo31qMmrkBA/tWMvbjj06SyGdOtTXBua0gVgYXCvU= Received: from SJ0PR18MB5161.namprd18.prod.outlook.com (2603:10b6:a03:438::6) by SJ0PR18MB4494.namprd18.prod.outlook.com (2603:10b6:a03:3ba::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.24; Fri, 9 Feb 2024 11:30:37 +0000 Received: from SJ0PR18MB5161.namprd18.prod.outlook.com ([fe80::c204:20a9:f3d6:62dd]) by SJ0PR18MB5161.namprd18.prod.outlook.com ([fe80::c204:20a9:f3d6:62dd%7]) with mapi id 15.20.7249.035; Fri, 9 Feb 2024 11:30:37 +0000 From: Amit Prakash Shukla To: Thomas Monjalon , fengchengwen CC: Kevin Laatz , Bruce Richardson , "dev@dpdk.org" , Jerin Jacob , Vamsi Krishna Attunuru , Nithin Kumar Dabilpuram , Anoob Joseph , "mb@smartsharesystems.com" Subject: RE: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID Thread-Topic: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID Thread-Index: AQHaMmqfmaOKR3fmXEaOdypDH4D7HLEA8iqAgAEKLoCAAChFYIAACfOAgAABISA= Date: Fri, 9 Feb 2024 11:30:36 +0000 Message-ID: References: <20231208075526.2696553-1-amitprakashs@marvell.com> <069660f9-2940-23de-4b6a-beaea1acf944@huawei.com> <2153070.3Lj2Plt8kZ@thomas> In-Reply-To: <2153070.3Lj2Plt8kZ@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR18MB5161:EE_|SJ0PR18MB4494:EE_ x-ms-office365-filtering-correlation-id: 8e7cbc49-751d-468d-5be7-08dc29628981 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d6lgOWuhlyLp0OCevtxYX+CLhEcguSFtjcZc5Q9yHY5++7D87KA6WkIZwwc3C5H0JUXHuuQAqzirF3TfqAsJhNjldM1BQFJ0oLa5ZrFjtuohzTZ/78LMKaqOiENDKdv8lnwRnB4+trhI8ESFqVeUpDSg9xZJ8re2KIa1Xq60cUWVw5+DEZP8tD3dzIl/5UoPneuxeMpsDDvtyn/kReOPdABTvgqQ8qdaE3VHMRbalE2zMND/NkxiKkp0BMSGZUt1AEMN9OG2vICO0f6n7QgKD7qTvw0tGI8O+MUTuei1u0tMD5WGxZE4DR4xSj1x+vH0xD8B+xOGv6LPBDg9ZsjV/dGAb4uwkoU0QGJ9WRwK5Y3IS6sEIZoUFqGw+eUDFV9iDBRcdPPcIKjGLV1IUtuLis0e4vlbADHj8fVeSoKDPS3N/I82JDjUmbEG6jJ7Fr4nRIe+7onPwINRf0d4zElRZyRRJcQgibIWoSqH8juRWxq0c14/xnzy+Z0+WLxioCI0jq3Vzgd3rPHN1lP5q6qxIFb1aQ+oIl88DG+oDapnDPjtI5IgYmiYjM23LwLsqwMfJxn378Vz3RGU5VvhIhiw8J3nek7H+WDXMYyc9ZAaw1XA4iaa2SPuirTbZuJ1+GJM x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR18MB5161.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(366004)(396003)(376002)(346002)(39860400002)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(122000001)(33656002)(66556008)(38100700002)(86362001)(478600001)(54906003)(71200400001)(110136005)(316002)(9686003)(7696005)(6506007)(4326008)(5660300002)(2906002)(66446008)(66476007)(76116006)(66946007)(64756008)(8676002)(8936002)(26005)(41300700001)(52536014)(38070700009)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N050pqdi0QDux20Q0du99BZt74pAy6e6GuJddvzgjglKabZfyT8u5/FfUsyi?= =?us-ascii?Q?ZPdmhclKZZ1quDGaGs1IK7Rm6xiFIwP5uTeitR3/03+y2PrkBe/40+rbb8ad?= =?us-ascii?Q?HDTlBhNEBc20HixbOWwHgCn4Rb5gzKAiNvnr59swFMXWJMfCaaVzM8f5z8c5?= =?us-ascii?Q?geiIZRvIM4T+NZdY7ODcRkUgOVE02PaJsX7bffVbKnDMzdMkpvBwCfm3Dvdk?= =?us-ascii?Q?bDD3f0zmk9Z6RAu2dep5T3vHgBatMm50rOEk/c7GVoeDF8WafsZofxPrZOFC?= =?us-ascii?Q?0A53vUYwP93q31JQPu58uvYqHm/tTDgTw0T5PwhP6vJwHnFCe3QRfV2c2Sht?= =?us-ascii?Q?maRgkNzg3pOQk3v87S33brOv5/okDiK6NbUDG7Nl2PoPW4xUDikTEN1m30nH?= =?us-ascii?Q?uBDaB5BTA+OHee/KD0IpE2vDPMrfnZRt2o1hU3YGpY7oZ/gTO8WGmJ0uTWJt?= =?us-ascii?Q?iXqhWvwr25IKHfrXblvgHHeU79i2ZOWw+iiu5xKfjUnMaGxbmVZnYXRzzPT8?= =?us-ascii?Q?Pri5idnEz0Kh/c9A4fhvvv2bHVKDUBzGumGl3nkdn+yubnYal6Ea/pRm2D/g?= =?us-ascii?Q?633Qu7x0L49V6HdYdbM8wYBNJaQSMy63J5xZKh7FCJpZhtsG4SDUwfyQgxvf?= =?us-ascii?Q?q7O8iumionwOpCOnrw9+cgJ7XX7A8Zy9Jd7SuhUmWyQU5YEBaV6gjNhWRCGf?= =?us-ascii?Q?5MMD6g39jKk3Vqir5oukLkfOMMnqhL+AmhICj70aUQs7zgBYemZedZNsatTU?= =?us-ascii?Q?s4PEF/8EtbsMIekQrjTXa+BXp2ZkAGCgiK4SPiglFNYzuFP9tZF+kxs2IsN0?= =?us-ascii?Q?gT2SAlICIteHwMy+rfSMOV1KHwHk26ng+VEXEszR6wxsQXtjg6zIcr40EnwY?= =?us-ascii?Q?WQI9LK9b0bGCWGrRzemcrlKSqREoi4H2j/HoEuhNYaMLDReC81k2gLur++9S?= =?us-ascii?Q?afXMhBfmx1j+Ht3FdQIc/G0n7H6VNjzEpitH3OyHeC+BDP2oJFR1r54pMbjL?= =?us-ascii?Q?tbrZbgY736SnQzY4SDEPFALpYfdnPLI+vPn0WzmENj24i0HS4GazA0tPrw/q?= =?us-ascii?Q?QFQcdrLQqA0JaPX306pokBLEArY+7nsd0xL2ODLkHA9aucL3h02g/j17Eyci?= =?us-ascii?Q?PBkRGK+TxInjjERs4RJtPVhXI51bAN2lAkSTv84Wnfp2n4nLGHFt/ERZ/vPn?= =?us-ascii?Q?hUH947eq1greRxeJ8LeutOpgvgVl5Ny7vEZkeHfFVdZ2lu644Of/r2uQJ8ol?= =?us-ascii?Q?f0V0BKAfHumSs7vNge/t/6nVOi5Nvrmc9Qp4/FP97ZRsJLG3wrlMmIKfahih?= =?us-ascii?Q?kSk3BoAFS7oSnIPCyVPJGGhPhiGmya+R2VCYzNlZFz/miSct29tfDmxWKdEu?= =?us-ascii?Q?f/3KiIJO6KCH7xn0UTmC2EcxmSni7AGRmsZsjAVqUgRaY+gP7IGEKSE0Y7xi?= =?us-ascii?Q?bqq3ni7ZdxUgLcQRlJc+B+aF99mdEqKc1qJn3Y3uLc19SylaEi2u3nO/MrGF?= =?us-ascii?Q?OvUPJDWTHvOP7j7QJbuRTPOYSkX1fOK5Q93ZITQsjUHnUYfzqArkJZwsfEbX?= =?us-ascii?Q?5ZLO/Qun5vWfjAhol+1ps1wx7lIChVQWBluBJnUQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5161.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e7cbc49-751d-468d-5be7-08dc29628981 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 11:30:36.9929 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XHFVqJkpmVWye1jnGpykKRysckQpfROB8y+5dQXdbMuEqODjUYgsZoMMs6psC4H9184AfQvKPkKeiUeaT5+fpjLjjwC7HJlczg/Yt9eDJ64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB4494 X-Proofpoint-ORIG-GUID: yq9E26WMKZFwNzNahjbLGvT3b9tlxbtz X-Proofpoint-GUID: yq9E26WMKZFwNzNahjbLGvT3b9tlxbtz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-09_08,2024-02-08_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > > invoke (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id, > > > vchan, event), > > > > > > at cnxk driver, this ops will check whether the DMA is > > > cnxk_dmadev_pci_driver. > > > > > > I think this is because the cnxk's event-and-dma implement has deep > > > coupling > > > > > > (because the cnxk's event device could interact with another > > > vendor's dma device). > > > > > > > > > Maybe we should think of a better way to solve this kind of coupling > > > problem. > > > > Id, is the DMA dev id which is used in looking up DMA dev. This API is = in-line > with the other libraries. > > Crypto library has an api rte_cryptodev_pmd_get_dev to get crypto devic= e > based on device id. >=20 > OK I think I understand. > It is the library ID, the same as returned by int > rte_dma_get_dev_id_by_name(const char *name); >=20 > I can remove the const and apply if you are OK. Sure, I am okay. > I would just change this comment: >=20 > + * @param dev_id > + * Device ID value to select the device structure. >=20 > into >=20 > + * DMA device index in dmadev library. Sure. Thanks.