From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20D1A43CCA; Tue, 19 Mar 2024 19:40:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4E0840297; Tue, 19 Mar 2024 19:40:32 +0100 (CET) Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11023015.outbound.protection.outlook.com [52.101.61.15]) by mails.dpdk.org (Postfix) with ESMTP id F08B740041 for ; Tue, 19 Mar 2024 19:40:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXCDoSaA6Zvs9Pz040hYnTHpTOg/Vb6HKIujn0p5D12ortxHVn3wqWnzGImjIOVkV1Lj/Rq/EXQOcyf25lYBdxyZOEpo0PAJJ/yvsqnfRclOZocNA9bUgXz/Q5Ou735ZYzo+bkmDJf2vhwpOZ8TE4OIY4Sr+DkaQ3ZEdmo2vJVenRmEsj+RkGe7XnetpIszpFh1I7fq3wT+tbCIRxsDuLLik0hQfM0B/RIhSxYcRNVWVFdQWvDKPyu6hq/eBz4dEDLcwkp6ioA4HUeGSmR/vNOo8ymChejHHeaGnq4HV1YmiG/m5IHt5GxcrofPhuwd2M+0yFfRQou3BVZNYR6Q/VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2OTySJvxyFfqMj59zaUB1eKxnQzPZvzuhM/R2X+nPIc=; b=QN2FgbIpzUz3nEACFFn7Qmmcl3Vht6JyAFJxzupDDwDio55z9mdI17atuviqLY387t7aABD8t3Xqye6nGGkEO46Io7YOrRRFheemrvGPQCAwiAAhnUc0Qb4aSOxQ1L4xj0ynLMJZruAMfGPSFUS7Y/73Xgyg3+Jo/2hXpX2113ie3WUvb7zQV+43tVbAZVhrt+C1c5lpOkLK/9np68CXDlzik8r4r4fGWKQSMIh+XE1QUDuVg2aZkZXlkoo9xV+K2kVX/gVHwqCVvviIo7v4a22dYlQPPED5Gj95UGe1SECFm6xA/sSk6QsYIOm9bYhYu+iVaZAvYLTyUbc5U3iU+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2OTySJvxyFfqMj59zaUB1eKxnQzPZvzuhM/R2X+nPIc=; b=KK2GT86CTUFxojOA5RxHCOWzqqL6RTMGqh9fZIA8aEaPMpvV26T2GqwVd77EN4AoUu77Zqkg7Asvi66Ov2Qiayr/h0Nyt8g9EpQmjfyyaRhZlbWRDk1Ah6zSmTxms2LZu551dYAmNz551ocMg10H98Dw6t3tRQkKHOSE1z9q/ww= Received: from SJ1PR21MB3457.namprd21.prod.outlook.com (2603:10b6:a03:453::5) by DM4PR21MB3418.namprd21.prod.outlook.com (2603:10b6:8:a0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.15; Tue, 19 Mar 2024 18:40:28 +0000 Received: from SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7]) by SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7%4]) with mapi id 15.20.7409.010; Tue, 19 Mar 2024 18:40:28 +0000 From: Long Li To: Alan Elder , Ferruh Yigit , Andrew Rybchenko CC: "dev@dpdk.org" , stephen Subject: RE: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues Thread-Topic: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues Thread-Index: AQHaeggXju0JzIG/uUWYfa+s9pOpMrE/ZZ/A Date: Tue, 19 Mar 2024 18:40:28 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=979ac031-206c-4225-b627-540697dac625; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-29T19:11:26Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR21MB3457:EE_|DM4PR21MB3418:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pvkMCnJmO2QNK/6cTZbNUoi1CNpSvkRD+989MOZvIbA8WIx9SPQnrDKOEq8qF8vYl+NuQtHfapen4RWH+YI0gP1pZ7xtUu9+pKlH6REnyIEKp5SdWj/XY/j1bErqsAkgu73qf+smaSHxFGD+CfNV/rKpZlSNyRwXCxgcle1i3KlwFQXgIWwJieQsz1UlJWhy5bowd1Ai3+T0Piy+SoCuEJhIj36WNCzlGPSQkGYypaNPa0zhKvPYNrMn2jUFIbLEpsJXAZaKJwIpvEQ8+VouW9z/ZNmDvS0A2t338dZzuK6BTQZppd3qtRU67d6ESjqwhoGzXzTb8/CdU6tFE4NkWiVtdtQpsxZqDwZwm9MywiBj7d4JObt0BqitUr57WqCr1cYm42XZ6DZl4RjO5iUAGoH5WC3iP38jz+nzBW7PgORQdCVPT+JCLdRsmFWGuidDbnP/PlrPu2V1cAGvy0JWoylLR5S0LXwuWIx/dSqEi9O6PhPXrHizeMvUbEi7aoVnno1w7pZekm07RkWY6e+ydhR3J57BuXQ3tcOry7hh2hik8uHaMrCev7f/kviXttYslobOkBlkQkFH7pIqd9ciQfd/TzYrbtSdvSNEsEnKK3rYUWpSmj0cIgdBF+Zfe1Qcgo0ovBsmk9TG8HX/QTnnV1em+PwlVyJcQiw8G2WQ5mY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ1PR21MB3457.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TW6xr7W+xaUfxhaipP6oOFUJkXHESIVEpUF9k/5c1EMLl9DWBMP94hLcENKg?= =?us-ascii?Q?0MTSFnL+firqMcIWkkkFnKPYztbLGwEUNPWDOrbxhELAyxLiayiM9h7Hiunw?= =?us-ascii?Q?lzAsaIuxRttbWF9oOkxP8hO43AnrAF2I/PpVmKWlh0SNhx5a6YOWn/rY9UxV?= =?us-ascii?Q?4z5ZEc5HBAuQ8vpONXU5UpjU/aNiSgrRxLCU0RY4bkoAFeWRpNs3CVz7brPl?= =?us-ascii?Q?AHK1yVGB1gwKXf24B21WJv7aMfsAYv1e/Yuo+Q0+DahTszeyRx0/unGcyjx2?= =?us-ascii?Q?UST/BawOWugAlTH1Dp3U3fRTpHM8PsG7my645laWGLYV3G/aGDmKUQx8IG4H?= =?us-ascii?Q?vndNYGdxnrlqHUHwhkN7GTnXoLfow2n0IACjNdwIVssdkisoIPTtXimD8XSQ?= =?us-ascii?Q?AX3ZTD9HJXiaTjY2Bj0xe4+6s5kZfPf7dhDgtfBhqckOSMoq1h5ftKUUWcG6?= =?us-ascii?Q?aMH+cdjzQQWA8xkGkqfbgbYUIii8JW9iWIfmFf9WWaaSzMDUcDknXZlYt0tb?= =?us-ascii?Q?c1xBh66oyoOQv4OUvTO+0ZMz8rpejpzzoKCffJ8eeJc11vQGo6VuwM9HPiKw?= =?us-ascii?Q?mPVOfW61lRiMfT/he4N6JY/AyuKwbCvOd2YSLqgFijKjxbAdTxn3nAF9k5xd?= =?us-ascii?Q?PhoujSO9Cn5KYR97JI2tSkuVqZmpIzJQsMrc0o4RtXBlk66+/kBtE6cWcS7x?= =?us-ascii?Q?vVJA4qUHBLJ+QKfs2cAAMUvojLf5ZxTkZAYGK1FojsKG21aOxzNXzVHflerM?= =?us-ascii?Q?bcylT89Uxl14b5uPncAwZC0YsgwfPm7t+q66ILXxEp8Nu9IcSDjIIJtwMLit?= =?us-ascii?Q?61YO5ST1hwFxLdVF7wrcuWtolbkOZD3F+oXXeEwavg2U4GdYEJCh53HzSRKf?= =?us-ascii?Q?rjockWVkuZ/P8VF9ugCGs8czR0THIqXlUnBroj8fUygMrHwsKeETtD602vHZ?= =?us-ascii?Q?15HZZmnOfsk/5lv4Pk9mcB/gyXelJAFVj+LXoCSxCOMRV7xQXy+rmSZcrVrp?= =?us-ascii?Q?EjG4mfzEXJcAa915kwl5kqL8w4t87QBwypZg6qWef4jDRhO5HuADHzSabnMC?= =?us-ascii?Q?vlX4kZs8EprtLEKd+0dWakxlb4+pOCom7lqDRf88SmyhIVw28uM4bL1yUss0?= =?us-ascii?Q?CqyK+HKPX1R3hpYiIV/fRC5iVwKMhK6BoJ0HBvoRElVvJZ3XRIPpPBD7aS4W?= =?us-ascii?Q?BKRqTvgCvpKve3eN5XQZykYN6HEbTl7dfxhiOnIUAhEupcv0jxrJvkcnhZWZ?= =?us-ascii?Q?3EkauUklpht3ZiXquHlJgV+Xm/ha9ZyhxWIw0EAC5aZbg2tWbsGxKWZbT3Sg?= =?us-ascii?Q?EcLj6GlkXQXe3tOG9GWEavz9C7Rk2XtHkyinSOqYh5QNtgAv2LOx0G2jH/mO?= =?us-ascii?Q?RKHoeN/OttAq2g4cIrcSqES6KNAC/T9bs1puZmLqbvsK/MTAp0HRx43HbeUx?= =?us-ascii?Q?8Rwhz5YnZ6H3ZadoWsBR06gAY0ZvUwVD/Ru6aKOYMc9C3zbuz3CSZPkx3qb0?= =?us-ascii?Q?unBg7hrqfiJq/upL/62WCAXRggIqL9/a3xi37QuSNctOEEKVCQarV3MX+fWQ?= =?us-ascii?Q?rGWtoFvmVM+NxPMhgyXBLr7vRDqSX2IyyAt4nRE/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR21MB3457.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0e94886-11c2-4ef6-8ff1-08dc48440c63 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 18:40:28.2036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5sppoZIGRpoWpjSYgt7xViz/BpJ7GvfZbTlerlHwnZc2MchRNtooJ1sjWtAMxz1UaZ3tMZ1rw6DWA9KjU+S+vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR21MB3418 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: [PATCH v3] net/netvsc: fix number Tx queues > Rx queues >=20 > The previous code allowed the number of Tx queues to be set higher than t= he > number of Rx queues. If a packet was sent on a Tx queue with index > >=3D number Rx queues there was a segfault. >=20 > This commit fixes the issue by creating an Rx queue for every Tx queue me= aning > that an event buffer is allocated to handle receiving Tx completion messa= ges. >=20 > mbuf pool and Rx ring are not allocated for these additional Rx queues an= d RSS > configuration ensures that no packets are received on them. >=20 > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: sthemmin@microsoft.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Alan Elder Reviewed-by: Long Li