[PATCH] compressdev: fix coverity issue

[PATCH] compressdev: fix coverity issue

[Sameer Vaze]

Adds missing free before end of function

Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 3a2485b54e..1d7651dd7d 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
 		free(dictionary);
 		return;
 	}
+	free(dictionary);
 }
 
 static void
-- 
2.31.1

Re: [PATCH] compressdev: fix coverity issue

[Sameer Vaze]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

Recheck-request: rebase=main, iol-sample-apps-testing, iol-compile-amd64-testing
________________________________
From: Sameer Vaze <svaze@qti.qualcomm.com>
Sent: Friday, October 24, 2025 12:47 PM
To: Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Sameer Vaze <svaze@qti.qualcomm.com>
Subject: [PATCH] compressdev: fix coverity issue

Adds missing free before end of function

Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 3a2485b54e..1d7651dd7d 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
                 free(dictionary);
                 return;
         }
+       free(dictionary);
 }

 static void
--
2.31.1


[-- Attachment #2: Type: text/html, Size: 2174 bytes --]

Re: [PATCH] compressdev: fix coverity issue

[Sameer Vaze]

[-- Attachment #1: Type: text/plain, Size: 1733 bytes --]


Hey Patrick

I followed https://core.dpdk.org/testing/#requesting-a-patch-retest to request a rebase and recheck since the failures don't seem related to my changes. It doesn't look like the retests were picked up. Did I miss something?

Thanks
Sameer Vaze
________________________________
From: Sameer Vaze <svaze@qti.qualcomm.com>
Sent: Tuesday, October 28, 2025 11:19 AM
To: Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com>
Cc: dev@dpdk.org <dev@dpdk.org>
Subject: Re: [PATCH] compressdev: fix coverity issue


WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

Recheck-request: rebase=main, iol-sample-apps-testing, iol-compile-amd64-testing
________________________________
From: Sameer Vaze <svaze@qti.qualcomm.com>
Sent: Friday, October 24, 2025 12:47 PM
To: Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com>
Cc: dev@dpdk.org <dev@dpdk.org>; Sameer Vaze <svaze@qti.qualcomm.com>
Subject: [PATCH] compressdev: fix coverity issue

Adds missing free before end of function

Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 3a2485b54e..1d7651dd7d 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
                 free(dictionary);
                 return;
         }
+       free(dictionary);
 }

 static void
--
2.31.1


[-- Attachment #2: Type: text/html, Size: 4506 bytes --]

Re: [PATCH] compressdev: fix coverity issue

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 30 bytes --]

Recheck-request: github-robot

[-- Attachment #2: Type: text/html, Size: 53 bytes --]

Re: [PATCH] compressdev: fix coverity issue

[Patrick Robb]

[-- Attachment #1: Type: text/plain, Size: 2345 bytes --]

Hi Sameer,

Thanks for the heads up. It looks like the Github Robot has a failure but I
think it is a spurious false fail, so I just sent a recheck request for
that. I expect that failure will be overwritten with a PASS soon.

There are also 2 warnings on your patch, which I can address, but they will
not preclude your patch from being merged (as they are only a WARN, not a
FAIL).

Thanks.

On Fri, Oct 31, 2025 at 1:10 PM Sameer Vaze <svaze@qti.qualcomm.com> wrote:

>
> Hey Patrick
>
> I followed https://core.dpdk.org/testing/#requesting-a-patch-retest to
> request a rebase and recheck since the failures don't seem related to my
> changes. It doesn't look like the retests were picked up. Did I miss
> something?
>
> Thanks
> Sameer Vaze
> ------------------------------
> *From:* Sameer Vaze <svaze@qti.qualcomm.com>
> *Sent:* Tuesday, October 28, 2025 11:19 AM
> *To:* Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>;
> Ashish Gupta <ashishg@marvell.com>
> *Cc:* dev@dpdk.org <dev@dpdk.org>
> *Subject:* Re: [PATCH] compressdev: fix coverity issue
>
>
> *WARNING:* This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
> Recheck-request: rebase=main, iol-sample-apps-testing,
> iol-compile-amd64-testing
> ------------------------------
> *From:* Sameer Vaze <svaze@qti.qualcomm.com>
> *Sent:* Friday, October 24, 2025 12:47 PM
> *To:* Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>;
> Ashish Gupta <ashishg@marvell.com>
> *Cc:* dev@dpdk.org <dev@dpdk.org>; Sameer Vaze <svaze@qti.qualcomm.com>
> *Subject:* [PATCH] compressdev: fix coverity issue
>
> Adds missing free before end of function
>
> Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
> ---
>  drivers/compress/zlib/zlib_pmd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/compress/zlib/zlib_pmd.c
> b/drivers/compress/zlib/zlib_pmd.c
> index 3a2485b54e..1d7651dd7d 100644
> --- a/drivers/compress/zlib/zlib_pmd.c
> +++ b/drivers/compress/zlib/zlib_pmd.c
> @@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
>                  free(dictionary);
>                  return;
>          }
> +       free(dictionary);
>  }
>
>  static void
> --
> 2.31.1
>
>

[-- Attachment #2: Type: text/html, Size: 5609 bytes --]

[PATCH] compressdev: fix coverity issue

[Sameer Vaze]

Adds missing free before end of function

Coverity issue: 490941
Fixes: 72c6fcc18429 (compressdev: support dictionaries and PDCP
checksum)

Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
---
 drivers/compress/zlib/zlib_pmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 3a2485b54e..1d7651dd7d 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -126,6 +126,7 @@ process_zlib_inflate_chksum(struct rte_comp_op *op,
 		free(dictionary);
 		return;
 	}
+	free(dictionary);
 }
 
 static void
-- 
2.31.1