Re: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files

[Sameer Vaze <svaze@qti.qualcomm.com>]

[-- Attachment #1: Type: text/plain, Size: 3555 bytes --]

I don't see anything specific about creating and pushing a series : 9. Contributing Code to DPDK — Data Plane Development Kit 25.07.0 documentation<https://doc.dpdk.org/guides/contributing/patches.html>.

The only mention to a series above seems to use the depends-on tag.

Thanks
Sameer Vaze
________________________________
From: Akhil Goyal <gakhil@marvell.com>
Sent: Thursday, September 18, 2025 11:08 PM
To: Sameer Vaze <svaze@qti.qualcomm.com>; Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com>
Cc: dev@dpdk.org <dev@dpdk.org>
Subject: RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

Hi Sameer,
> Hey Akhil,
>
> I attempted to split the changes into multiple patches and added a depends-on
> the second patch. But automation does not seem to be picking up the patch as a
> dependency. Is there a process step I messed up:

When you have dependent patches, you should send them as a series.
Automation runs on the last patch in the series only.
Currently it is not handling depends-on tag. It is for reviewers for now.


>
>
> Patch 1: compress/zlib: support for dictionary and PDCP checksum - Patchwork
> <https://patches.dpdk.org/project/dpdk/patch/20250918204411.1701035-1-svaze@qti.qualcomm.com/>
> Patch 2 with depends-n: app/compress-perf: support dictionary files - Patchwork
> <https://patches.dpdk.org/project/dpdk/patch/20250918210806.1709958-1-svaze@qti.qualcomm.com/>
>
> Thanks
> Sameer Vaze
> ________________________________
>
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, June 17, 2025 3:34 PM
> To: Sameer Vaze <svaze@qti.qualcomm.com>; Sunila Sahu
> <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta
> <ashishg@marvell.com>
> Cc: dev@dpdk.org <dev@dpdk.org>
> Subject: RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> > compress/zlib: support PDCP checksum
> >
> > compress/zlib: support zlib dictionary
> >
> > compressdev: add PDCP checksum
> >
> > compressdev: support zlib dictionary
> >
> > Adds support to provide predefined dictionaries to zlib. Handles setting
> > and getting of dictionaries using zlib apis. Also includes support to
> > read dictionary files
> >
> > Adds support for passing in and validationg 3GPP PDCP spec defined
> > checksums as defined under the Uplink Data Compression(UDC) feature.
> > Changes also include functions that do inflate or deflate specific
> > checksum operations.
> >
> > Introduces new members to compression api structures to allow setting
> > predefined dictionaries
> >
> > Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com>
>
> Seems like multiple patches are squashed into a single patch
>
> I see that this patch has ABI breaks.
> We need to defer this patch for next ABI break release.
> Please split the patch appropriately.
> First patch should define the library changes.
> And subsequently logically broken PMD patches
> Followed by application patches.
> Ensure each patch is compilable.
>
> Since this patch is breaking ABI/API,
> Please send a deprecation notice to be merged in this release and
> Implementation for next release.
>
> Also avoid unnecessary and irrelevant code changes.
>


[-- Attachment #2: Type: text/html, Size: 5914 bytes --]