* [dpdk-dev] [PATCH v1 2/3] net/iavf: fix issues with clang 21.1.4
2025-10-28 17:23 [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4 jerinj
@ 2025-10-28 17:23 ` jerinj
2025-10-29 10:01 ` Medvedkin, Vladimir
2025-10-29 13:13 ` David Marchand
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 3/3] app/test: " jerinj
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: jerinj @ 2025-10-28 17:23 UTC (permalink / raw)
To: Vladimir Medvedkin, Yiding Zhou, Qi Zhang
Cc: dev, thomas, bruce.richardson, david.marchand, Jerin Jacob, stable
From: Jerin Jacob <jerinj@marvell.com>
Fix the following error seen with clang 21.1.4
drivers/net/intel/iavf/iavf_vchnl.c:123:38: error: variable
'notify_byte' is uninitialized when passed as a const pointer
argument here [-Werror,-Wuninitialized-const-pointer]
Fixes: cb5c1b91f76f ("net/iavf: add thread for event callbacks")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
drivers/net/intel/iavf/iavf_vchnl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/intel/iavf/iavf_vchnl.c b/drivers/net/intel/iavf/iavf_vchnl.c
index 460035d772..9ad39300c6 100644
--- a/drivers/net/intel/iavf/iavf_vchnl.c
+++ b/drivers/net/intel/iavf/iavf_vchnl.c
@@ -102,7 +102,7 @@ iavf_dev_event_post(struct rte_eth_dev *dev,
void *param, size_t param_alloc_size)
{
struct iavf_event_handler *handler = &event_handler;
- char notify_byte;
+ char notify_byte = 0;
struct iavf_event_element *elem = rte_malloc(NULL, sizeof(*elem) + param_alloc_size, 0);
if (!elem)
return;
--
2.51.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v1 2/3] net/iavf: fix issues with clang 21.1.4
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 2/3] net/iavf: " jerinj
@ 2025-10-29 10:01 ` Medvedkin, Vladimir
2025-10-29 13:13 ` David Marchand
1 sibling, 0 replies; 9+ messages in thread
From: Medvedkin, Vladimir @ 2025-10-29 10:01 UTC (permalink / raw)
To: jerinj, Yiding Zhou, Qi Zhang
Cc: dev, thomas, bruce.richardson, david.marchand, stable
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
On 10/28/2025 5:23 PM, jerinj@marvell.com wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Fix the following error seen with clang 21.1.4
>
> drivers/net/intel/iavf/iavf_vchnl.c:123:38: error: variable
> 'notify_byte' is uninitialized when passed as a const pointer
> argument here [-Werror,-Wuninitialized-const-pointer]
>
> Fixes: cb5c1b91f76f ("net/iavf: add thread for event callbacks")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/net/intel/iavf/iavf_vchnl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/intel/iavf/iavf_vchnl.c b/drivers/net/intel/iavf/iavf_vchnl.c
> index 460035d772..9ad39300c6 100644
> --- a/drivers/net/intel/iavf/iavf_vchnl.c
> +++ b/drivers/net/intel/iavf/iavf_vchnl.c
> @@ -102,7 +102,7 @@ iavf_dev_event_post(struct rte_eth_dev *dev,
> void *param, size_t param_alloc_size)
> {
> struct iavf_event_handler *handler = &event_handler;
> - char notify_byte;
> + char notify_byte = 0;
> struct iavf_event_element *elem = rte_malloc(NULL, sizeof(*elem) + param_alloc_size, 0);
> if (!elem)
> return;
--
Regards,
Vladimir
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v1 2/3] net/iavf: fix issues with clang 21.1.4
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 2/3] net/iavf: " jerinj
2025-10-29 10:01 ` Medvedkin, Vladimir
@ 2025-10-29 13:13 ` David Marchand
1 sibling, 0 replies; 9+ messages in thread
From: David Marchand @ 2025-10-29 13:13 UTC (permalink / raw)
To: jerinj
Cc: Vladimir Medvedkin, Yiding Zhou, Qi Zhang, dev, thomas,
bruce.richardson, stable
On Tue, 28 Oct 2025 at 18:24, <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Fix the following error seen with clang 21.1.4
>
> drivers/net/intel/iavf/iavf_vchnl.c:123:38: error: variable
> 'notify_byte' is uninitialized when passed as a const pointer
> argument here [-Werror,-Wuninitialized-const-pointer]
>
> Fixes: cb5c1b91f76f ("net/iavf: add thread for event callbacks")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Tested on fedora 43.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v1 3/3] app/test: fix issues with clang 21.1.4
2025-10-28 17:23 [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4 jerinj
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 2/3] net/iavf: " jerinj
@ 2025-10-28 17:23 ` jerinj
2025-10-29 5:02 ` Amit Prakash Shukla
2025-10-29 13:19 ` David Marchand
2025-10-29 6:25 ` [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: " Pavan Nikhilesh Bhagavatula
2025-10-29 13:11 ` David Marchand
3 siblings, 2 replies; 9+ messages in thread
From: jerinj @ 2025-10-28 17:23 UTC (permalink / raw)
To: Amit Prakash Shukla, Jerin Jacob, Sunil Kumar Kori,
Ankur Dwivedi, Morten Brørup, Ferruh Yigit
Cc: dev, thomas, bruce.richardson, david.marchand, stable
From: Jerin Jacob <jerinj@marvell.com>
Fix the following errors seen with clang 21.1.4
app/test/test_event_dma_adapter.c:532:32: error: variable 'event' is
uninitialized when passed as a const pointer argument here
[-Werror,-Wuninitialized-const-pointer]
app/test/test_trace.c:201:29: error: variable 'tmp' is uninitialized
when passed as a const pointer argument here
[-Werror,-Wuninitialized-const-pointer]
Fixes: 4925e15a1614 ("trace: add trace point emit for blob")
Fixes: a276e7c8fbb3 ("test/event: add DMA adapter auto-test")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
app/test/test_event_dma_adapter.c | 2 ++
app/test/test_trace.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test/test_event_dma_adapter.c b/app/test/test_event_dma_adapter.c
index 7f72a4e81d..4df5991285 100644
--- a/app/test/test_event_dma_adapter.c
+++ b/app/test/test_event_dma_adapter.c
@@ -144,6 +144,7 @@ test_dma_adapter_params(void)
TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
+ event.queue_id = 0;
err = rte_event_dma_adapter_vchan_add(TEST_ADAPTER_ID, TEST_DMA_DEV_ID,
TEST_DMA_VCHAN_ID, &event);
} else
@@ -528,6 +529,7 @@ test_dma_adapter_vchan_add_del(void)
TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
+ event.queue_id = 0;
ret = rte_event_dma_adapter_vchan_add(TEST_ADAPTER_ID, TEST_DMA_DEV_ID,
TEST_DMA_VCHAN_ID, &event);
} else
diff --git a/app/test/test_trace.c b/app/test/test_trace.c
index 8ea1443044..52b5ba5cbb 100644
--- a/app/test/test_trace.c
+++ b/app/test/test_trace.c
@@ -179,7 +179,7 @@ static int
test_generic_trace_points(void)
{
uint8_t arr[RTE_TRACE_BLOB_LEN_MAX];
- int tmp;
+ int tmp = 0;
int i;
for (i = 0; i < RTE_TRACE_BLOB_LEN_MAX; i++)
--
2.51.2
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [dpdk-dev] [PATCH v1 3/3] app/test: fix issues with clang 21.1.4
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 3/3] app/test: " jerinj
@ 2025-10-29 5:02 ` Amit Prakash Shukla
2025-10-29 13:19 ` David Marchand
1 sibling, 0 replies; 9+ messages in thread
From: Amit Prakash Shukla @ 2025-10-29 5:02 UTC (permalink / raw)
To: Jerin Jacob, Jerin Jacob, Sunil Kumar Kori, Ankur Dwivedi,
Morten Brørup, Ferruh Yigit
Cc: dev, thomas, bruce.richardson, david.marchand, stable
Acked-by: Amit Prakash Shukla <amitprakashs@marvell.com>
Thanks
> -----Original Message-----
> From: jerinj@marvell.com <jerinj@marvell.com>
> Sent: Tuesday, October 28, 2025 10:53 PM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>; Jerin Jacob
> <jerinj@marvell.com>; Sunil Kumar Kori <skori@marvell.com>; Ankur Dwivedi
> <adwivedi@marvell.com>; Morten Brørup <mb@smartsharesystems.com>;
> Ferruh Yigit <ferruh.yigit@amd.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; bruce.richardson@intel.com;
> david.marchand@redhat.com; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 3/3] app/test: fix issues with clang 21.1.4
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Fix the following errors seen with clang 21.1.4
>
> app/test/test_event_dma_adapter.c:532:32: error: variable 'event' is
> uninitialized when passed as a const pointer argument here [-Werror,-
> Wuninitialized-const-pointer]
>
> app/test/test_trace.c:201:29: error: variable 'tmp' is uninitialized when passed
> as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
>
> Fixes: 4925e15a1614 ("trace: add trace point emit for blob")
> Fixes: a276e7c8fbb3 ("test/event: add DMA adapter auto-test")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> app/test/test_event_dma_adapter.c | 2 ++
> app/test/test_trace.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_event_dma_adapter.c
> b/app/test/test_event_dma_adapter.c
> index 7f72a4e81d..4df5991285 100644
> --- a/app/test/test_event_dma_adapter.c
> +++ b/app/test/test_event_dma_adapter.c
> @@ -144,6 +144,7 @@ test_dma_adapter_params(void)
> TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
>
> if (cap &
> RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
> + event.queue_id = 0;
> err = rte_event_dma_adapter_vchan_add(TEST_ADAPTER_ID,
> TEST_DMA_DEV_ID,
>
> TEST_DMA_VCHAN_ID, &event);
> } else
> @@ -528,6 +529,7 @@ test_dma_adapter_vchan_add_del(void)
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> if (cap &
> RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
> + event.queue_id = 0;
> ret = rte_event_dma_adapter_vchan_add(TEST_ADAPTER_ID,
> TEST_DMA_DEV_ID,
>
> TEST_DMA_VCHAN_ID, &event);
> } else
> diff --git a/app/test/test_trace.c b/app/test/test_trace.c index
> 8ea1443044..52b5ba5cbb 100644
> --- a/app/test/test_trace.c
> +++ b/app/test/test_trace.c
> @@ -179,7 +179,7 @@ static int
> test_generic_trace_points(void)
> {
> uint8_t arr[RTE_TRACE_BLOB_LEN_MAX];
> - int tmp;
> + int tmp = 0;
> int i;
>
> for (i = 0; i < RTE_TRACE_BLOB_LEN_MAX; i++)
> --
> 2.51.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v1 3/3] app/test: fix issues with clang 21.1.4
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 3/3] app/test: " jerinj
2025-10-29 5:02 ` Amit Prakash Shukla
@ 2025-10-29 13:19 ` David Marchand
1 sibling, 0 replies; 9+ messages in thread
From: David Marchand @ 2025-10-29 13:19 UTC (permalink / raw)
To: jerinj
Cc: Amit Prakash Shukla, Sunil Kumar Kori, Ankur Dwivedi,
Morten Brørup, Ferruh Yigit, dev, thomas, bruce.richardson,
stable
On Tue, 28 Oct 2025 at 18:25, <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Fix the following errors seen with clang 21.1.4
>
> app/test/test_event_dma_adapter.c:532:32: error: variable 'event' is
> uninitialized when passed as a const pointer argument here
> [-Werror,-Wuninitialized-const-pointer]
>
> app/test/test_trace.c:201:29: error: variable 'tmp' is uninitialized
> when passed as a const pointer argument here
> [-Werror,-Wuninitialized-const-pointer]
>
> Fixes: 4925e15a1614 ("trace: add trace point emit for blob")
I don't think this Fixes: tag is the right one.
Instead, I would point at 9247e71dfb55 ("test/trace: add functional
test cases").
> Fixes: a276e7c8fbb3 ("test/event: add DMA adapter auto-test")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> app/test/test_event_dma_adapter.c | 2 ++
> app/test/test_trace.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/app/test/test_event_dma_adapter.c b/app/test/test_event_dma_adapter.c
> index 7f72a4e81d..4df5991285 100644
> --- a/app/test/test_event_dma_adapter.c
> +++ b/app/test/test_event_dma_adapter.c
> @@ -144,6 +144,7 @@ test_dma_adapter_params(void)
> TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
>
> if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
> + event.queue_id = 0;
> err = rte_event_dma_adapter_vchan_add(TEST_ADAPTER_ID, TEST_DMA_DEV_ID,
> TEST_DMA_VCHAN_ID, &event);
> } else
> @@ -528,6 +529,7 @@ test_dma_adapter_vchan_add_del(void)
> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
>
> if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
> + event.queue_id = 0;
> ret = rte_event_dma_adapter_vchan_add(TEST_ADAPTER_ID, TEST_DMA_DEV_ID,
> TEST_DMA_VCHAN_ID, &event);
> } else
Same comment than for the eventdev test app, I would move those event
variable declaration in the block where only needed.
Otherwise, this lgtm and was tested on Fedora 43.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4
2025-10-28 17:23 [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4 jerinj
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 2/3] net/iavf: " jerinj
2025-10-28 17:23 ` [dpdk-dev] [PATCH v1 3/3] app/test: " jerinj
@ 2025-10-29 6:25 ` Pavan Nikhilesh Bhagavatula
2025-10-29 13:11 ` David Marchand
3 siblings, 0 replies; 9+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2025-10-29 6:25 UTC (permalink / raw)
To: Jerin Jacob, Amit Prakash Shukla
Cc: dev, thomas, bruce.richardson, david.marchand, stable
>Fix the following error seen with clang 21.1.4
>
>app/test-eventdev/test_perf_common.c:1340:30: error: variable
>'event' is uninitialized when passed as a const pointer argument
>here [-Werror,-Wuninitialized-const-pointer]
>
>Fixes: b25a66c49e8d ("app/eventdev: add DMA adapter performance test")
>Cc: stable@dpdk.org
>
>Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
> app/test-eventdev/test_perf_common.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
>index 2ad451e457..2bbc17ae96 100644
>--- a/app/test-eventdev/test_perf_common.c
>+++ b/app/test-eventdev/test_perf_common.c
>@@ -1335,13 +1335,14 @@ perf_event_dma_adapter_setup(struct test_perf *t, struct prod_data *p)
> return -ENOTSUP;
> }
>
>- if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND)
>+ if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
>+ event.queue_id = p->queue_id;
> ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
> p->da.vchan_id, &event);
>- else
>+ } else {
> ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
> p->da.vchan_id, NULL);
>-
>+ }
> return ret;
> }
>
>--
>2.51.2
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4
2025-10-28 17:23 [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: fix issues with clang 21.1.4 jerinj
` (2 preceding siblings ...)
2025-10-29 6:25 ` [dpdk-dev] [PATCH v1 1/3] app/test-eventdev: " Pavan Nikhilesh Bhagavatula
@ 2025-10-29 13:11 ` David Marchand
3 siblings, 0 replies; 9+ messages in thread
From: David Marchand @ 2025-10-29 13:11 UTC (permalink / raw)
To: jerinj
Cc: Amit Prakash Shukla, Pavan Nikhilesh, dev, thomas,
bruce.richardson, stable
On Tue, 28 Oct 2025 at 18:24, <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Fix the following error seen with clang 21.1.4
>
> app/test-eventdev/test_perf_common.c:1340:30: error: variable
> 'event' is uninitialized when passed as a const pointer argument
> here [-Werror,-Wuninitialized-const-pointer]
>
> Fixes: b25a66c49e8d ("app/eventdev: add DMA adapter performance test")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> app/test-eventdev/test_perf_common.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
> index 2ad451e457..2bbc17ae96 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -1335,13 +1335,14 @@ perf_event_dma_adapter_setup(struct test_perf *t, struct prod_data *p)
> return -ENOTSUP;
> }
>
> - if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND)
> + if (cap & RTE_EVENT_DMA_ADAPTER_CAP_INTERNAL_PORT_VCHAN_EV_BIND) {
struct rte_event event declaration can be moved in this block.
> + event.queue_id = p->queue_id;
> ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
> p->da.vchan_id, &event);
> - else
> + } else {
> ret = rte_event_dma_adapter_vchan_add(TEST_PERF_DA_ID, p->da.dma_dev_id,
> p->da.vchan_id, NULL);
> -
> + }
> return ret;
> }
Otherwise, this lgtm.
I tested with Fedora 43.
--
David Marchand
^ permalink raw reply [flat|nested] 9+ messages in thread