From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH] net/qede: move SPDX tags to source files
Date: Tue, 10 Jul 2018 15:56:47 +0000 [thread overview]
Message-ID: <SN1PR07MB403240FEDD8B7B252D0827D49F5B0@SN1PR07MB4032.namprd07.prod.outlook.com> (raw)
In-Reply-To: <AM2PR04MB075360EA9A711319FE458A7B89440@AM2PR04MB0753.eurprd04.prod.outlook.com>
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Sunday, July 08, 2018 11:40 PM
>
> Hi Rasesh,
> There is a problem with these patches.
>
> The SPDX shall be first line for *.c, *.h and Makefiles. It shall come before the
> copyright statements.
I will send a v2 with the change.
Thanks!
-Rasesh
> Regards,
> Hemant
>
>
> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index
> c30a867..45ad579 100644
> --- a/drivers/net/qede/Makefile
> +++ b/drivers/net/qede/Makefile
> @@ -2,7 +2,7 @@
> # All rights reserved.
> #
> https://emea01.safelinks.protection.outlook.com/?url=www.cavium.com&a
> mp;data=02%7C01%7Chemant.agrawal%40nxp.com%7Cb12b0f85086b488ee
> 3f308d5e4939352%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636
> 666244855549507&sdata=hfihj1buvAcoQTc3O3KXp%2FmorsaAWzB1PM
> tOGiIVYJo%3D&reserved=0
> #
> -# See LICENSE.qede_pmd for copyright and licensing details.
> +# SPDX-License-Identifier: BSD-3-Clause
next prev parent reply other threads:[~2018-07-10 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 5:27 Rasesh Mody
2018-07-09 6:39 ` Hemant Agrawal
2018-07-10 15:56 ` Mody, Rasesh [this message]
2018-07-14 1:34 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
2018-07-16 6:26 ` Hemant
2018-07-18 10:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN1PR07MB403240FEDD8B7B252D0827D49F5B0@SN1PR07MB4032.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).