From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0115.outbound.protection.outlook.com [207.46.100.115]) by dpdk.org (Postfix) with ESMTP id C11019AB7 for ; Tue, 7 Jun 2016 20:26:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qlgc.onmicrosoft.com; s=selector1-qlogic-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pg74437yrI9y1mzjsEud7jIeH2jw/gM3pbGiBTdkaZE=; b=kgC/CWpabrK6d4iM3dLVcsQyShNnfJnF31t4Q97941vbfg2uejhhryYP8yZKkTm/iAG85IZKq2AOL9uj5e/FDJlvJwXsgP82bd1MjjEidDRJ2zUNrCQuO2W8Falm+27Vj5WReRXQnNm9e2DfNYCHHsDGqQmBxh2tz7ONwAg81ic= Received: from SN1PR11MB0943.namprd11.prod.outlook.com (10.164.25.145) by SN1PR11MB0944.namprd11.prod.outlook.com (10.164.25.146) with Microsoft SMTP Server (TLS) id 15.1.511.8; Tue, 7 Jun 2016 18:26:03 +0000 Received: from SN1PR11MB0943.namprd11.prod.outlook.com ([10.164.25.145]) by SN1PR11MB0943.namprd11.prod.outlook.com ([10.164.25.145]) with mapi id 15.01.0511.010; Tue, 7 Jun 2016 18:26:02 +0000 From: Rasesh Mody To: Bruce Richardson CC: "dev@dpdk.org" , Dept-Eng DPDK Dev Thread-Topic: [PATCH 0/9] qede: update qede PMD to 1.1.0.1 Thread-Index: AQHRqBkuBhYNG8/k0UmgRy13nduPa5/FynCAgBhaxACAAF4ScA== Date: Tue, 7 Jun 2016 18:26:02 +0000 Message-ID: References: <1462595421-22505-1-git-send-email-rasesh.mody@qlogic.com> <20160607124708.GB6948@bricha3-MOBL3> In-Reply-To: <20160607124708.GB6948@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasesh.mody@qlogic.com; x-originating-ip: [2601:646:9480:ddf0:88ec:9439:46b3:4782] x-ms-office365-filtering-correlation-id: 7e4d8b4f-186f-459e-a0b4-08d38f012e70 x-microsoft-exchange-diagnostics: 1; SN1PR11MB0944; 5:d3AEEFzF3aU0zNI96NsNcxjQKtG0m9Viy/ZO4WooPVXjCDtTAw3H0rWEet3TqbKnzIPDNOuoPJReVjGqr/RqObhn4WBtj4gelELEihmw6xKGGl2lKsyvAPbeG8cMviBTqbldo5l5eQCqbJvCbHJGUA==; 24:iEFZ/6vRf2dQGYfvDLHAGiH6zAkmB2QXdA/4JSh0k9yQvl26PcYdxkxcXQ2M/MdSCtV2QbDEd1fJmnOBFsrJ68FCrdxOEsFfS+e00NI28Ec=; 7:orRnwh6uR+9sOhXs6HCR/9mFEpWD665NGzLwJFkf6/gRa6bBUHabO5C5lT7RkwOHvGKygyASeFay/9T41o73ODL2k/Nh81X/Iao9ggqXE6MpWLLxEkAFso1jTH9I7fyn31kpOR7OTiPGW8OLA9N9+OztOI0BFw86eNp0cyaxj+1zqyybHjBatJ2KagQF2/bLMb53jpKaY3dyNH+LiyMevrg+pGzFF5wo9nhqBJoQ2cI=; 20:Z6ykThVkciGaYrrxx7Fjm8NN28gCgRNncHoi1PHpiHGreY/yDwmVzmipjYNup7s/2kkO+oqCsgTsRNioAtn1tV6sFn32nsH3+aAyvkdVpFANx8ZhBwVpCcTPvSjH/4ZXMTvQymYnXniNXjo2SG1Tv0pj/5sktjMGCrT0E9TP6M8= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR11MB0944; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:SN1PR11MB0944; BCL:0; PCL:0; RULEID:; SRVR:SN1PR11MB0944; x-forefront-prvs: 09669DB681 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(199003)(43544003)(24454002)(189002)(377454003)(81156014)(74316001)(8676002)(81166006)(122556002)(5003600100002)(92566002)(2950100001)(105586002)(106356001)(77096005)(102836003)(2900100001)(3280700002)(586003)(10400500002)(4326007)(99286002)(5002640100001)(6116002)(87936001)(5004730100002)(106116001)(97736004)(4001430100002)(107886002)(5008740100001)(86362001)(2906002)(15650500001)(76576001)(8936002)(19580395003)(68736007)(189998001)(54356999)(101416001)(19580405001)(50986999)(76176999)(3660700001)(33656002)(9686002)(110136002)(3826002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN1PR11MB0944; H:SN1PR11MB0943.namprd11.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: qlogic.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2016 18:26:02.2650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR11MB0944 Subject: Re: [dpdk-dev] [PATCH 0/9] qede: update qede PMD to 1.1.0.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2016 18:26:28 -0000 > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Tuesday, June 07, 2016 5:47 AM > To: Rasesh Mody > Cc: dev@dpdk.org; Dept-Eng DPDK Dev > Subject: Re: [PATCH 0/9] qede: update qede PMD to 1.1.0.1 >=20 > On Mon, May 23, 2016 at 12:56:50AM +0000, Rasesh Mody wrote: > > Hi Bruce, > > > > > From: Rasesh Mody [mailto:rasesh.mody@qlogic.com] > > > Sent: Friday, May 06, 2016 9:30 PM > > > > > > This patch set adds support for enabling 100G mode for QEDE PMD. > > > It also adds support for APIs like > > > - mtu_set > > > - reta_update > > > - reta_query > > > - rss_hash_update > > > - rss_hash_conf_get > > > - xstats_get > > > The changes include enablement of vf-vf traffic and updated the > > > driver version to 8.7.9.0_1.1.0.1 > > > > > > The patches have been generated and tested against dpdk-next-net > > > rel_16_07 branch. > > > > > > Please apply! > > > > > > Harish Patil (2): > > > qede: add 100g mode support > > > qede: update version to 8.7.9.0_1.1.0.1 > > > > > > Rasesh Mody (1): > > > qede: add support for xstats > > > > > > Sony Chacko (6): > > > qede: update hash config > > > qede: get hash configuration > > > qede: rss redirection table update > > > qede: rss redirection table query > > > qede: set mtu > > > qede: enable vf-vf traffic with unmatched dest addr > > > > > > config/common_base | 2 +- > > > doc/guides/nics/overview.rst | 6 +- > > > doc/guides/nics/qede.rst | 11 +- > > > drivers/net/qede/base/ecore_l2.c | 19 +- > > > drivers/net/qede/qede_eth_if.c | 45 +++-- > > > drivers/net/qede/qede_eth_if.h | 1 + > > > drivers/net/qede/qede_ethdev.c | 390 > > > +++++++++++++++++++++++++++++++++++++- > > > drivers/net/qede/qede_ethdev.h | 10 +- > > > drivers/net/qede/qede_rxtx.c | 42 ++-- > > > 9 files changed, 466 insertions(+), 60 deletions(-) > > > > > > -- > > > 1.7.10.3 > > > > Did you get a chance to review these patches for QEDE PMD? > > > > Thanks! > > Rasesh >=20 > Hi, >=20 > a couple of comments I've put in reply to individual patches, and please = also > take into account Harry's comments on the stats patch. Otherwise things l= ook > pretty ok. >=20 > A general comment that applied to a number of patches is to ensure that t= he > titles start with the appropriate verb to describe what the patch is doin= g. > For example, the patch: >=20 > qede: set mtu >=20 > is not actually setting the MTU on the nic, but is adding support for set= ting > the mtu on the NIC, so should be: >=20 > qede: add support for setting the MTU. >=20 > Please take this into account when doing a V2. We'll take care of the above. Thanks! Rasesh