From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680070.outbound.protection.outlook.com [40.107.68.70]) by dpdk.org (Postfix) with ESMTP id BA5821E2F for ; Mon, 29 Oct 2018 05:48:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8teAaDX2e5bKtdoEy/ezJ3i60UwxWQ973it6bB0nNo0=; b=Z6iNqtEjuyLuWr4/V3F6KFoTr+WVQbn7J6jVgW2zLbSYcOci/6yajlFyMnPAe5hBjGX3QfusRUEX/1TwzQx1L+AUh7LmadTHsp1fuPlSMmHUCmuY0PLTdyldfZiJY4JGS52VxLPduKyJEG+R+X7w6k+EkhUjtPzUxK2JhzEgWIQ= Received: from SN6PR07MB4911.namprd07.prod.outlook.com (52.135.77.157) by SN6PR07MB5437.namprd07.prod.outlook.com (52.135.119.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.18; Mon, 29 Oct 2018 04:48:23 +0000 Received: from SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4]) by SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4%3]) with mapi id 15.20.1273.027; Mon, 29 Oct 2018 04:48:22 +0000 From: "Joseph, Anoob" To: Thomas Monjalon CC: "dev@dpdk.org" , Ferruh Yigit , Bruce Richardson , Pablo de Lara , "Jacob, Jerin" , "Athreya, Narayana Prasad" Thread-Topic: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues Thread-Index: AQHUXvOUdisyH6cdS0uPZgANoK7IgKUVLmaAgABkNwD//7ZMAIAgVLeAgAAnZSA= Date: Mon, 29 Oct 2018 04:48:22 +0000 Message-ID: References: <1538995285-2040-1-git-send-email-anoob.joseph@caviumnetworks.com> <98620a3a-2968-be0b-4690-ee4d6dad1101@caviumnetworks.com> <789e1a1a-aa7b-8aa0-41b9-ce188eeccc6b@intel.com> <2612293.rcIgIV396C@xps> In-Reply-To: <2612293.rcIgIV396C@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB5437; 6:Aqr+nqaR99PBhIY6GdyA6ou1shO7UedtKRW81cZTXWvlNG7rcG34hOX65ecP+E/0RFvp7rG2gnJ+jlPKee3iHCQFApMt4DjG3K13JoK5t44N7hTGleimzoBi6F6DTKyyIL+mDOaPM7/BMicYCRQMKSHnjaxwFXArpzY1xPmXgFw0SwkSQTbY0DClMmc7MAtugdN4Bt84VyvWpHvmOgrBrTgejGBuzBreY1Kfw/SkeMfPXOvIyBwfFNBChb1Cq3o5pNb7TC81wWfmmKyxom6Qo3Qeu5uRt8HmzTu1Z7/y702PWZi71FrvQoYndSdPibYsYF0J2lyg3CUl27YrWDdhqMznIYtgyTrfmzu7z+IsEeZprVyfIzBQWU1F97JzXsTHLHXcnPrBM3DtUaSNDAVeHljtavLq4RJpjt8xOD8Zddabs/JZp/xY9MjVVIqIk8jHBcvtrZWJukfN+ARP3Dq2Og==; 5:T14/R8bc2W9lAXKCYRIVdtSQoO/REx8VX9B2QEPnzd/6OLfITC9BtTm9kMthf5rmg5+7BWcB3P8YCupWEC6e+tTQbynF9eoLVF7kDAEFlhxoB37qmyjaMerjONa5EiNmY+4Qis4uK0L7fyyoNWTXfOQD04WArXapyPbZE19Es0E=; 7:m8fjnLvz1sZcSbIqJku3gsB9iENa1PCz+PtoAPyEv60IRb16sf/9ZPf4QjrhMbi1WHA0DuR/0DUMb/lXjkbfHXsqyIxXI9G3IVwEQyrpI3ildC1FYWIi+lU8L6y9xLT0k+XbGUmxwOlYjBvdrIWV3w== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(396003)(136003)(376002)(13464003)(199004)(189003)(52314003)(186003)(8936002)(486006)(305945005)(4326008)(81156014)(81166006)(5660300001)(102836004)(14454004)(2900100001)(55236004)(229853002)(68736007)(25786009)(966005)(72206003)(33656002)(476003)(256004)(14444005)(478600001)(11346002)(7736002)(6916009)(8676002)(446003)(86362001)(53936002)(105586002)(55016002)(9686003)(6246003)(107886003)(6306002)(106356001)(97736004)(6436002)(26005)(66066001)(7696005)(93886005)(53546011)(6116002)(74316002)(76176011)(6506007)(316002)(71200400001)(3846002)(71190400001)(5250100002)(54906003)(2906002)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5437; H:SN6PR07MB4911.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 044438d8-7fdd-4f5e-8c75-08d63d59c1a4 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5437; x-ms-traffictypediagnostic: SN6PR07MB5437: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(788757137089)(131327999870524)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231382)(944501410)(52105095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB5437; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5437; x-forefront-prvs: 084080FC15 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8T2Owb0K7IzXbKxJBcJiBNwQZaZPRCCaUdlbnI+jGSo+QWksIZm79sltXKenKlknKXj+oVZqy3MDbYhwuKENxDLxqAcjt2xmRZw4hfDDmYcuwAZY5MhcJdf3+GhCuIEOQqqxjh5Yx+l9q7Du6Injw1ZAs5QZ/0OUGL3plNlqQ/vOz3I5hlm1RbN98fVUHf8z02rpj+/W3GSSgO+YvSX8j91XrOOh5kPu540egjIvB9puEPtPDIMHMz6bomx+dV+Wnc8Y4qUS3COA6qwxEhmVONVAek+oZhUJZshGyYxdO627HdAE/E+mQaQ1Z9CRFkvl2LgJj6KIX8PeARZhe894ZIedoTaxLsUh6Nt+iFguGTg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 044438d8-7fdd-4f5e-8c75-08d63d59c1a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 04:48:22.8102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5437 Subject: Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch reported issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 04:48:26 -0000 Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: 29 October 2018 07:49 > To: Joseph, Anoob > Cc: dev@dpdk.org; Ferruh Yigit ; Bruce Richardson > ; Pablo de Lara > ; Jacob, Jerin > ; Athreya, Narayana Prasad > > Subject: Re: [dpdk-dev] [PATCH 0/8] examples/l2fwd: fix checkpatch report= ed > issues >=20 > External Email >=20 > 08/10/2018 14:35, Ferruh Yigit: > > On 10/8/2018 12:29 PM, Joseph, Anoob wrote: > > > On 08-10-2018 16:30, Ferruh Yigit wrote: > > >> On 10/8/2018 11:41 AM, Anoob Joseph wrote: > > >>> This patchset fixes multiple issues reported by checkpatch in > > >>> l2fwd code base. These issues would be flagged for any new copy of > > >>> the file and hence, fixing at the source. > > >>> > > >>> Anoob Joseph (8): > > >>> examples/l2fwd: remove quoted white space before newline > > >>> examples/l2fwd: need space between two args > > >>> examples/l2fwd: else should follow close brace > > >>> examples/l2fwd: replace bare usage of 'unsigned' > > >>> examples/l2fwd: follow convention for block comments > > >>> examples/l2fwd: limit line to 80 char > > >>> examples/l2fwd: space required between elements > > >>> examples/l2fwd: remove null initialisation > > >> Hi Anoob, > > >> > > >> I am not sure if it is good idea to get syntax only fixes, I would > > >> prefer to get syntax fixes when some other code touches that area. > > > I'm preparing a new copy of l2fwd with support for eventmode(as > > > suggested in, > > > https://mails.dpdk.org/archives/dev/2018-August/109717.html). All > > > these issues were flagged when I did the copy. What would be the > > > better approach in that case? Fix it in just the new application or > > > fix the source? Fixing in just the new app would mean, the two > > > versions will have a diff at the time of copy. > > > > I see, make sense to not create syntax diff copied and original > > versions, I missed the new copy part. So OK for this patch. >=20 > It was said that there will be not so much common code. > So why bothering to reformat the original example? There will be common code. In fact most of the code could actually be share= d. But we are creating a copy and starting from there because Bruce didn't = want any changes in the existing app. > Anyway, if such cleanup is worth before duplicating, please insert it in = the same > patchset as the new example. These fixes will be there in the new app. I'll add this in the patchset whe= n I share the new app. Thanks, Anoob