From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730051.outbound.protection.outlook.com [40.107.73.51]) by dpdk.org (Postfix) with ESMTP id E840C4F91 for ; Wed, 14 Nov 2018 10:39:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmDxqw1tFACyFJjQHEtlDLTGjKv8LUq2yk7NrYJl/3A=; b=fxNloYK6V+DFd2Y72KI8yD1WfDt/Ony+H98VV5mvcvgoNqcThDtq33OsAykfecsHhuWL6c2xhC5UMFedDuyJKd2B4nEjLjG5vKaVywV5EdyGX4dQvZy0dlAm59+HUiCGj4RlM7DWOoZ/u512TPYW3eRXKtKaFwkLhHo9nskLyU4= Received: from SN6PR07MB4911.namprd07.prod.outlook.com (52.135.77.157) by SN6PR07MB5021.namprd07.prod.outlook.com (52.135.121.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.20; Wed, 14 Nov 2018 09:39:14 +0000 Received: from SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4]) by SN6PR07MB4911.namprd07.prod.outlook.com ([fe80::cd76:e8cc:c0:ebf4%3]) with mapi id 15.20.1294.045; Wed, 14 Nov 2018 09:39:13 +0000 From: "Joseph, Anoob" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "konstantin.ananyev@intel.com" , "Jacob, Jerin" , "radu.nicolau@intel.com" , "declan.doherty@intel.com" , Hemant Agrawal Thread-Topic: [PATCH] security: remove experimental tag Thread-Index: AQHUe0P7pW07ouSgyEm8Cur4KLVhCKVPBS4g Date: Wed, 14 Nov 2018 09:39:13 +0000 Message-ID: References: <20181113112255.20050-1-akhil.goyal@nxp.com> In-Reply-To: <20181113112255.20050-1-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB5021; 6:25fdngOsOnWzBE42uu3/7RVldnKyAxmOKy3QlpeAhlzlpM0Mg5XiNHU4GBXxvpEtOicfq6ALYlk5znZDz1F/C/rj5DQCmAsCb5ufoZjMan5TH19rfAL/futb44L1D7hyhfrbavyu3w6y0yZYF/7f3mmuba1CE9JN46fn/VSrp0DTJejxCAStm80UV2bghUXJEXy2w1L8TnhsnpTYofuUE5OZ5kydUx5gm3VJe8ysbfhwUYrcFp3ZSTnXmoi7cAbAR57Q/d3tLa4YqVFDLlE+mT/Vue3GJIQAVfamCGyOb7csHOgsEZbO56jc1cuZ4zxH4vidtmVVvV51Ne9ddiVaeO7X3nqwnLaSi86w/gSaxYKzsUgqD7EPe3xAZgQd4ypLVzCekIS9EJ3GbCHmCk7A2TvkYIIk4Wb+Xe2kXGrpszw7UFD0JB2ERDzrfCAy44fcDlUSUF1bMJwKR+SUfRypaw==; 5:lRgFlbtqaO0uBjb6ZFBJlpjAV70kdfQ2pOQd3AsT9N6ZUEmyRc5ITPRkUIKQQaV0tt5Ta/avvQnT5OZWB0lG6SVzlS4FiJNt8d/si/RflL1L08rrHGI0UyZ++QTGH3fFQTPX8I8l2YKVFbCgIRcUWfizPdQL/3roChQOnTFaLk0=; 7:gBTiiQwjqEFLmrpkphkhhAXBbsw+5CDxqdsZBX7JZpR3w8PNL7MFmyBQXR3dwHWu4EWYBGLK+SgVigxu0zzkdSnGchHlWNtnxwPEQIqCmp+1rDIRrHR9YP+9VEh8NFTnhbg/7dP743ZRvQ7FXrtfvw== x-ms-office365-filtering-correlation-id: cd72d3e7-de61-426d-892a-08d64a1509de x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5021; x-ms-traffictypediagnostic: SN6PR07MB5021: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(3231410)(944501410)(52105112)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB5021; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5021; x-forefront-prvs: 085634EFF4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(376002)(346002)(366004)(13464003)(189003)(199004)(55016002)(14454004)(4326008)(2906002)(55236004)(15650500001)(102836004)(26005)(72206003)(2501003)(229853002)(6116002)(9686003)(186003)(3846002)(54906003)(110136005)(6436002)(5660300001)(33656002)(14444005)(316002)(5024004)(256004)(53546011)(99286004)(105586002)(7736002)(71200400001)(71190400001)(8936002)(305945005)(106356001)(4744004)(11346002)(53936002)(446003)(25786009)(2900100001)(66066001)(8676002)(486006)(74316002)(68736007)(476003)(6506007)(81166006)(81156014)(478600001)(97736004)(6246003)(7696005)(42882007)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5021; H:SN6PR07MB4911.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: AmpLT3gY9UCHSWGZxjqUK33j3O3zEOI7rY8ztR53QcjSJpwXkmvhd4D6LRVM+vyjG0tp7jRO5FQSfGpy/2M5gCCT6uf5csUIh7vCgrtSw0uL4WbL2yizpsyIG6AWDSRjbbW5MOAPdI7Ya0jgCdL8C9T0qs9q3ifwXo+I7DYpicgW53JJ9fTQPMvvk5gDmboDg6ykfBhe+dCby/5QVN6pCIWq5YGU9clcHNw/EUh2U3lTxYdbK8Kzxx8IV2tnyqaPzIeYs7iqu8rpMFnGnckhwP6Y8sqva5pzDpH1tQM+5v0wKPXxw4zDFytfA1XFajujMXDZHPB+Ttt3ps492ej/uNfcdfZi0qxqsqWmPUEBGwI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd72d3e7-de61-426d-892a-08d64a1509de X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2018 09:39:13.8780 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5021 Subject: Re: [dpdk-dev] [PATCH] security: remove experimental tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 09:39:16 -0000 Acked-by: Anoob Joseph > -----Original Message----- > From: Akhil Goyal > Sent: 13 November 2018 16:58 > To: dev@dpdk.org > Cc: thomas@monjalon.net; konstantin.ananyev@intel.com; Jacob, Jerin > ; Joseph, Anoob > ; radu.nicolau@intel.com; > declan.doherty@intel.com; Hemant Agrawal ; > Akhil Goyal > Subject: [PATCH] security: remove experimental tag >=20 > External Email >=20 > rte_security has been experimental since DPDK 17.11 release. > Now the library has matured and expermental tag is removed in this patch. >=20 > Signed-off-by: Akhil Goyal > --- > MAINTAINERS | 2 +- > lib/librte_security/Makefile | 1 - > lib/librte_security/meson.build | 1 - > lib/librte_security/rte_security.c | 18 +++++++++--------- > lib/librte_security/rte_security.h | 27 +++++++++++++---------= ----- > lib/librte_security/rte_security_driver.h | 1 - > lib/librte_security/rte_security_version.map | 2 +- > 7 files changed, 24 insertions(+), 28 deletions(-) >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 19353ac..bdd6747 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -347,7 +347,7 @@ F: lib/librte_cryptodev/ > F: test/test/test_cryptodev* > F: examples/l2fwd-crypto/ >=20 > -Security API - EXPERIMENTAL > +Security API > M: Akhil Goyal > M: Declan Doherty > T: git://dpdk.org/next/dpdk-next-crypto > diff --git a/lib/librte_security/Makefile b/lib/librte_security/Makefile = index > 8daebea..bd92343 100644 > --- a/lib/librte_security/Makefile > +++ b/lib/librte_security/Makefile > @@ -10,7 +10,6 @@ LIB =3D librte_security.a LIBABIVER :=3D 1 >=20 > # build flags > -CFLAGS +=3D -DALLOW_EXPERIMENTAL_API > CFLAGS +=3D -O3 > CFLAGS +=3D $(WERROR_FLAGS) > LDLIBS +=3D -lrte_eal -lrte_mempool > diff --git a/lib/librte_security/meson.build b/lib/librte_security/meson.= build > index 4c85894..532953f 100644 > --- a/lib/librte_security/meson.build > +++ b/lib/librte_security/meson.build > @@ -1,7 +1,6 @@ > # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corpo= ration >=20 > -allow_experimental_apis =3D true > sources =3D files('rte_security.c') > headers =3D files('rte_security.h', 'rte_security_driver.h') deps +=3D = ['mempool', > 'cryptodev'] diff --git a/lib/librte_security/rte_security.c > b/lib/librte_security/rte_security.c > index c6355de..bc81ce1 100644 > --- a/lib/librte_security/rte_security.c > +++ b/lib/librte_security/rte_security.c > @@ -10,7 +10,7 @@ > #include "rte_security_driver.h" >=20 > struct rte_security_session * > -__rte_experimental rte_security_session_create(struct rte_security_ctx > *instance, > +rte_security_session_create(struct rte_security_ctx *instance, > struct rte_security_session_conf *conf, > struct rte_mempool *mp) { @@ -33,7 +33,7 @@ > __rte_experimental rte_security_session_create(struct rte_security_ctx > *instance > return sess; > } >=20 > -int __rte_experimental > +int > rte_security_session_update(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_session_conf *conf) @@ -4= 2,14 +42,14 @@ > rte_security_session_update(struct rte_security_ctx *instance, > return instance->ops->session_update(instance->device, sess, conf= ); } >=20 > -unsigned int __rte_experimental > +unsigned int > rte_security_session_get_size(struct rte_security_ctx *instance) { > RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_get_size, 0); > return instance->ops->session_get_size(instance->device); > } >=20 > -int __rte_experimental > +int > rte_security_session_stats_get(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_stats *stats) @@ -58,7= +58,7 @@ > rte_security_session_stats_get(struct rte_security_ctx *instance, > return instance->ops->session_stats_get(instance->device, sess, s= tats); } >=20 > -int __rte_experimental > +int > rte_security_session_destroy(struct rte_security_ctx *instance, > struct rte_security_session *sess) { @@ -76= ,7 +76,7 @@ > rte_security_session_destroy(struct rte_security_ctx *instance, > return ret; > } >=20 > -int __rte_experimental > +int > rte_security_set_pkt_metadata(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_mbuf *m, void *params) @@ -86,7 = +86,7 @@ > rte_security_set_pkt_metadata(struct rte_security_ctx *instance, > sess, m, params); } >=20 > -void * __rte_experimental > +void * > rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md= ) { > void *userdata =3D NULL; > @@ -98,14 +98,14 @@ rte_security_get_userdata(struct rte_security_ctx > *instance, uint64_t md) > return userdata; > } >=20 > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capabilities_get(struct rte_security_ctx *instance) { > RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->capabilities_get, NULL); > return instance->ops->capabilities_get(instance->device); > } >=20 > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capability_get(struct rte_security_ctx *instance, > struct rte_security_capability_idx *idx) { d= iff --git > a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h > index 1431b4d..e07b132 100644 > --- a/lib/librte_security/rte_security.h > +++ b/lib/librte_security/rte_security.h > @@ -8,7 +8,6 @@ >=20 > /** > * @file rte_security.h > - * @b EXPERIMENTAL: this API may change without prior notice > * > * RTE Security Common Definitions > * > @@ -330,7 +329,7 @@ struct rte_security_session { > * - On success, pointer to session > * - On failure, NULL > */ > -struct rte_security_session * __rte_experimental > +struct rte_security_session * > rte_security_session_create(struct rte_security_ctx *instance, > struct rte_security_session_conf *conf, > struct rte_mempool *mp); @@ -345,7 +344,7 @@ > rte_security_session_create(struct rte_security_ctx *instance, > * - On success returns 0 > * - On failure return errno > */ > -int __rte_experimental > +int > rte_security_session_update(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_session_conf *conf); @@ -= 359,7 +358,7 @@ > rte_security_session_update(struct rte_security_ctx *instance, > * - Size of the private data, if successful > * - 0 if device is invalid or does not support the operation. > */ > -unsigned int __rte_experimental > +unsigned int > rte_security_session_get_size(struct rte_security_ctx *instance); >=20 > /** > @@ -374,7 +373,7 @@ rte_security_session_get_size(struct rte_security_ctx > *instance); > * - -EINVAL if session is NULL. > * - -EBUSY if not all device private data has been freed. > */ > -int __rte_experimental > +int > rte_security_session_destroy(struct rte_security_ctx *instance, > struct rte_security_session *sess); >=20 > @@ -391,7 +390,7 @@ rte_security_session_destroy(struct rte_security_ctx > *instance, > * - On success, zero. > * - On failure, a negative value. > */ > -int __rte_experimental > +int > rte_security_set_pkt_metadata(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_mbuf *mb, void *params); @@ -413= ,7 +412,7 @@ > rte_security_set_pkt_metadata(struct rte_security_ctx *instance, > * - On success, userdata > * - On failure, NULL > */ > -void * __rte_experimental > +void * > rte_security_get_userdata(struct rte_security_ctx *instance, uint64_t md= ); >=20 > /** > @@ -422,7 +421,7 @@ rte_security_get_userdata(struct rte_security_ctx > *instance, uint64_t md); > * @param sym_op crypto operation > * @param sess security session > */ > -static inline int __rte_experimental > +static inline int > __rte_security_attach_session(struct rte_crypto_sym_op *sym_op, > struct rte_security_session *sess) { @@ -4= 31,13 +430,13 @@ > __rte_security_attach_session(struct rte_crypto_sym_op *sym_op, > return 0; > } >=20 > -static inline void * __rte_experimental > +static inline void * > get_sec_session_private_data(const struct rte_security_session *sess) { > return sess->sess_private_data; > } >=20 > -static inline void __rte_experimental > +static inline void > set_sec_session_private_data(struct rte_security_session *sess, > void *private_data) { @@ -453,7 +452,7 @@ > set_sec_session_private_data(struct rte_security_session *sess, > * @param op crypto operation > * @param sess security session > */ > -static inline int __rte_experimental > +static inline int > rte_security_attach_session(struct rte_crypto_op *op, > struct rte_security_session *sess) { @@ -500= ,7 +499,7 @@ > struct rte_security_stats { > * - On success return 0 > * - On failure errno > */ > -int __rte_experimental > +int > rte_security_session_stats_get(struct rte_security_ctx *instance, > struct rte_security_session *sess, > struct rte_security_stats *stats); @@ -608= ,7 +607,7 @@ struct > rte_security_capability_idx { > * - Returns array of security capabilities. > * - Return NULL if no capabilities available. > */ > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capabilities_get(struct rte_security_ctx *instance); >=20 > /** > @@ -622,7 +621,7 @@ rte_security_capabilities_get(struct rte_security_ctx > *instance); > * index criteria. > * - Return NULL if the capability not matched on security instance. > */ > -const struct rte_security_capability * __rte_experimental > +const struct rte_security_capability * > rte_security_capability_get(struct rte_security_ctx *instance, > struct rte_security_capability_idx *idx); >=20 > diff --git a/lib/librte_security/rte_security_driver.h > b/lib/librte_security/rte_security_driver.h > index 42f42ff..1b561f8 100644 > --- a/lib/librte_security/rte_security_driver.h > +++ b/lib/librte_security/rte_security_driver.h > @@ -8,7 +8,6 @@ >=20 > /** > * @file rte_security_driver.h > - * @b EXPERIMENTAL: this API may change without prior notice > * > * RTE Security Common Definitions > * > diff --git a/lib/librte_security/rte_security_version.map > b/lib/librte_security/rte_security_version.map > index 5a1c8ae..a77ca4b 100644 > --- a/lib/librte_security/rte_security_version.map > +++ b/lib/librte_security/rte_security_version.map > @@ -1,4 +1,4 @@ > -EXPERIMENTAL { > +DPDK_18.11 { > global: >=20 > rte_security_attach_session; > -- > 2.7.4