From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Apeksha Gupta <apeksha.gupta@nxp.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: update MAX_FRAG to support jumbo packets
Date: Mon, 6 Apr 2020 16:55:00 +0000 [thread overview]
Message-ID: <SN6PR11MB25581A23DF3A5569BBB575CA9AC20@SN6PR11MB2558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200401083532.13658-1-apeksha.gupta@nxp.com>
>
> RTE_LIBRTE_IP_FRAG_MAX_FRAG flag value increased from 4 to 8. By this
> pkt size greater than 6000 is supported in ip-fragmentation and
> ip-reassembly.
>
> Fixes: 9788b93b9d5 ("config: MAX_FRAG updated to support the jumbo
> packets")
> Cc: stable@dpdk.org
>
> Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
> ---
> config/common_base | 2 +-
> config/rte_config.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/common_base b/config/common_base
> index e231384e88..be4a6bafb5 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -950,7 +950,7 @@ CONFIG_RTE_LIBRTE_NET=y
> #
> CONFIG_RTE_LIBRTE_IP_FRAG=y
> CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n
> -CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4
> +CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=8
> CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n
>
> #
> diff --git a/config/rte_config.h b/config/rte_config.h
> index d30786bc08..f5cdc3ddbe 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -82,7 +82,7 @@
> #define RTE_RAWDEV_MAX_DEVS 64
>
> /* ip_fragmentation defines */
> -#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 4
> +#define RTE_LIBRTE_IP_FRAG_MAX_FRAG 8
> #undef RTE_LIBRTE_IP_FRAG_TBL_STAT
Not sure it is a good idea - it will double size of reassembly table
(and number of required mbufs) for users who use default value.
The proper way would be, I think to restructure reassemble code,
to make max_frag_num an extra parameter for rte_ip_frag_table_create().
>
> /* rte_power defines */
> --
> 2.17.1
prev parent reply other threads:[~2020-04-06 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 8:35 Apeksha Gupta
2020-04-06 16:55 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB25581A23DF3A5569BBB575CA9AC20@SN6PR11MB2558.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=apeksha.gupta@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).