From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F0D3A04F1; Mon, 6 Jan 2020 17:50:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 903EB1D6D8; Mon, 6 Jan 2020 17:50:38 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 672591D6D7 for ; Mon, 6 Jan 2020 17:50:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jan 2020 08:50:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,403,1571727600"; d="scan'208";a="271236484" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 06 Jan 2020 08:50:35 -0800 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jan 2020 08:50:34 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jan 2020 08:50:34 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 6 Jan 2020 08:50:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K8FXkJXAJ5XS5ZVwsU8gZpzR4a0VyMCHTjMf2w+v31Gg2q81nuhQGoFHMm/QoIl+AktEpYA7X7A9Kh7hG5WHG6ZgCixGEvEGXsTQd2hX3gegJo1RRmj6ocCGXIRutPOlEdBkyv1N67Mtk4f+dDbqWUo6ag1gbhGFiQosNnz8IDX4MZYirjGh927BQYvHrnNxSEHjRxI6s07U6f6+hbFkWCRuf3hE/0ZZplouvvajEIDkOdzjKppBBzXBusoTjZaXj2WRnKQA0uh/jPVsq+a5DDvGSq/5m9XF4wTsBzSdthC834RxKpWyqRFzoD4UH4fe2EeqHG0IscmFOaB+r7sOxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NdfbQVWUaf7Lfgdzq+z5mZ4QeAio1jEeTx5N0h89G4s=; b=aIdPqlrZUvkNE9e4kPXBLUoAnER8aPDdnVE7qweGC28qLM2NEbH3lfhwIBw7Uuzx7HoBOtbzv+mhO4vFopvIo2SgyUgADQzVoimDEkRBesVYeK1fsHSD0lvTP3oYpn+VoEUNu+LXr1HaoHcR9WSM/zc8Y16V7EVPV3mSDBmSsSJfhZtJYRLhOL6wbl//tO7Ibc3oGC82oTK+ZkCKap7NPPVmqCTO2zegJswU2j1KFrTUT/9C1Up7AlrI8dD/hnGDqU7nfHUxEusvBOwypj6F+2jBsGwgOBrhQoJlzcg9k3Jz3/zxBZXoGyhQaErNu4ew6fLbnqov0UI/kUMI/shIoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NdfbQVWUaf7Lfgdzq+z5mZ4QeAio1jEeTx5N0h89G4s=; b=e2JvQfrCzU53R4sWPDoo61UMNpzbtkKXuhFyzigwUTSaj4MDRpgG9A64BslfKFCFXfyeBTydAFAzpWfsjyt4K3xnNFH9gzZITlD6p0tx8nSS9izp42WKZi4tTzXa9SCCPNW8M15i/h3tklc2VW7rsdauGHUF2DDsjNuUM4zL0+0= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (52.135.94.19) by SN6PR11MB2656.namprd11.prod.outlook.com (52.135.91.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.15; Mon, 6 Jan 2020 16:50:32 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::4d86:362a:13c3:8386]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::4d86:362a:13c3:8386%7]) with mapi id 15.20.2602.015; Mon, 6 Jan 2020 16:50:32 +0000 From: "Ananyev, Konstantin" To: Anoob Joseph , Akhil Goyal , "Nicolau, Radu" , Thomas Monjalon CC: Lukas Bartosik , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , Ankur Dwivedi , Archana Muniganti , Tejasree Kondoj , "Vamsi Krishna Attunuru" , "dev@dpdk.org" Thread-Topic: [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw Thread-Index: AQHVrcOQjf1Dol+ZoUa/RbcKkKjo2KfJUKOQgA+SlACABR0/UA== Date: Mon, 6 Jan 2020 16:50:32 +0000 Message-ID: References: <1575808249-31135-1-git-send-email-anoobj@marvell.com> <1575808249-31135-10-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDE0MjA1NjEtZWQ5Mi00OGM0LThhNzktYzJmZTE4NGRlYzdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiazhqZE1lRXRpQVVsNXpzb1RQdExJXC9tczNmNXFmNmJieUlBQVVJcG1jcmwySWxxSU5RNFJPc3BcL0xVenkrWTlIIn0= dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b1e72982-488a-4dc0-cfc4-08d792c88b4a x-ms-traffictypediagnostic: SN6PR11MB2656: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0274272F87 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(136003)(396003)(39860400002)(376002)(346002)(189003)(199004)(55016002)(4326008)(9686003)(52536014)(86362001)(2906002)(33656002)(71200400001)(5660300002)(54906003)(110136005)(316002)(8936002)(186003)(8676002)(81156014)(7416002)(81166006)(76116006)(26005)(6506007)(66946007)(478600001)(7696005)(64756008)(66446008)(66556008)(66476007); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2656; H:SN6PR11MB2558.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UJJy1FXHvEYz3DnMTxnRE+vZmWkUH1KkhHtiX/yFkyv7U+UBtQdGIvZYnOSuQjvrFMerbgP4oZI3iY9ZHDwiv2T/2knmoPUZne26Ym3DTdrDgBj06FOkz6+hMJmMc1Irual1GqXdWnJra8cs+Mewsc3X4QnQvGSCx4258gVDLa3UywbCPhNJkyYG24cXwtENg8AaUJ7dCKEIsYHcq9xfhd7EWiTrwh/y4//ERAV3axkPPhYZQagLyuZmKIpQ6l55BgG+2JTLMTP0KBSbZ7x1mEyAXtZVqUA4E0YjjgjUnQY8a1N2p3Vzx6Tq3A4+InTZo4r+4S1aqxQhFO6CiWlpoEBx/B0v0WdcBPwCwMHejNaU16fdv+YkQwsR1TWPeahUUNE12bjSBht7X5/S0N4ZHm5TRE/V9FYBRg7aEfJzOCWW1TC42IGuYg7RvxJRoXGr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b1e72982-488a-4dc0-cfc4-08d792c88b4a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2020 16:50:32.3355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mi4tHUgW6BcdGnKwjrToZyKLxqDYPS5o9HZw7eJcV0lI7oZRYlUXigDOyQJKmgNInqoGac75pbA8/3A8mY5hJ9kIQPP4sNhEmo7t8VgmNEo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2656 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 09/14] examples/ipsec-secgw: add eventmode to ipsec-secgw X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > Add eventmode support to ipsec-secgw. This uses event helper to setup > > > and use the eventmode capabilities. Add driver inbound worker. > > > > > > Example command: > > > ./ipsec-secgw -c 0x1 -w 0002:02:00.0,ipsec_in_max_spi=3D100 -w > > > 0002:07:00.0 -w 0002:0e:00.0 -w 0002:10:00.1 -- -P -p 0x3 -u 0x1 > > > --config "(0,0,0),(1,0,0)" -f a-aes-gcm-msa.cfg --transfer-mode 1 > > > --schedule-type 2 --process-mode drv --process-dir in > > > > As I can see new event mode is totally orthogonal to the existing poll= mode. > > Event mode has it is own data-path, and it doesn't reuse any part of po= ll- > > mode data-path code. > > Plus in event mode many poll-mode options: > > libirary/legacy mode, fragment/reassemble, replay-window, ESN, fall-bac= k > > session, etc. > > are simply ignored. >=20 > [Anoob] The features are not supported with the initial version. But the = features are equally applicable to eventmode and is planned for the > future. Also, fragment/reassemble, replay-window, ESN, fall-back session = etc are not applicable for non-library mode.=20 True, but in poll-mode library-mode support all functionality that legacy-m= ode does, plus some extra. Also I still hope that after perf-problems evaluation with NXP we will be a= ble to safely remove legacy poll-mode. =20 >We can follow the > same logic and allow for an extra arg (which is --transfer-mode). >=20 > > Also as I can read the current code - > > right now these modes can't be mixed and used together. > > User has to use either only event based or poll mode API/devices. >=20 > [Anoob] Same like how we cannot mix library and non-library modes. >=20 > > > > If so, then at least we need a check (and report with error exit) for t= hese > > mutually exclusive option variants. >=20 > [Anoob] Will do that. Ok. =20 > > Probably even better would be to generate two separate binaries Let say= : > > ipsec-secgw-event and ipsec-secgw-poll. > > We can still keep the same parent directory, makefile, common src files= etc. > > for both. >=20 > [Anoob] I would be inclined to not fork the current application. Do you s= ee any issues if the same binary could run in both modes. The > default behavior would be poll mode (with existing behavior). My main concern here that there will be over-helming number of options (some of which are mutually exclusive) in the same app. So it will be really hard to maintain and use such app. My thought was that it might be cleaner to have two different apps each with its own set of options. =20 =20