From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Martin Weiser <martin.weiser@allegro-packets.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Zhu, TaoX" <taox.zhu@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] net/ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads
Date: Thu, 9 Apr 2020 15:31:58 +0000 [thread overview]
Message-ID: <SN6PR11MB2558663259FBDA2B5B72CA079AC10@SN6PR11MB2558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <76e82b41-3a76-6c6e-bb47-1f9e0809a153@allegro-packets.com>
Hi Martin,
> Sorry, please ignore my previous statement about this having been
> reworked in master. I was comparing to the wrong checkout.
> This issue seems to be still present in the current master.
Can you please file a ticket with your findings in the bugzilla?
Thanks
Konstantin
>
> Am 09.04.20 um 14:06 schrieb Martin Weiser:
> > Hi,
> >
> > I should have mentioned that our findings apply to DPDK 20.02. I can see
> > in master that this since has been reworked to use rte_eal_alarm_set()
> > instead of using a thread.
> > But maybe this should be addressed in stable?
> >
> > Best regards,
> > Martin Weiser
> >
> >
> > Am 09.04.20 um 12:30 schrieb Martin Weiser:
> >> Hi,
> >>
> >> we recently discovered that our application was not able to create new
> >> threads or perform mmaps after some time.
> >> With some digging we identified the function
> >> ixgbe_dev_link_update_share() to be the reason for this behavior.
> >>
> >> In the patch "net/ixgbe: fix blocking system events"
> >> (819d0d1d57f17aa40321648e99a50b49adc7bdf6) a thread is introduced to
> >> run ixgbe_dev_setup_link_thread_handler().
> >> Unfortunately this thread is not detached and just joined (the very
> >> last one spawned that is) through ixgbe_dev_cancel_link_thread() upon
> >> interface start/stop.
> >>
> >> When an application repeatedly calls e.g. rte_eth_link_get_nowait() on
> >> an ixgbe interface with no link this causes a lot of pthreads never to
> >> be cleaned up.
> >> Since each thread holds a mmap to the stack this can quite quickly
> >> exhaust the allowed number of memory mappings for the process.
> >>
> >> Best regards,
> >> Martin Weiser
> >>
next prev parent reply other threads:[~2020-04-09 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <35d734a2-34c4-3cc8-6e3e-58a17a7bb9da@allegro-packets.com>
2020-04-09 12:06 ` Martin Weiser
2020-04-09 12:33 ` Martin Weiser
2020-04-09 15:31 ` Ananyev, Konstantin [this message]
2020-04-09 10:31 Martin Weiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2558663259FBDA2B5B72CA079AC10@SN6PR11MB2558.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=martin.weiser@allegro-packets.com \
--cc=taox.zhu@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).