From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72524A0565; Mon, 23 Mar 2020 13:21:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 294651C05C; Mon, 23 Mar 2020 13:21:09 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 423B71C044; Mon, 23 Mar 2020 13:21:07 +0100 (CET) IronPort-SDR: QEBHxGb3R1qoEDpcjArNvfPqF32l/vtxJ6cJ82QQqlAzgmUSkV8Hyj8t8+X6xiBvsNNpYv5n7o FlGiqPRSntnQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 05:21:04 -0700 IronPort-SDR: tkkNMaJT7Nys9xJslI3G6DjjLT6LSLuAV81OnLNRGGeChCnst64j+meKCSOKKXdId4NokTMDbR 8SimmoprgCqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,296,1580803200"; d="scan'208";a="239914669" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga008.jf.intel.com with ESMTP; 23 Mar 2020 05:21:04 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Mar 2020 05:21:03 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 23 Mar 2020 05:21:03 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 23 Mar 2020 05:21:03 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Mar 2020 05:21:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f9iZt+yVIp4nJtpNO5YRLJPhvhz2mDfQvIPnliqtyXcVvSUQwYCjSSgEyN595hiOlD/ygLTZRmc7J/Yynm56cc6JsA2mWuBxPnbDS8uiK9mR+jDvJs81ByZ15Vd+/woj4AQlrHhCaiJFgOl+0Z06jpeFqkYbYuUThRIrV1GVtUYIPe+xqFWk/PFDzN8q6MvncFepnimU02jG/AFkv0PigxOdN/aC1sQViGv9nDKqH8PjVCJ4SLh4bH+RzWmtjb87Owtj6nNOoOZUQpadFkKnCaKISQUrI5F0vBC7YfVks/mrxuvtFhSx7JvbKdgaElx5syiBKrn5Tnkb1YvoYFKDmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yiIJbjXUoZ22iBBx+vD+5e6bXL0HBloaO7Mb9ntaxJo=; b=M7Hb93VvzJD3QrrT6FaR5s3vYgOyqIxMeGSEiD0kkU5dnFG0vsBC4oH2cfhnY/DU4njQXOYh29Btrb1nAlk2lbnBarTKJJOhpqXmZWKtGq0JKWs2hsNNEHseUpwy/knuZjUk5b/+Emy5UV5kipSjZI/ux0nq/BagmLAKZ/5X0oN3JszZlhnEPBAun/lRtJoTAvZneMG6pFFihaISC08XSkRzs3EE0A+yAwp9f2SnYIMpY0Sx27VvVBaI0hNxsIBVjlhNo87eM0MrFq/XryB6nyKoVoZw5Wv1MrFlY9mWAEcl/cvG1EV9SnZnAttrGdmTb52Cu/wgZKlMunv1VpcYNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yiIJbjXUoZ22iBBx+vD+5e6bXL0HBloaO7Mb9ntaxJo=; b=dV5EwwNWtcoCZBZ0S0Lz7LC/b2VF/FpO3F9vFBVwaMcvvj1jx5gTrOSsxDGCVSMn46Q+aTF+dbIuRIInQHLgRT1dfnzocnPcGfrD9GMqcEeWoyi009iVeH05JCXtx9dZf3nlZCfvmL5NMguzC8LSj3yZJq/agCafb8XKSfFKRW0= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (2603:10b6:805:5d::19) by SN6PR11MB2896.namprd11.prod.outlook.com (2603:10b6:805:d9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Mon, 23 Mar 2020 12:21:00 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::5df7:d515:ec1d:8db1]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::5df7:d515:ec1d:8db1%7]) with mapi id 15.20.2835.021; Mon, 23 Mar 2020 12:21:00 +0000 From: "Ananyev, Konstantin" To: Ruifeng Wang , "Iremonger, Bernard" CC: "dev@dpdk.org" , "gavin.hu@arm.com" , "honnappa.nagarahalli@arm.com" , "juraj.linkes@pantheon.tech" , "nd@arm.com" , "stable@dpdk.org" Thread-Topic: [PATCH v1] test: fix ipsec unit test segfault Thread-Index: AQHV/o6A7RqVxkBoFEyybiAx4KQXU6hWHMUQ Date: Mon, 23 Mar 2020 12:21:00 +0000 Message-ID: References: <20200320080520.144952-1-ruifeng.wang@arm.com> In-Reply-To: <20200320080520.144952-1-ruifeng.wang@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.182] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac3334dc-9a5b-45df-31e5-08d7cf24a5b1 x-ms-traffictypediagnostic: SN6PR11MB2896: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-forefront-prvs: 0351D213B3 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(376002)(346002)(366004)(396003)(136003)(199004)(8676002)(26005)(316002)(81156014)(478600001)(8936002)(81166006)(55016002)(86362001)(5660300002)(9686003)(66446008)(4326008)(52536014)(186003)(66556008)(64756008)(66476007)(76116006)(66946007)(6506007)(6636002)(7696005)(2906002)(33656002)(110136005)(71200400001)(54906003); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2896; H:SN6PR11MB2558.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Cz0sXtX87DfSgjeA50novCOLnNQ4fX+ilSDNG8B8n+EIl17jKKdfOeUCr95ZbQ9xkGqfx+dxfANdYlFOufiZy9IR1RX0gieAxqreV4wPGt96ue83HfIPZTZXey2HSBiCcFsnKfp+L9ptRnbmw+qJQ7VIGbyA3mOl/dQm6c/hFpUGk0ecpDICM8gX0f59UUmY2NznfWV+mlYXoUsOSxbYIY5ovkjVR7bwpNQUKPpr7nJaJ3EwF3t6JycnluOZAG2O7hKSp4ZIRyiNzK8VvkyC0Uvnf/gtl42ldAn2In9wX5D5IVD9opvRG/nC4R60lhBj3ZE9+Y0bM7w77XVU0m0pK/2WOAAcfpwboFbh0l5MG1FRr1Ot+27Ml+9k4iaS+o6a5o3XOKwPAJ7AD7A/zNjhwOWTVH6YeOjqIOww2BThIoEbxTEYACRI2V97pVFui6JS x-ms-exchange-antispam-messagedata: YcRqqvqqdtN+AVR1GfRnDCN/+q/XUhJsXu5joedVlAV9NukhJt6ByCIZG/npzBXwPimKI8g9FMDZjgLPksn5Yc/mpHmgEvxyJsuB7VOQY39Z/dq4I7TQXkpAfbUzJ7LIxCJfdnJwWRvTyANqyBI5Ng== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ac3334dc-9a5b-45df-31e5-08d7cf24a5b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2020 12:21:00.0770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /1nEISQFxIiqHfYK7NxHOiaJxtwBRFuQyJc61JqT/wMw/k/IBF7f8aNgHEjUyD17l/9iGrJGjsHuaTApzxCldJy6scJSKSMH0I6V47BA9Gw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2896 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] test: fix ipsec unit test segfault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Segfault was observed when running ipsec unit test: >=20 > + TestCase [10] : test_ipsec_replay_inb_repeat_null_null_wrapper > succeeded > + TestCase [11] : test_ipsec_replay_inb_inside_burst_null_null_wrapper > succeeded > + TestCase [12] : test_ipsec_crypto_inb_burst_2sa_null_null_wrapper > succeeded > + TestCase [13] : test_ipsec_crypto_inb_burst_2sa_4grp_null_null_wrapper > succeeded > Segmentation fault >=20 > Data corruption happens due to incorrect destroy of session. Security > session needs process different from crypto session. >=20 > Destroy corresponding sessions according to different security actions. >=20 > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ruifeng Wang > Reviewed-by: Phil Yang > Reviewed-by: Gavin Hu > --- > app/test/test_ipsec.c | 33 ++++++++++++++++++++++++++++++--- > 1 file changed, 30 insertions(+), 3 deletions(-) >=20 > diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c > index 9e1447293..79d00d7e0 100644 > --- a/app/test/test_ipsec.c > +++ b/app/test/test_ipsec.c > @@ -1167,6 +1167,34 @@ test_ipsec_dump_buffers(struct ipsec_unitest_param= s *ut_params, int i) > } > } >=20 > +static void > +destroy_dummy_sec_session(struct ipsec_unitest_params *ut, > + uint32_t j) > +{ > + rte_security_session_destroy(&dummy_sec_ctx, > + ut->ss[j].security.ses); > + ut->ss[j].security.ctx =3D NULL; > +} > + > +static void > +destroy_crypto_session(struct ipsec_unitest_params *ut, > + uint8_t crypto_dev, uint32_t j) > +{ > + rte_cryptodev_sym_session_clear(crypto_dev, ut->ss[j].crypto.ses); > + rte_cryptodev_sym_session_free(ut->ss[j].crypto.ses); > + memset(&ut->ss[j], 0, sizeof(ut->ss[j])); > +} > + > +static void > +destroy_session(struct ipsec_unitest_params *ut, > + uint8_t crypto_dev, uint32_t j) > +{ > + if (ut->ss[j].type =3D=3D RTE_SECURITY_ACTION_TYPE_NONE) > + return destroy_crypto_session(ut, crypto_dev, j); > + else > + return destroy_dummy_sec_session(ut, j); > +} > + > static void > destroy_sa(uint32_t j) > { > @@ -1175,9 +1203,8 @@ destroy_sa(uint32_t j) >=20 > rte_ipsec_sa_fini(ut->ss[j].sa); > rte_free(ut->ss[j].sa); > - rte_cryptodev_sym_session_clear(ts->valid_dev, ut->ss[j].crypto.ses); > - rte_cryptodev_sym_session_free(ut->ss[j].crypto.ses); > - memset(&ut->ss[j], 0, sizeof(ut->ss[j])); > + > + destroy_session(ut, ts->valid_dev, j); > } >=20 > static int > -- Good catch, thanks for the fix. As a nit caption should probably be: "test/ipsec: fix ..." Tested-by: Konstantin Ananyev Acked-by: Konstantin Ananyev > 2.17.1