From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76F2DA0531; Tue, 4 Feb 2020 11:44:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF1B01C00E; Tue, 4 Feb 2020 11:44:00 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 98A181C00D for ; Tue, 4 Feb 2020 11:43:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 02:43:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,401,1574150400"; d="scan'208";a="225470049" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga008.fm.intel.com with ESMTP; 04 Feb 2020 02:43:58 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 02:43:58 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 4 Feb 2020 02:43:55 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 4 Feb 2020 02:43:55 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 4 Feb 2020 02:43:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VrNNxRpvDaMyiBuuWOC3AxE1tK3ylp/Z9YjZWQs6lMtoEGUyroWec3eF1w0zhQOIsuRvtOhCCSfaaGH1x2262iRmLtC73s6r2OAjiyX+LfzqsHzS5SautOyw6kGXceJQJ+Fg6C0hmI98AHLqOGFzFs37e4qf7pGI1ZEtWUClohpbWC7GxF98iayx/ZODS4h3V9/jf1WowQA2ymPzCOfFpVC6p8RuhIHbDN8qvAikn8evi81KLi6OPb/t6L6dRmjCN4/VV6KCZeQIq5q/jKXAdehvJNXECMGH6bCe9QFHcAcU9ANEfLAaB4nvz+9NpGib6AeTIuREYr2MGna8dET03Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8I2WCXNscTRYekKpDw7r8RKwMYxrZ5xNDS3frO2DeLY=; b=W2CGpYFPdCgjVvPqCn8KLmxauGyDiM3fEgRXyD8drvf2dHgz4/LX+qlpBDSrm0abahU16CvIIo5X1W3/bxv7l5Nb+dNUut160tZVy7aY3vkhmVoFQxXLpIZ55fh7GxCoPW55e8cEzCkf0glkvG+j+cxVJCOWEGYXq7sq14h5HSkg6w2AZSRsy84s3Jw/qoAsqXDxla5Nt9sR7XC4Y2f69VT5qUG40STWDXWF515Hqz99iaFWmxYaXLgzzTUH4A32FKtIQF/mbPeAA1qadR91b7Yi8YbYododPrOfU/khwg9LqHzve8vgdsPlnKGoIYaTQfhCD4AenqPeVw/Ik+vDBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8I2WCXNscTRYekKpDw7r8RKwMYxrZ5xNDS3frO2DeLY=; b=YiZfjvxa1yBjAfNQWdmkvobeRLKThlw5agG9akQxDGqn4a8t6VCxnHJxWN5L1zqQYeIjP+5mwyouFyWm/g8G6XLBIqLt4cR1iIPncT8tvwo3DUSKbrf2x/iVcMKsVwJCHtZ4m5lwShBBL5fN1Rvit2RPFxS17yVrHRENW3fPQD8= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (52.135.94.19) by SN6PR11MB2704.namprd11.prod.outlook.com (52.135.89.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 10:43:51 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::395e:eb75:6ab7:2ba5]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::395e:eb75:6ab7:2ba5%3]) with mapi id 15.20.2686.031; Tue, 4 Feb 2020 10:43:50 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "Smoczynski, MarcinX" , "Zhang, Roy Fan" , "Doherty, Declan" , "Nicolau, Radu" , "De Lara Guarch, Pablo" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 4/8] security: add cpu crypto action type Thread-Index: AQHV1eZ8wnnaePlswEKSSGFPbUqQfqgE2P4AgAYJOwCAAAEUYA== Date: Tue, 4 Feb 2020 10:43:50 +0000 Message-ID: References: <20200128031642.15256-1-marcinx.smoczynski@intel.com> <20200128142220.16644-1-marcinx.smoczynski@intel.com> <20200128142220.16644-5-marcinx.smoczynski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTNhNTRlYzgtZmE3NC00YTcyLThlZDEtZmRiZTQ1ZGJkNWRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZjlTNkMwSlFZNk5OUVYxODl5YUVpTmRuT2xEWkFaOWFRcld6dmpxWG9INURIS2t2R29qRTR1aEJpV0p5YTE5TyJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 179a9473-cbe8-461b-42ba-08d7a95f1f5e x-ms-traffictypediagnostic: SN6PR11MB2704: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03030B9493 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(376002)(136003)(366004)(346002)(199004)(189003)(52536014)(55016002)(2906002)(478600001)(316002)(9686003)(64756008)(86362001)(76116006)(66446008)(66476007)(66556008)(66946007)(7696005)(15650500001)(6506007)(4326008)(33656002)(5660300002)(186003)(110136005)(26005)(8676002)(71200400001)(81166006)(6636002)(8936002)(81156014)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2704; H:SN6PR11MB2558.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BYt+ii+LReZc3/IiHzbWprd4PztIR2CVbG7fsVj12YYlUiq7Pdh/GM1iNDaBjj2753W6u+xFyJAyQ10knuue7mnLTHL7wSRX856sb+MgcUzpYSMAkhYZP9iszpYh3qeci3QMET4z8/O+FT+F2SLZAfza1R9+NBoHFJhQx0cS1d72NGhA0yzxqk53yId2330H6tLjHLyF+OI3MvrX0NhZDWObQjEj0pLpZUTEZaGVZsYAmmaTMaM/075x1J6w/sKZK0JlvwvubR8MBnSeLjOolmHGwnl8Q5RFeI+E8/Hokm8CFmvlAWFt3Me10af6SajQUFj9uWzHD6v23nqHBXHI9a+23JuYbLESYv85Z7A0ydmnoon/EI+UOf0C3UOQG5SnCoaxxoPzzZ4Ao+39/Y2AHigeloR7vjMZiPRLMhf3tGhr0uAS5NmOM4BeEVBY8e/uEOKRFhG0RNKyhnbmlTqXD5LEHBPIOsXXiFNMJ5cX4/gG7EZy5z8GErc8bAgMfHq8 x-ms-exchange-antispam-messagedata: cQxM9NXTS828uHnr9jwvfyFtq6NuUBcloLy1jTabcBjyPpRgAaX/6AE0FOoty+2aypwJ3Oc97TiIis0lAq13/ZYCKtcjyq9aOcnwWEhYYi8lSX9f7QQqEbLsUwCtVLzUAQ1W7G1f1sWq0ELe2mgwjw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 179a9473-cbe8-461b-42ba-08d7a95f1f5e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2020 10:43:50.7304 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gcoxAhNOUNEIUTupdChBewDnDogLCNRSm/Fk7CgFROk/zjIkzWdiCuaT3CCMkIDiIAorfuISesTt8ysePac90DQEq5pQFd1zRnkYuQvTzUg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2704 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 4/8] security: add cpu crypto action type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > > > Introduce CPU crypto action type allowing to differentiate between > > > regular async 'none security' and synchronous, CPU crypto accelerated > > > sessions. > > > > > > Signed-off-by: Marcin Smoczynski > > > Acked-by: Konstantin Ananyev > > > Acked-by: Fan Zhang > > > --- > > > lib/librte_security/rte_security.h | 8 ++++++-- > > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > > > diff --git a/lib/librte_security/rte_security.h b/lib/librte_security= /rte_security.h > > > index 546779df2..c8b2dd5ed 100644 > > > --- a/lib/librte_security/rte_security.h > > > +++ b/lib/librte_security/rte_security.h > > > @@ -1,6 +1,6 @@ > > > /* SPDX-License-Identifier: BSD-3-Clause > > > * Copyright 2017,2019 NXP > > > - * Copyright(c) 2017 Intel Corporation. > > > + * Copyright(c) 2017-2020 Intel Corporation. > > > */ > > > > > > #ifndef _RTE_SECURITY_H_ > > > @@ -307,10 +307,14 @@ enum rte_security_session_action_type { > > > /**< All security protocol processing is performed inline during > > > * transmission > > > */ > > > - RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL > > > + RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL, > > > /**< All security protocol processing including crypto is performed > > > * on a lookaside accelerator > > > */ > > > + RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO > > > + /**< Crypto processing for security protocol is processed by CPU > > > + * synchronously > > > + */ > > I am not able to see the need for this enum. > > > > It is used by the app and ipsec library to identify the cpu-crypto code= path. > > > > I don't see any security action been performed for this action_type. > > > > This enum is just like NONE which is not used beyond the application/li= b. > > I think this needs to be documented properly in the description of the = enum. > > > > It should be something like > > > > Similar to ACTION_TYPE_NONE, but the crypto processing is done on CPU > > Synchronously. > > > > Also add documentation of this in the rte_security.rst in this patch on= ly. > > There should not be any separate patch for documentation. > > >=20 > Could you please send the update to the patches that I requested. > I wanted to apply these today. Marcin works on v6 to address your comments. Plan to send it by COB today. Konstantin=20