From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F5ECA04F9; Fri, 10 Jan 2020 00:08:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA9581DE63; Fri, 10 Jan 2020 00:08:13 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 22CF41DE5C for ; Fri, 10 Jan 2020 00:08:11 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 15:08:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,414,1571727600"; d="scan'208";a="229132030" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 09 Jan 2020 15:08:03 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 15:08:02 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 9 Jan 2020 15:08:02 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 9 Jan 2020 15:08:02 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 15:08:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d+ky+fPly/9lgf/arT5DyWwQ9ECYvQtp+787Rkk/idvg0FExe1fiMoh3DEBrnNCIfVYChmYtxiJfkbyrGBK2ti7MOsb9df/3dUEzrkPwRNNWA+pDz9Hadda3Gz3MAdmLPePh5T2tVqTjTQv7A5giwDayff3Zj9EnWKdwznpe64g1o3PwgfBsN+ooM3U5iPEndpJvSlOlNex2Khg7Gf7a0mHYtVXLg/uydfgn68jXHD6nuj4Qb/itXKtWOfMz4d6PzY1/54tFY9ay5q4Cs4uMSv1/JjtyP5kwVIJkv2ThRV2cBznWbEuyqF8bn/H7byAUNTmV7m4SUfIoFJEufomoBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UMimtHO1kPV2K/3vJzF1HvoW/3Uy77utppQVmTjlA6Y=; b=W79q7ZY0KJf7O6/ZZYTG89/abi4Ao73175NX5z3zCRLJ2i1dmUeGE2U/tBUQGFdb+L9BXmMz7dk500x1QFk8R5TqRApCAAR+N0lsnMOca5u+DE/zERttgC7ObJkvzF9yhgXjKXXga3vgBJElxjE/tmkg4+8HaJnMZeWB1tjaqjCoAK7zxJysr5mi170ffdH6++E83bjDPoGT485+5mGVWTkwT54BRerueuwFKKr/632W+jbn/JmcGSkvin2u9H3m/t6GaR4fQ0iCjwuvjQFOYsZbUWRtM0Z7EoNL2f4QM5nSCUCPxnfeAt+fPRh3YOwag5v+fs3z5pBiD/F5e9yZIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UMimtHO1kPV2K/3vJzF1HvoW/3Uy77utppQVmTjlA6Y=; b=oj+YdI8eC2Fio4cSEphHg5iD1jleFoMtYzUlqia0CfDP8AKRLM9DIwLTgyuNhSQhzfjfjWBrSy/yaLkdoRcN77lMWwVboxXPIyXB8fPn3QtBO7YWSUwxDSajOxz+A0N3GuBlz2E8lSCEf1yJSZ0caBYKU+xHCRkaGjVVpeuDJAs= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (52.135.94.19) by SN6PR11MB3261.namprd11.prod.outlook.com (52.135.110.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Thu, 9 Jan 2020 23:07:57 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::4d86:362a:13c3:8386]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::4d86:362a:13c3:8386%7]) with mapi id 15.20.2623.008; Thu, 9 Jan 2020 23:07:57 +0000 From: "Ananyev, Konstantin" To: "Iremonger, Bernard" , "Zhang, Qi Z" , "dev@dpdk.org" , "Xing, Beilei" , "Doherty, Declan" CC: "Byrne, Stephen1" , "Zhang, Helin" Thread-Topic: [PATCH v3 6/9] net/i40e: display Flow Director packet Thread-Index: AQHVxubL7tNmH/ELf0ujVND06ZaFBKfiRzSAgAAV74CAAJfvwA== Date: Thu, 9 Jan 2020 23:07:57 +0000 Message-ID: References: <1576577756-648-1-git-send-email-bernard.iremonger@intel.com> <1578572194-594-7-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E7061153E020E9@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGMwYzdiNzUtZDNkNC00MzgzLWE2ODItYjJmMjc2OTMwOTVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRHp3R3Y3d3ArZVwvakhcL3VcLzl5U2RpMHdjYVJtQUFKYUpGMDNRNmgrUWVYZFhScnJpTCtCWkNJK3NRSjlZSlFGNiJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b116b3f8-5691-4abb-33c9-08d79558c422 x-ms-traffictypediagnostic: SN6PR11MB3261: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 02778BF158 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(396003)(136003)(376002)(346002)(199004)(189003)(6636002)(33656002)(107886003)(81166006)(81156014)(8676002)(4326008)(186003)(26005)(71200400001)(55016002)(7696005)(86362001)(478600001)(316002)(110136005)(9686003)(54906003)(2906002)(8936002)(52536014)(5660300002)(76116006)(66946007)(66446008)(64756008)(66476007)(66556008)(6506007); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB3261; H:SN6PR11MB2558.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YTzZOim+6o+EnOQd2fsX+95dc8U/X6qg54fd2/k533rQgf8xpKrCn5YkPH8zT+hvaEsHHakdSLE3J3JsaoB46qQkrDqORwPUWM16VgjapOhZOdJmpqbJYMooEpPBvOHXPdAG3uK4FA+DwcGEEd/EWPw8hmj90nykI8iCulwGs/yH0iYV3Zr80vlynw9c8+kGTV0aIORCJJsUG5+ngaMpK2yyRqKHaqcjWFuNhbqATlDNZDBpOPThtnWuu7uH81UmeR6JoB71w5AAqa6n7EumgAg/V068U96xQ/Uf36SKyHt1eOzDwlY8fbROihy5L++n6WjuIRcGacErx60VJYs1PcIIvohW7N5ChnHWYudY5xoROGd6vGsd4osHgs3Z6vBmMv4zQgT5Ld7Y23Ieg+gbauOHOo0ZzHpB7AS8W3A2fGl2USX4wggSfnHj+FFlRdgh Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: b116b3f8-5691-4abb-33c9-08d79558c422 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2020 23:07:57.5121 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wFMVgdMTXi93Uwa/8FY0JycQT1zXOyYZVr7Qh3sYliRSiz6ysVQ1egBSy1BJyZeoHJ88vSY5pQG2jTmihHmmKtQM5gllWlP0wXniMF8PYC4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3261 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c > > > > > > Signed-off-by: Bernard Iremonger > > > --- > > > drivers/net/i40e/i40e_fdir.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > > b/drivers/net/i40e/i40e_fdir.c index > > > 3fa6297..78329d2 100644 > > > --- a/drivers/net/i40e/i40e_fdir.c > > > +++ b/drivers/net/i40e/i40e_fdir.c > > > @@ -21,6 +21,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include "i40e_logs.h" > > > #include "base/i40e_type.h" > > > @@ -805,6 +806,7 @@ i40e_fdir_fill_eth_ip_head(const struct > > > rte_eth_fdir_input *fdir_input, > > > fdir_input->flow_type); > > > return -1; > > > } > > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > > > Why we need this? Does this just for debug? >=20 > Useful to see the packet constructed by this function, otherwise no visib= ility on what is happening. > Needed for debug. Then it probably should be called only when some debug option is enabled (either at complie or runtime)?=20 >=20 > > > > Regards > > Qi > > > > > return len; > > > } > > > > > > @@ -954,7 +956,7 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > > > &fdir_input->flow_ext.flexbytes[dst], > > > size * sizeof(uint16_t)); > > > } > > > - > > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > > return 0; > > > } > > > > > > -- > > > 2.7.4 > > >=20 > Regards, >=20 > Bernard.