From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA3DCA04BC; Thu, 8 Oct 2020 23:48:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 308371BB4F; Thu, 8 Oct 2020 23:48:26 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 9E42C1BB43 for ; Thu, 8 Oct 2020 23:48:24 +0200 (CEST) IronPort-SDR: tFHTrAhiV3C3ViO3rnnSJbO4Srnn/uvTBOA4ZzKfMgtmHtu9AQYfsxSTMqzptcIO6pcJLAKCz2 PFVDsaDbP5hQ== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="162772797" X-IronPort-AV: E=Sophos;i="5.77,352,1596524400"; d="scan'208";a="162772797" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 14:48:21 -0700 IronPort-SDR: c6GHDBqnpvKpoFm09Ypd9nBpLAAN5AN9Dcm23sGGRecFzPkifQSXIdqTZVynYQ0H2OYk3iG1wj ew7YaSZfRyLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,352,1596524400"; d="scan'208";a="461954922" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 08 Oct 2020 14:48:13 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 14:48:12 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 14:48:12 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 8 Oct 2020 14:48:12 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.56) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 8 Oct 2020 14:48:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ka/zxehYd5MTFTG5wsndyOZ4+HTtzUX/OeHtfWYN4TiVDUpMeFZww0rJUEF7q56YUU8SqygD4Dg+Xc8xnvlkksUolsoH9w+bkWgTnbFUryoTfqx84u53XQVWhsBHK+Jtk0NfqwA28sqfXH5Cz8tB+49dLhkpN1uQeKsackksTog8dSXFrHWif5G7KtRtsCsxUINV1PLKM5X1n+NjJM1TK2W1f+uqnWgmhJTpRqRBI4anJnocYrT+0ULM+S0uXZ6ulVxpH6msspHRauZmGddTMno0L39Wv91CHX6wyTLt2xHbASthpdCOcyN1kxl4aFe5ArXk0Oj1MoY+5wKXAjzO9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//0jiAOigxC1bAS3LmLxeFhyoOeatD1Nmd5c54sLTWY=; b=XFHjnvJ3JpxGZtJH4+df8ws508I3PQNZN7f69b1OKRmiYaxVNZvCc9YgCHSVSh7mZzSNKKmzfqFZAjUYpsBz4W3WTX8PrMI/mFmN4AUDRel4yf5jyAS8YrhdROAD6WIC7f0iDJ4K2ACVDncIGDL+kJ6HsYN1cFQnvWcfOyniS7DRbkqLaChBlQ9+C11pP9xHzDdsvtRYrXi/2alyiOWn3E0/VaHtIznO4/CEGsG+xp2oHlUMxAnJMV9CuVXKDmiFhMjtbhgauTVPiRNA7OonI3p3U9MUAiADBTILlUdD+S96hStU64c+c8v2b5X+VUO3M2ugC9bNuR1XVRlonB6l/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//0jiAOigxC1bAS3LmLxeFhyoOeatD1Nmd5c54sLTWY=; b=GxpFdHlWEAz7SyI3eA1SG/JmibRS7eQCKKeN6bEhQsoTakmrn/W6y1NJWkVX4xH57yUyC8pS7iLGRQIJObrc1FUK362Lp38OVPafgTlf9sT4H4fUrYJDem+ACy76Xy6sNrzgo6NQdjyl5uXZ3+FiCRICGzK0z+B2qku0UZbHM18= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SA2PR11MB4780.namprd11.prod.outlook.com (2603:10b6:806:11d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Thu, 8 Oct 2020 21:48:11 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a%4]) with mapi id 15.20.3455.024; Thu, 8 Oct 2020 21:48:11 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [PATCH v4 16/22] event/dlb: add dequeue and its burst variants Thread-Index: AQHWiHDgp1t+KixmoEiUEQQupnbmhamOZ21Q Date: Thu, 8 Oct 2020 21:48:10 +0000 Message-ID: References: <1599851920-16802-1-git-send-email-timothy.mcdaniel@intel.com> <1599851920-16802-17-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599851920-16802-17-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aea9851a-7e2b-41f5-ed59-08d86bd3d9e1 x-ms-traffictypediagnostic: SA2PR11MB4780: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wQinDIOV7IHCc9qcxHzmuK7qbOY51peyLFs1XzkT1nXd5Dg4no0fmpG9Y0dwktRxdtWnixN02+OCr8VGi9jmJeLmPHzFNpiUjy+O3dEUh2vjFdcE2zudrdW9rNIAI4Yf55zyUDykh9yNkjaBAWhMVEmlRj/69bl+SbQ/yA+DB96ZVQOrfagE+xY7OiEk44LRapH75joffIsdkJtieqECWoG6Jd7/G6yYJ5eFeqsMfTo8mEEIXdY9xYF003HjMDFMQSgBWQFlTbOZEc7xPpeWVrK5igHY0WZdgiv4c5G+9NekswbfoekpFclK4U5YT/UmCanxtQH4KS/KLsRcMz2S/w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(26005)(8676002)(71200400001)(8936002)(2906002)(6862004)(4326008)(186003)(54906003)(316002)(33656002)(6636002)(5660300002)(9686003)(83380400001)(478600001)(66556008)(64756008)(66946007)(7696005)(76116006)(66476007)(52536014)(66446008)(86362001)(6506007)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: JrrafiVCLBD91G5cWdE/gIk+XFnkVE+3s7fGK0FYm6YrfHSeRv5/mPbxPx1WDjf46zXGBzmFHx1X6Rx6zPFXQktudo4+Fmo5sT5YJRqfX7jMFei7QOkjKKavtK9gVp/vUlz42BWGwSL3bV3wvni5RplQTNg2RRyloDyDBY6kS1b1tZiAdNHBQMsrBZG6B/0g8QCXV/hmUygUqdgH+ZT+LvYimvfIsPWpyp851aEdes14GtFl/KhXN1twSzwVbqRgOWHdbIwnKDP5FmIsKft3FI4mo6d591h9Zk1t1px5DVcidi+Dub7sZJJKeYSssktCT7LJr6GCInjVVOGy3s4R3P88f//qkEpSA7rmVXH1jEOKX+ckueuQjLHHLDWiL4YakY1HwRwaUT7mW37dNL7ykIwjqqacgxvNrk4YBA5aklK4LwpxvVP0E+8aCfLi6L/QuXyhu20s1R/iBLnuk/VX4/6QEzeVZKPCkILL0T8jFFVpbxIr7s1vJVPXecpAJ/dQ1nFGZ1hJO5YU3tZiV6uY5tH0qE3BlJKdfE+bDDgBjo0CdbCqnL+6JY4j5WQ6T5SX5kr3oNvAWw4FOB2JBiyhGo9mg3YfYdyL7YGRGsWrplZ9+waKpp47PZxX0LlCxHq7TiAXopJvk6PUXhGozw916A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aea9851a-7e2b-41f5-ed59-08d86bd3d9e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 21:48:10.9139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AqGK4z/HhmeU9hlCT4ND3AUdbk+Hsn62DqGJlXfHCeMh5zBWkhhz6rZPcsJ2oaScOKKAHX6Z8akFfp5JR1VsLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4780 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 16/22] event/dlb: add dequeue and its burst variants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 2:19 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com > Subject: [PATCH v4 16/22] event/dlb: add dequeue and its burst variants >=20 > Add support for dequeue, dequeue_burst, ... This message could use some more detail. [...] > +static inline int > +dlb_process_dequeue_qes(struct dlb_eventdev_port *ev_port, > + struct dlb_port *qm_port, > + struct rte_event *events, > + struct dlb_dequeue_qe *qes, > + int cnt) > +{ > + uint8_t *qid_mappings =3D qm_port->qid_mappings; > + int i, num; > + > + RTE_SET_USED(ev_port); /* avoids unused variable error */ > + > + for (i =3D 0, num =3D 0; i < cnt; i++) { > + struct dlb_dequeue_qe *qe =3D &qes[i]; > + int sched_type_map[4] =3D { > + [DLB_SCHED_ATOMIC] =3D RTE_SCHED_TYPE_ATOMIC, > + [DLB_SCHED_UNORDERED] =3D > RTE_SCHED_TYPE_PARALLEL, > + [DLB_SCHED_ORDERED] =3D RTE_SCHED_TYPE_ORDERED, > + [DLB_SCHED_DIRECTED] =3D RTE_SCHED_TYPE_ATOMIC, > + }; > + > + DLB_LOG_DBG("dequeue success, data =3D 0x%llx, qid=3D%d, > event_type=3D%d, subevent=3D%d\npp_id =3D %d, sched_type =3D %d, qid =3D = %d, > err=3D%d\n", > + (long long)qe->data, qe->qid, > + qe->u.event_type.major, > + qe->u.event_type.sub, > + qe->pp_id, qe->sched_type, qe->qid, qe->error); > + > + /* Fill in event information. > + * Note that flow_id must be embedded in the data by > + * the app, such as the mbuf RSS hash field if the data > + * buffer is a mbuf. > + */ > + if (unlikely(qe->error)) { > + DLB_LOG_ERR("QE error bit ON\n"); > + DLB_INC_STAT(ev_port->stats.traffic.rx_drop, 1); > + dlb_consume_qe_immediate(qm_port, 1); > + continue; /* Ignore */ > + } > + > + events[num].u64 =3D qe->data; > + events[num].queue_id =3D qid_mappings[qe->qid]; > + events[num].priority =3D DLB_TO_EV_PRIO((uint8_t)qe->priority); > + events[num].event_type =3D qe->u.event_type.major; > + events[num].sub_event_type =3D qe->u.event_type.sub; > + events[num].sched_type =3D sched_type_map[qe->sched_type]; > + DLB_INC_STAT(ev_port->stats.rx_sched_cnt[qe->sched_type], > 1); > + > + DLB_INC_STAT(ev_port->stats.traffic.rx_ok, 1); Move this outside the loop and increment by num rather than 1? > + > + num++; > + } > + > + return num; > +} Thanks, Gage