From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEAE3A04BA; Wed, 7 Oct 2020 22:51:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3621C1B3EF; Wed, 7 Oct 2020 22:51:10 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 06A911B3E7 for ; Wed, 7 Oct 2020 22:51:07 +0200 (CEST) IronPort-SDR: N1JP7VZqN6klSnhPu3FYYPl/YeBwF5g/LN1dKwtSupuqDyKqWGoyWVNxNcOJo1ir3TcFo3pcgA G50fUgobBeUA== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="226750684" X-IronPort-AV: E=Sophos;i="5.77,348,1596524400"; d="scan'208";a="226750684" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 13:51:05 -0700 IronPort-SDR: 4mLqI41eXnYDq5TnzRiqCl98kzwNYRCCh0PTUW5mhHDyXzv7mMBOiqG2TOH2EYLndt4caQxGnf Niy6iyvUQn9w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,348,1596524400"; d="scan'208";a="311923315" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga003.jf.intel.com with ESMTP; 07 Oct 2020 13:51:04 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 13:51:04 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 13:51:03 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 7 Oct 2020 13:51:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 7 Oct 2020 13:51:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R/bqCHQaIQIjat1hSXSx2K/y/DpKC/WFC7zM3g5K3B8KYS9tTxlvRpjkN1gkD6cjLlKVO1QRfMWsRCt7Gf5Q9BYX0T2orhFGBK/a27xRE4Z+OGU1WEC5/s/Ne1YaoUdRwo/lmcnAKGjvf3l5QvJ9RcVwhAN2QKekROMZek5A74c1IkchHFY4eOuR2ad+4YJ2rhCWODIKLly7zBWtVkLLd18wpaKlG3gBB0Q90ekuwN18xr4DgOC404T+IBRZ+Wbt1d7sE7hKMQJYw1yRNqYY4PjQL4DJQvzomVl0TDrPLh0DecOstG9p97wtQ5YmKqdY6Y7TCFlvaVKKqf3oVC7wIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mr84TiLg/lAqzxMFnjGgRSmyjEXZAio5pAL58M+oso=; b=JNyNYUa3d4anTDYqO+MOlriw+lrgDdkq0v/uciFfBdCWlsar4633NtTWUEw09zKnC2SCcYJJjwgLRmuutAP2YqPLGKV4RyRzSY2oZJvLiLHT5rJgeKy/fytCZXpRU0afHvzlusBVRc94GF+lfgUZ6UP/CSbmDfc65flZDhiTBnIsyJGqR2zYZ6Ez9nPQnyZnl7OUUje5eioq4rKMgAErj8CTbRrVQi+429sqLSIrMTBXz/0fRD19xT6xN0mRvPh8iKQ8AoeGzJ0ysdslrkHinFmMMqwoJDBINHn+B9pkVw5mDzmv2ysjeCSi2hhWI+y8RgHcCcVzM1uapqbWwibRIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+mr84TiLg/lAqzxMFnjGgRSmyjEXZAio5pAL58M+oso=; b=yV13iq4TRxaZQ2UgBdOgQxncYOdsYrcc+iJJWzpyx19jH7CQrXqD1EFLO0pwh3piF8NOEeSVCeFfxZq9sMeMV0ZpePt95M8YlAcSRJTxZVqY2Dvdnq/j19UzxGb30WRBRCVzpxjJEW1qzA8M739pJQFPXz0JwBe02ai8QULXA9U= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SN6PR11MB3533.namprd11.prod.outlook.com (2603:10b6:805:cc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Wed, 7 Oct 2020 20:51:02 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a%4]) with mapi id 15.20.3455.021; Wed, 7 Oct 2020 20:51:02 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [PATCH 14/22] event/dlb2: add eventdev start Thread-Index: AQHWiHpfho0JUK7zLEit2z7QUl1j6qmMxD8g Date: Wed, 7 Oct 2020 20:51:02 +0000 Message-ID: References: <1599855987-25976-1-git-send-email-timothy.mcdaniel@intel.com> <1599855987-25976-15-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599855987-25976-15-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe0be997-0937-43b7-509a-08d86b02b3cb x-ms-traffictypediagnostic: SN6PR11MB3533: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xOuDyzRw/ktcC2JYb3d4T7llA3pFPYNCv0jRpiN8LlNKPDc2DEDjxwCHG0wwBIWl0LnD+bd7hYMBkMQqvX+cpka+y1s2QdmeZjtaS4x2dd5x2rWQnwNmSSRVT3jO/QEJx8nMWmIHVuaBF3GIeEkerM5ZhW6CNh+Tc9Hl4jd/Cs306+jqjBZl/Iw50bEUJHh3WoFF/hvVCqXIFfNNbQdxO89jQRcgR3Gj65Ce73JDQqlFh6DrKW03iM60YOO7pootLT7c0ktIOE2WFLAyzbCNOJwfz0uMDgCOQA8sTS3wxhjYAoeueNW4uGggTRZOAVc6Ay2soNbGKgq5hipEq4E6oQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(5660300002)(9686003)(478600001)(26005)(52536014)(186003)(6862004)(86362001)(71200400001)(6506007)(54906003)(6636002)(33656002)(8936002)(83380400001)(2906002)(8676002)(7696005)(66946007)(316002)(66476007)(4326008)(66556008)(76116006)(64756008)(55016002)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: UnUm51pd3nlysPDqp0qZWy/wtsVz6bL5iRjvBRgdZOZmvqkdz6OQI8fyzalMUHNxByMHTIZiThjvH4CC4Dgjc08/lsLzTCLb/eAswZ211Dtgh9q6pX61e/aS4b4jQbBKvNNazpcCcfOhfdrWxQK21+xLxs0Jll0Kkb8Jt9m1bPNvORAy0utBRo5DsZhKPrM07BqZQ+jcLOIOE6haKUlLAPnEguT+T7m3I2l7g1HyVH68tMG/O+3LfGf879sJB13dd1dJEVbYNs1PAUEK+6yE9+nx+8Ptl0xoXuEwnE74y7oHO1rH4RWZ6BigywWL0Fv3MWDuuMPDP7yj/TLxzf4SjoKSxOnQA34SzGg0omZso2Q8bk7pCjn9gIuaafcmql67z9v9RtcvI1+RjMGE0scgbbMeJfEKORS+8TiKTo/AsstLL/5orfsLuVvlhK+m7xsSNWGHVCjUpcE2IrdeZBknZx0194I5X9nTP3OEvlisWR9/UDG4TDn5Dm/EwLNfQnzzZ8zpQ4ohWqkxwg3qPY2aIQdgLW+UyjMdy+8pYtjXHPDGHTVVBKA/+q84CSVFsrZ2TyiUdNiIlu8ndjeNl4YVEC6LiRvJinoCG6c2NIlJu9lEROgJ9o8ec2CWGKesX/1onqheG2UVgp2r48D/JShhTA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe0be997-0937-43b7-509a-08d86b02b3cb X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 20:51:02.1888 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GImU6o9FOVpbOkFljVEvOH9nT9bccZX9Mg8qCr55NmUU3N6zrxM2KVDQk23zWZPvke6h5bXhXe8AKXypTsqCjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3533 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 14/22] event/dlb2: add eventdev start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com > Subject: [PATCH 14/22] event/dlb2: add eventdev start >=20 > Add support for the eventdev start entry point. >=20 Code looks fine (one whitespace nit below), but it could use a more detaile= d commit message -- e.g. describing how the PMD delays port links until eventdev start time, how the configuration will be reapplied at this time i= f this is a reconfiguration scenario, etc. [...] > +static int > +dlb2_eventdev_start(struct rte_eventdev *dev) > +{ > + struct dlb2_eventdev *dlb2 =3D dlb2_pmd_priv(dev); > + struct dlb2_hw_dev *handle =3D &dlb2->qm_instance; > + struct dlb2_start_domain_args cfg; > + int ret, i; > + > + rte_spinlock_lock(&dlb2->qm_instance.resource_lock); > + if (dlb2->run_state !=3D DLB2_RUN_STATE_STOPPED) { > + DLB2_LOG_ERR("bad state %d for dev_start\n", > + (int)dlb2->run_state); > + rte_spinlock_unlock(&dlb2->qm_instance.resource_lock); > + return -EINVAL; > + } > + dlb2->run_state =3D DLB2_RUN_STATE_STARTING; Looks like there's a tab between run_state and the equals sign. Thanks, Gage