From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50C99A04BA; Wed, 7 Oct 2020 23:55:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E1CD1B694; Wed, 7 Oct 2020 23:55:20 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4E6424C9D for ; Wed, 7 Oct 2020 23:55:18 +0200 (CEST) IronPort-SDR: 5d1icXeer9H3RNC3HSmg8sRCvcYfp8S5Z/m2EfGaW3XUwxizScXLXCuizvYiKNVIVcgATtm/sz RZM6OnRGSgiw== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="152077905" X-IronPort-AV: E=Sophos;i="5.77,348,1596524400"; d="scan'208";a="152077905" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 14:55:16 -0700 IronPort-SDR: vHFQwZWlPPLAXwwSoVRt391sjY59tU+FXrx+ooXAJ9mJp0UsQbspw8TRpc4/iunUJct+QRhX4k c4KKiXos1iuA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,348,1596524400"; d="scan'208";a="528184375" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga005.jf.intel.com with ESMTP; 07 Oct 2020 14:55:16 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 14:55:15 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 14:55:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 7 Oct 2020 14:55:15 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 7 Oct 2020 14:55:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9GIzIuRGNtUQErASCH38pYc75/HttlemkC5apyYFeo+icRFRpS7LK5HDsD2V+rG3QyIArh3HESvm+iNITfYqZAipTqLwfdTGRF3tbr5miQqf3p3oPdDvN3C2z70i2FIvMepTKhZ9MOPj6ZhVi0LesHlU9v4j0jUufZARRldnKYIU6X+S5bEfRzCgIA9E+wladwm89lr0csr4yYRdW22/Czkv+BTbsYEZVezPRFMFDbDYf10iSMPWmesv0Z0jBd2L7MPn+Y0BpWD6GPYI1XUWUej266FZgpkZQjSIEozvSgqX5QpmgWhhzqhjYLM3rGzR1vM8HetwTCDHbtwJnU5yQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+642WJ4Bf5rKRsmCiuud+AToKAkkg1L4OLyTu42K7g=; b=HWwRUXafDFfMQGbGX9HK7lUADuL3UnXLz+k/LOXdmVVor5DWtMrkszrG1gdk27NBt5k8pUUml8v6Oze2m9KJrXFjJX/4TKGh4hv7Ou2QKPTEVfbFNHKqjQE4KoCixaxG1AlL7wOdzlPqRfl4cfYJ2cD5zwudZxI1L8hc6CUgfMH9zbx845IhDiRYT4PIlw3c3R0gHioPT8LUgNqfXDxrYivkwcIJZznQm22Oi2axofUY7M+fppFL7NENY5BvNnL8dK/+fnGzB8DtaFkqTY7NL7bGN0Wp8Xi8kr0Rvc3c4ljuU9MGEzFmJ8PpF55ZKPr25CWe95ce4K35zs2y6aHFEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+642WJ4Bf5rKRsmCiuud+AToKAkkg1L4OLyTu42K7g=; b=cgImAIX24qxuNtwojsaXqNhWxtj+doed+cT9T5h+JLwFCpTjiQ3fbXkVAvCyd1qNxQEGfPtgnthUdjjfAi7uhLPLh40D8FeWLMNmwLSSR+Ucrq+h2ezs+EMJ3e5qrul4nl19xKnq8AN6M3mcl+Wn4GjgVKAtWlxnscbG/E48oGY= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SA2PR11MB4905.namprd11.prod.outlook.com (2603:10b6:806:117::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Wed, 7 Oct 2020 21:55:14 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a%4]) with mapi id 15.20.3455.021; Wed, 7 Oct 2020 21:55:14 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [PATCH 20/22] event/dlb2: add queue and port release Thread-Index: AQHWiHpl34iad9Y3qUyc+McL5UN9nqmM1hUQ Date: Wed, 7 Oct 2020 21:55:14 +0000 Message-ID: References: <1599855987-25976-1-git-send-email-timothy.mcdaniel@intel.com> <1599855987-25976-21-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599855987-25976-21-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8b177b49-cbd9-4c28-42ee-08d86b0babda x-ms-traffictypediagnostic: SA2PR11MB4905: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iY+9P8Ubib1bVp+P0ksJgzyHCEu4rwZ/ka1qEB4MoLJT8yvjZAU/uQtv/ddUmGxEXyC1WFyp6+MXFF3d69Nl/74cCpsXHnHPLrEhzCCjpX8Gst//LiKWtUa9zq59NUdF6pEYmSZXiRMrz7j/01L/mLW8MTslpB1JuovgMfwqthx3cNjEGCxJfLH7/QBk97GyrxW1E0MxTe4t6iimcAhFNaboxHM87Zrm4atXTtatJTNiwWEGJOA4hmn6bhOqi7YmiBpCR1bnmHD682yENBK7FO4fJxzqbbvFbUyNNu2uM5XUDxCj2mwwarxAzu/k9TeDpSmEuY8Liq7JDdkf2vRqew== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(39860400002)(136003)(376002)(316002)(54906003)(71200400001)(7696005)(478600001)(26005)(186003)(86362001)(6506007)(4326008)(52536014)(6862004)(5660300002)(66556008)(66446008)(9686003)(8936002)(64756008)(2906002)(55016002)(76116006)(66946007)(8676002)(33656002)(66476007)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 10jt5KcoSCbxCmVgvO1NtB6sndqZt0DOLmwr4TdX2F2m/F3rwAE+QTWQvfXvLuutf9vkeF9SPMUJRnUkIOC3rTU3gtEAAci2HRp4WGK2yfC9ZhfStd3j9wfttVKTdEMdA38orvAnhinDxtOwxJopKQaYXkQsLTCMwBj99gtwEkEHMnVcdSjzXzKD2mYBpmNiZ4uAyaHhmdY7nLUB1aPfth/yWcx7n0PcOloWOwkDUJqloP/a5cj+XKMRvcI4LNCPuinfNuh8wy3rE1iZJCXgJxaWWZRoIpkO5Aapz1goBWyy3hsjpEEcVosTJMMRnSDNjdd2eoNLd/5dpqCpGMffWMxNt8zi7p0mg8PoxUQeSmYii91mRliKLXFLl9uTNBehaWiYfULzrxdTyh1LksVaIyAoyDFpREpf9vUeNlvMuNRI7iXQZSE7gXYA/VWlEGnp9eGdf9FqXdAcCEGnEPLIrrw9OTTqGN91DRjokyzBIDTLu0UXvAHiz91qPh1mv0UMCVheQWfE6lqVb9tv3gLa77T6Gj4fq2ZkjEmLMWsTqxR/rb6Kmd5b+HPls5sj95oRSuSvzvik2bzvd+KYIlZPrn6okSh9PKZLLogEJR2PzeTP9iljcFoRvoHQlb9iQIVjfaOnuUIjuGUEYjaLXPYOkQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b177b49-cbd9-4c28-42ee-08d86b0babda X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 21:55:14.3905 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2AEaFj2zoAjBPnA6eCE6ksXFXeGWXzSxRU80/EWXdTrNP1eM+uOxjqQIvoBqQOh2GJTg72+vno7sYVliustkQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4905 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 20/22] event/dlb2: add queue and port release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > static void > +dlb2_eventdev_queue_release(struct rte_eventdev *dev, uint8_t id) > +{ > + RTE_SET_USED(dev); > + RTE_SET_USED(id); > + > + /* This function intentionally left blank. dlb2 does not support > + * reconfiguring individual queues or ports -- the entire device > + * must be reconfigured. > + */ I think the 2nd sentence in the comment need to be reconsidered (or just removed). The release callbacks are called (for every port and queue) when rte_event_dev_configure() is called a 2nd/3rd/etc. time to reconfigure the device, and the callbacks give the PMD the opportunity clean-up the individ= ual port/queue. Implementing the logic can be useful for entire-device-reconfiguration. > +} > + > +static void > +dlb2_eventdev_port_release(void *port) > +{ > + RTE_SET_USED(port); > + > + /* This function intentionally left blank. dlb2 does not support > + * reconfiguring individual queues or ports -- the entire device > + * must be reconfigured. > + */ This might be the appropriate place to free each port's memzone (see my comments in patch 11). Thanks, Gage