From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E560A04D8; Mon, 21 Sep 2020 19:16:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 112561C1FB; Mon, 21 Sep 2020 19:16:36 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BC7BB1C1D4 for ; Mon, 21 Sep 2020 19:16:34 +0200 (CEST) IronPort-SDR: 3gcgmMpFtOhqwnXTEVQDsai02Nrdnxp8EXEzRfUfrYNOpq4SE+B6q6cvueGDaaBAJIdjJ0b4R/ aPvbRzem6DrA== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="139926437" X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="139926437" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 10:16:33 -0700 IronPort-SDR: YOvyagaEs/ItnBx5efEVRleVO2yBF1h/WyCDEgK+bc0u3mvcL6m5xpXJzJlWA7/C28Av9WUFv3 EiqGhCr8lXKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="309144927" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 21 Sep 2020 10:16:33 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 10:16:33 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 10:16:32 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Sep 2020 10:16:32 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Sep 2020 10:16:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NaRh2dyGVPipNB4WFVS/7WCYzcee4ytSsGGifzCnXZ2/704kJzbBGf2SnynyEYhwGs4kV7ZpgKbPFz0ealZ1U8lVpxgTZ7o+WoajvVUn0U4nXprn39iwucTdWlh+1fc0qcevQLE1dMClXhtqb6btWHZfQw6F86ebApLhlUbg/4opij4kaFTboUVT5ef2c3yW8t5upL8gWXMBtie4D0l821E2oOYaK8gzndVxtwT/BnpqF/N+HL6XDClg29G/U0fk2/O9D3BdvvhPL6FM0XxoDRgyJx4VBKiThXiHYkZORWDrSuqs1KnIBW3juzqqIZqcmq+GhE1/1LlRwMGLMMOsNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4oBvDIJRXUfnnLo0ICYeMJrr1gLpTXWTRufl+3Au2A=; b=TRFXyE4YiHwuTyTaeFPoqnZ3nCb6U3vhk6Boe+1LB+ODsPpLAuyRQblkEfex3rnFqTjQfAeh6zO0RYkLjVj6nJwjQ+5jp0YKBeyoS2fcj4ud4TEFSaq3rjW5r4BbWMmCDmc/jQ7V+yC/8k8jNvhYz7d4OikmLd+f4gc2/AIJIvNRKJi0mN14kb0TSxMlJgrCOFCGyZLnw51ahf0Qr6jQbU7ppTfzPKThLS/QgwnQh4vO0xiofkyj130QUoiT3lEJGctulX2cOV/EFsULBpSQmxdSwCXZ0vyDXs0Bmv6wZt1MKcjKngjUGfSSNUwokA+fT66HS5s/TcnBtms6dCLBRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4oBvDIJRXUfnnLo0ICYeMJrr1gLpTXWTRufl+3Au2A=; b=KYnFLhPFVqxGH31NIAJtVtwVbI40p11ZKgEdzc35iBfqBfbO40mPIHSbf3mnQk2W4fSZFdQEIO0PwQ7RrvOdZ2Lh8lWL6tRFZejan7J7tlVGn9tKAI3vxQcN94j7qP1QDrKj7gKyHsDIjuL//sk+lJsafkIS+eiY1u53I3x+Krg= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SN6PR11MB3295.namprd11.prod.outlook.com (2603:10b6:805:c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Mon, 21 Sep 2020 17:16:30 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::54:b143:c75e:41bd]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::54:b143:c75e:41bd%7]) with mapi id 15.20.3391.026; Mon, 21 Sep 2020 17:16:30 +0000 From: "Eads, Gage" To: Steven Lariau , Olivier Matz CC: "dev@dpdk.org" , "nd@arm.com" , "dharmik.thakkar@arm.com" Thread-Topic: [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas Thread-Index: AQHWiFCehJBfEj0aZEKGK9LFFVwZn6lzTyMg Date: Mon, 21 Sep 2020 17:16:30 +0000 Message-ID: References: <20200911152938.8019-1-steven.lariau@arm.com> <20200911152938.8019-2-steven.lariau@arm.com> In-Reply-To: <20200911152938.8019-2-steven.lariau@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2a10285-8be9-4b2b-fb1a-08d85e52152b x-ms-traffictypediagnostic: SN6PR11MB3295: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k73PtDIAyh4tzSexDgl9bue9vX++MHJoRiNEGF2whss/MtVebNPyot3VOyhflMrJWH4zQEei9EjakM8bG4YJ95KXF1brpzNmjQuB/YF4DFYnlvDIcK4AuDCGJs7KnBsVIrvVLXGyqcOxWv6QBUAfIm9dE+YUJ1n/JbLx8iqSe10oe0aFL7IjS0KsKc/E3vW1kBr/FA2efCgnuBzC7vOoDFSyb8rtAPcJ+Jgoqewe5Xv91oD51vNaF3WnHww1rk5C9AJSxPYzhBwxUSaFwC40PUKqeuiv2ZDQNQRMhC+Df2ww/dHcT4tqUPN7ve060xmy3o7jB3ku77C9QjfU8HCoaNayDE3nKmRMynAauH+uv4cW1a0dXzjvLFv4dJRb2PgP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(52536014)(2906002)(8936002)(33656002)(8676002)(110136005)(54906003)(478600001)(71200400001)(64756008)(66556008)(66476007)(5660300002)(9686003)(83380400001)(66446008)(186003)(86362001)(4744005)(316002)(6506007)(53546011)(55016002)(26005)(7696005)(66946007)(76116006)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: iPbQXFCFMiCoxGI6YwQMIeTt/a/f3fT5OaOxi2uVR4pNkMjXhkRcoeOiNX/OTnhzOBmpOPh3QnzNoNcMRp+o/Gd15FFa9krzi4/Ya719U0JWt4uGItUnC5D3/sgJaXoupd8Yh23C+bwUuvhg3DB80UJgA9hh/yqnKsbbVwOfbdYz0pjtk4dZcHCqa/dvpTjPl6PlaMpYwQG41Oi9rXh/Lgep0qEf+ZosMxIQCTXYJ2JfEMbCY5bVfhWZoCuR03X3GsYw4pYQQoEnMq9Mj+4sdtTYhKrMUy6PPOonZph2i2xAjr18ntuc1PMuKab9qfRvS2JOUuCaUy7P2t4Ztbiv7+eBHgL9M+qBhKBqKMMpWY1j5ntdPfMUYePs18+amQErXRXYXb8gyiXpo+9co3CBDen73eE4baYIxTmEDR2ob1kq9aJWEnwQwDE7BQ4P6YIf2i8kLyfX8n7rzo0NYAz1xlvy9+lMJMoavbeFq1gqY6rpVIACHjjIIjonvpZggX2SFLZI4vw4fPcEV6hPdR1hHmEUWfSguhm6YZrZmIaz8xIL1FmuylltUYyB594CSgHah4+echR1EJPBtxsayIjXIbAoVwmwl04l+vrTFXXs+7lMVYcW/d/+nldLdB+U3d0gPsP5i0nYwu+SPe9QPbpE/Q== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2a10285-8be9-4b2b-fb1a-08d85e52152b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 17:16:30.7079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GvZFhbO2j1iCrkY2oRkPkzeDmRRPelz0Uur6k9l/GtqWycnega84Ngpyt+g1RL0bOYUcFCRKauZcdf/P3BnLZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3295 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; nd@arm.com; dharmik.thakkar@arm.com; Steven Lariau > > Subject: [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas >=20 > Fix cmpexchange usage of weak / strong. > The generated code is the same on x86 and ARM (there is no weak > cmpexchange), but the old usage was inconsistent. > For push and pop update size, weak is used because cmpexchange is inside > a loop. > For pop update root, strong is used even though cmpexchange is inside a > loop, because there may be a lot of operations to do in a loop iteration > (locate the new head). >=20 > Signed-off-by: Steven Lariau > Reviewed-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang Acked-by: Gage Eads Thanks, Gage