From: "Eads, Gage" <gage.eads@intel.com>
To: "Kinsella, Ray" <mdr@ashroe.eu>,
"McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Neil Horman <nhorman@tuxdriver.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function
Date: Wed, 14 Oct 2020 15:37:21 +0000 [thread overview]
Message-ID: <SN6PR11MB2574D3F4642D4AD0F797BFDCF6050@SN6PR11MB2574.namprd11.prod.outlook.com> (raw)
In-Reply-To: <43309420-fbf8-1b7f-5e18-67f9661159e6@ashroe.eu>
> -----Original Message-----
> From: Kinsella, Ray <mdr@ashroe.eu>
> Sent: Wednesday, October 14, 2020 4:31 AM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>; Jerin Jacob
> <jerinj@marvell.com>; Neil Horman <nhorman@tuxdriver.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>
> Subject: Re: [PATCH] eventdev: add PCI probe named convenience function
>
>
>
> On 12/10/2020 19:42, Timothy McDaniel wrote:
> > Add new internal wrapper function for use by pci drivers as a
> > .probe function to attach to an event interface. Same as
> > rte_event_pmd_pci_probe, except the caller can specify the name.
> >
> > Updated rte_event_pmd_pci_probe so as to not duplicate
> > code.
>
> Any reason why this couldn't be __rte_internal then ?
On a related note...should a static function defined in an internal header file
be included the version.map file? Doesn't that only pertain to symbols in the
.so? Probably harmless if so, but now may be a good time to correct it.
Thanks,
Gage
next prev parent reply other threads:[~2020-10-14 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 17:04 Timothy McDaniel
2020-09-14 20:22 ` Eads, Gage
2020-09-16 18:39 ` McDaniel, Timothy
2020-10-12 18:42 ` Timothy McDaniel
2020-10-14 9:31 ` Kinsella, Ray
2020-10-14 15:37 ` Eads, Gage [this message]
2020-10-16 11:26 ` Kinsella, Ray
2020-10-12 19:01 ` Timothy McDaniel
2020-10-13 18:47 ` Jerin Jacob
2020-10-14 17:35 ` [dpdk-dev] [PATCH v4] " Timothy McDaniel
2020-10-14 21:41 ` [dpdk-dev] [PATCH v5] " Timothy McDaniel
2020-10-15 14:16 ` [dpdk-dev] [PATCH v6] " Timothy McDaniel
2020-10-15 18:49 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2574D3F4642D4AD0F797BFDCF6050@SN6PR11MB2574.namprd11.prod.outlook.com \
--to=gage.eads@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).