DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev]  [PATCH] log: remove unneeded log type declaration
@ 2020-07-06 13:08 jerinj
  2020-07-06 18:10 ` Eads, Gage
  0 siblings, 1 reply; 3+ messages in thread
From: jerinj @ 2020-07-06 13:08 UTC (permalink / raw)
  To: dev, Matan Azrad, Viacheslav Ovsiienko, Jerin Jacob,
	Kiran Kumar K, Nithin Dabilpuram, Nipun Gupta, Hemant Agrawal,
	Gage Eads, Olivier Matz, Adam Dybkowski, Sachin Saxena,
	Akhil Goyal
  Cc: thomas, david.marchand

From: Jerin Jacob <jerinj@marvell.com>

RTE_LOG_REGISTER macro already declares the the log type.
Remove the unneeded log type declaration.

Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")

Reported-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/vdpa/mlx5/mlx5_vdpa.c  | 1 -
 lib/librte_graph/graph.c       | 1 -
 lib/librte_rawdev/rte_rawdev.c | 3 ---
 lib/librte_stack/rte_stack.c   | 2 --
 4 files changed, 7 deletions(-)

diff --git a/drivers/vdpa/mlx5/mlx5_vdpa.c b/drivers/vdpa/mlx5/mlx5_vdpa.c
index a60fc4ef0..9bb462e95 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa.c
@@ -48,7 +48,6 @@
 TAILQ_HEAD(mlx5_vdpa_privs, mlx5_vdpa_priv) priv_list =
 					      TAILQ_HEAD_INITIALIZER(priv_list);
 static pthread_mutex_t priv_list_lock = PTHREAD_MUTEX_INITIALIZER;
-int mlx5_vdpa_logtype;
 
 static struct mlx5_vdpa_priv *
 mlx5_vdpa_find_priv_resource_by_vdev(struct rte_vdpa_device *vdev)
diff --git a/lib/librte_graph/graph.c b/lib/librte_graph/graph.c
index baa383cd7..7224b00a7 100644
--- a/lib/librte_graph/graph.c
+++ b/lib/librte_graph/graph.c
@@ -18,7 +18,6 @@
 static struct graph_head graph_list = STAILQ_HEAD_INITIALIZER(graph_list);
 static rte_spinlock_t graph_lock = RTE_SPINLOCK_INITIALIZER;
 static rte_graph_t graph_id;
-int rte_graph_logtype;
 
 #define GRAPH_ID_CHECK(id) ID_CHECK(id, graph_id)
 
diff --git a/lib/librte_rawdev/rte_rawdev.c b/lib/librte_rawdev/rte_rawdev.c
index aec61f425..2eb7b3bc3 100644
--- a/lib/librte_rawdev/rte_rawdev.c
+++ b/lib/librte_rawdev/rte_rawdev.c
@@ -34,9 +34,6 @@
 #include "rte_rawdev.h"
 #include "rte_rawdev_pmd.h"
 
-/* dynamic log identifier */
-int librawdev_logtype;
-
 static struct rte_rawdev rte_rawdevices[RTE_RAWDEV_MAX_DEVS];
 
 struct rte_rawdev *rte_rawdevs = rte_rawdevices;
diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c
index e4c0ce131..8a51fba17 100644
--- a/lib/librte_stack/rte_stack.c
+++ b/lib/librte_stack/rte_stack.c
@@ -17,8 +17,6 @@
 #include "rte_stack.h"
 #include "stack_pvt.h"
 
-int stack_logtype;
-
 TAILQ_HEAD(rte_stack_list, rte_tailq_entry);
 
 static struct rte_tailq_elem rte_stack_tailq = {
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] log: remove unneeded log type declaration
  2020-07-06 13:08 [dpdk-dev] [PATCH] log: remove unneeded log type declaration jerinj
@ 2020-07-06 18:10 ` Eads, Gage
  2020-07-07 11:14   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Eads, Gage @ 2020-07-06 18:10 UTC (permalink / raw)
  To: jerinj, dev, Matan Azrad, Viacheslav Ovsiienko, Kiran Kumar K,
	Nithin Dabilpuram, Nipun Gupta, Hemant Agrawal, Olivier Matz,
	Dybkowski, AdamX, Sachin Saxena, Akhil Goyal
  Cc: thomas, david.marchand

> Subject: [dpdk-dev] [PATCH] log: remove unneeded log type declaration
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> RTE_LOG_REGISTER macro already declares the the log type.
> Remove the unneeded log type declaration.
> 
> Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")
> 
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Gage Eads <gage.eads@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] log: remove unneeded log type declaration
  2020-07-06 18:10 ` Eads, Gage
@ 2020-07-07 11:14   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-07-07 11:14 UTC (permalink / raw)
  To: jerinj
  Cc: dev, Matan Azrad, Viacheslav Ovsiienko, Kiran Kumar K,
	Nithin Dabilpuram, Nipun Gupta, Hemant Agrawal, Olivier Matz,
	Dybkowski, AdamX, Sachin Saxena, Akhil Goyal, thomas, Eads, Gage

On Mon, Jul 6, 2020 at 8:10 PM Eads, Gage <gage.eads@intel.com> wrote:
>
> > Subject: [dpdk-dev] [PATCH] log: remove unneeded log type declaration
> >
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > RTE_LOG_REGISTER macro already declares the the log type.
> > Remove the unneeded log type declaration.
> >
> > Fixes: 9c99878aa1b16de2 ("log: introduce logtype register macro")
> >
> > Reported-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>
> Acked-by: Gage Eads <gage.eads@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-07 11:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 13:08 [dpdk-dev] [PATCH] log: remove unneeded log type declaration jerinj
2020-07-06 18:10 ` Eads, Gage
2020-07-07 11:14   ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git