From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7799A052A; Wed, 27 Jan 2021 13:19:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC7BE140D02; Wed, 27 Jan 2021 13:19:05 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id C052E140D02 for ; Wed, 27 Jan 2021 13:19:03 +0100 (CET) IronPort-SDR: bGeSZ5TGFGPtBn7nJyDs/fXpZ1+Vj3cZCJo+/2rwFM7r1X1asFJhaclhGIjNIfsVzmS5uQuBZ3 5FruY6d+I2yg== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="176549076" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="176549076" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 04:19:02 -0800 IronPort-SDR: QK/dy831fqoK+1BwVgTmf+ftdYJo8K94/WBIPieSFNpyRhIRlhKxYs9dL2nm18ebPdb2c+fT9y V/674lY5UWhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="353793176" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 27 Jan 2021 04:19:02 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 27 Jan 2021 04:19:01 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 27 Jan 2021 04:19:01 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 27 Jan 2021 04:19:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dnIuwDrFOJcUNGnSCbJ2x7bqZWOP91aFpNXQhGyWIUJszUzyhIgqDe/WzZUHpjgQ2u4bGliBz5jjUSoJWqOL8T06O1hBAp+PJZGENCaDMCt7SkUmvmvyMJPv2P/iyoX+BWSc8bs8XgCKkTgfCS0oNGL4LNjgevnAiE8neztVQ5DjGl4C8GS3tGtsJJHhIi2UWg8atFiCqRZhnoGJnbcRO4t78Wk/j4TQNVSqQpgRbnjz++Tl1Hg5+PAeq09w5R5mt7KCWdRsHwRmbIbgVEb+Kw8JYAszAhbxJ4CD6FnJeH5cbgfoojaldG7piKsWgpl4RROVLWqM0fxz5eWMVeLdRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m6oIzXkySBlBz1pxia6e0tb2Z3fxMAiOA7DZHOpWhms=; b=mP3R8gx7KN+S3iPpmup59i3dC1iqJz0hm5mR/Gv/ZXDF0mHW0ecFWVy6XgjRKMEt9MJe7RcViLrXW5PJaPle701WTo8WYvmOMMnUqjTcy3TK/o1nyt1+WwHW4S9bAiJJ1uNQJNUKIUFuxSslo12jLGro5t32F0crPReamnPiAhsrHYXiwpVfK+P/Oyw4UTWzHIg+7SndnFaYw4A6XE00Qo2QIueA+2rhHinhB3dLDJuo7DZPK9+256TfQkv9wwFxN9n5gUjsBGKzMePGx7HJw3Bbp2H7idiIzZakBhNoBZLAmJMmKv1ni9rRrsoK3JiM3rZMmIKbYOcdGsAWbZvzcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m6oIzXkySBlBz1pxia6e0tb2Z3fxMAiOA7DZHOpWhms=; b=EHJrYAroMLnQWcUnrOsDCFdQdEeInR3tB7uu8l7UKBuTckatJpYDjcAIdHV6gl9xTK7SimbJ5pjgUHuOpoNQs7kjJzXUGlL9BhQo+DQ5byEQ61jNQV0QBQEarosjmw9HjwODeyhjvqp0wsaX9nNU5JMj25doZTg8Sr2/qLX08mc= Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15) by SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12; Wed, 27 Jan 2021 12:18:59 +0000 Received: from SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::70a0:3c2b:45d9:fa0]) by SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::70a0:3c2b:45d9:fa0%4]) with mapi id 15.20.3784.017; Wed, 27 Jan 2021 12:18:59 +0000 From: "Rong, Leyi" To: "Richardson, Bruce" CC: "talshn@nvidia.com" , "Zhang, Qi Z" , "Kadam, Pallavi" , "Yigit, Ferruh" , "Menon, Ranjit" , "Xing, Beilei" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error Thread-Index: AQHW9IwjFNBuy9tSjUSy2xezlLEY5qo7SJKAgAAZUTA= Date: Wed, 27 Jan 2021 12:18:59 +0000 Message-ID: References: <20210126153819.63625-1-leyi.rong@intel.com> <20210127084745.73116-1-leyi.rong@intel.com> <20210127084745.73116-3-leyi.rong@intel.com> <20210127104031.GA1626@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210127104031.GA1626@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: afda134a-3fbe-4d7d-9ac0-08d8c2bdba0a x-ms-traffictypediagnostic: SN6PR11MB3101: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HpfLbF7x0DmkG9J1kFNXykEYrNn+RY4h5lG2R4ZUIZSyC5Cc9kLKOtosVchqmAHJMGNtaW5Q5AWBszTIcWOW4n/aqCcZppboewEXkRyy/xuXJvG6aMJF+uc/Im57Go/0ftRl8dqxvqe3u2FKnYh9tHFZBdv63szzt4chdEOZWbty36uUTARRzhdvoITvr0/P7LgXED+XhQvf5j3zifKTAP2KYaOOp80iRyuoNjczqczsbOjYAj6+W+SGda8ExuNZB0Lsyj/ceEnnP/cVwwY6BtPjGJ6xUEKorhoxPu6pKRJNCtIzrA9SBuKXEJxqR23Gg9fWOPQOeo3PzEzr7XJvf9rkOVjP03TE2/vbQWcjPeJsY6DWDdQU8WRaix8FXcGYh3OHMT3F1PFJLx5RICb8b1AKVgu6qafU+hwq//iHw/q+fg++PKy/HvV9U4pQnXxZQkNm5hXruvyPGQruDlo6CUyVNbu+EKWXXOoqcttKWahn4rweFObk6RlsGKeux31+3hvbUNpHoJPysRdhaE4xRg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(136003)(366004)(376002)(9686003)(7696005)(33656002)(55016002)(2906002)(54906003)(86362001)(6636002)(52536014)(6506007)(53546011)(83380400001)(6862004)(4326008)(26005)(186003)(478600001)(8676002)(71200400001)(66556008)(5660300002)(66476007)(64756008)(66446008)(66946007)(316002)(8936002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?24STNX8uE5DHVH7uIgalLu6KmDqF2ihrwvuSIt+T6VCieRFdggPz2IeC8kXI?= =?us-ascii?Q?APVkpn3UE+xWHqpVARBZzg5Jnbv5n5NwZI3/QjUJPqAK4NlWtMFJHXu15VId?= =?us-ascii?Q?6llZSdAVM+1eU3g9W4z394gjDWok1eHr0IkHSBNhtmVLeOr1k1QT9wDOhbTu?= =?us-ascii?Q?oBrGiNJLUSFOjC9NKWycFmGFNDES2EfahxezczikVsVT6L0fGle3mn5cLuTG?= =?us-ascii?Q?vQHFMKh7IKumB7Y2qXNnCALaw48YphLKUaTA+DeKM7X2HqgRXqK3UcqQadDF?= =?us-ascii?Q?lK4yN780v9UoaYJ5lobgS0VCu+bwLlhK31LjMaUNBp2l9jaoZ/pqhv8hHZl7?= =?us-ascii?Q?tPYwn28yYzCzzPyVfLviVcgqpDrYZlporZX3VADLbdhg7yH+1dWcjAZofO03?= =?us-ascii?Q?rh8TJzOyQ49x19dT+fiX4vdNcryVH8f3dvFhC+0iCZxnBafD/7WeNZ3MONwb?= =?us-ascii?Q?nUdrJRtJ7KPfdTyX0GeY4vpRw8t9ZLd+hn7xrlHQWsn4m0HOiX4WdNkGG3D9?= =?us-ascii?Q?Gcz/Pu2hxFB1u8qs3qdtyx4C/134u6oHdCh7sw83AUOVofSJAfR5oFtpTJtG?= =?us-ascii?Q?UweeiK+qsAWzUaNpEMSbOTmvXxn3gZbNLNPCc3CS8FByXSBkN1T+RbnWYDU2?= =?us-ascii?Q?/6VmyYkIIjhOcR65eLq4YRb0nrphmzoCq8O6OE7gqXx2hvF5U1fWWSmRt8/s?= =?us-ascii?Q?n4RXOz+5je0gOYd282GO3+y7HlZTF/EhDssZs/DhOF1OpZToidtLVuNSDgAn?= =?us-ascii?Q?At3cyIPhVFLqBS1cbcsoDF291oWODBlDGqlDBjpOnrfLdABQVGylpWeVCZds?= =?us-ascii?Q?wa20EFlT4kWGtSyNLwX9xZkKuJR9mW0CzWFpwGBLEDavsJz1t33gNeJnew1Y?= =?us-ascii?Q?2//XAOGvTzqk1pNQBMJRyLdR9TNPYpIy4BFV0x3E593AiqP6gHL+ejMbB9kk?= =?us-ascii?Q?NhsaluecEFFbyKxZcLn/tdqgrApMR4V1jLFOC2JWVWx7TqTRDU+SEekWzlro?= =?us-ascii?Q?o1CuB8DnI/KRavGhqO4T3wCxNgE95KfO7I6iEFyT9VVlJocSLcTUF5fXL4Nr?= =?us-ascii?Q?YEBu644s?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2621.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afda134a-3fbe-4d7d-9ac0-08d8c2bdba0a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2021 12:18:59.7260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n4rkP1KPDFs/3DwfI0hDF6Hx15f2B2hgNqLBXv7UAdJ+KpXFuJyaHYPcegdJb84bvMxUJAYf0+0BjPDDrBMVLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3101 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Wednesday, January 27, 2021 6:41 PM > To: Rong, Leyi > Cc: talshn@nvidia.com; Zhang, Qi Z ; Kadam, Pallavi > ; Yigit, Ferruh ; Menon, > Ranjit ; Xing, Beilei ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error >=20 > On Wed, Jan 27, 2021 at 04:47:45PM +0800, Leyi Rong wrote: > > Disable i40e avx512 code path for windows build to avoid the mingw > > build error. > > > > Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path") > > > > Signed-off-by: Leyi Rong > > --- > > drivers/net/i40e/meson.build | 26 ++++++++++++++------------ > > 1 file changed, 14 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/net/i40e/meson.build > > b/drivers/net/i40e/meson.build index c0acdf4fd4..34c9dfa681 100644 > > --- a/drivers/net/i40e/meson.build > > +++ b/drivers/net/i40e/meson.build > > @@ -54,19 +54,21 @@ if arch_subdir =3D=3D 'x86' > > cc.has_argument('-mavx512f') and > > cc.has_argument('-mavx512bw')) > > > > - if i40e_avx512_cpu_support =3D=3D true or i40e_avx512_cc_support =3D= =3D true > > - cflags +=3D ['-DCC_AVX512_SUPPORT'] > > - avx512_args =3D [cflags, '-mavx512f', '-mavx512bw'] > > - if cc.has_argument('-march=3Dskylake-avx512') > > - avx512_args +=3D '-march=3Dskylake-avx512' > > + if not is_windows or cc.get_id() =3D=3D 'clang' > > + if i40e_avx512_cpu_support =3D=3D true or i40e_avx512_cc_support > =3D=3D > > +true >=20 > Rather than changing this whole block to indent it further following the = new > condition check, I think a simpler fix might be to insert: >=20 > if is_windows and cc.get_id() !=3D 'clang' > i40e_avx512_cc_support =3D false > endif >=20 > just after the initial assignment to i40e_avx512_cc_support. [Alternative= ly, you > can include those conditions in the assignment itself, but it's probably = more > readable done separately as I show above.] >=20 > /Bruce Agree, seems clear to put the logic block separately. Thanks~