From: "Rong, Leyi" <leyi.rong@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix offload flag checking in simple Tx datapath
Date: Tue, 11 May 2021 08:08:55 +0000 [thread overview]
Message-ID: <SN6PR11MB26218E4EC805504FBB74C0B0EC539@SN6PR11MB2621.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210511023926.27296-1-alvinx.zhang@intel.com>
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Tuesday, May 11, 2021 10:39 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Rong, Leyi <leyi.rong@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/i40e: fix offload flag checking in simple Tx datapath
>
> Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6,
> PKT_TX_OUTER_IPV4' are supported in simple datapath.
>
> This patch removes these offload flags from packet checking in simple Tx
> datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK and
> I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK.
>
> Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx datapath")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> 02cf5e7..337916b 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -72,6 +72,15 @@
> #define I40E_TX_OFFLOAD_NOTSUP_MASK \
> (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
>
> +#define I40E_TX_OFFLOAD_SIMPLE_SUP_MASK ( \
> + PKT_TX_IPV4 | \
> + PKT_TX_IPV6 | \
> + PKT_TX_OUTER_IPV4 | \
> + PKT_TX_OUTER_IPV6)
> +
> +#define I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK \
> + (PKT_TX_OFFLOAD_MASK &
> ~I40E_TX_OFFLOAD_SIMPLE_SUP_MASK)
Hi Alvin,
Better to use ^ oprand here, think about the situation when setting a flag in I40E_TX_OFFLOAD_SIMPLE_SUP_MASK but not in the PKT_TX_OFFLOAD_MASK, the result is going to be unexpected.
> +
> int
> i40e_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond *pmc)
> { @@ -1501,7 +1510,7 @@
> return i;
> }
>
> - if (ol_flags & PKT_TX_OFFLOAD_MASK) {
> + if (ol_flags & I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK) {
> rte_errno = ENOTSUP;
> return i;
> }
> --
> 1.8.3.1
next prev parent reply other threads:[~2021-05-11 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 8:58 [dpdk-dev] [PATCH] " Alvin Zhang
2021-05-06 5:32 ` Zhou, JunX W
2021-05-10 3:27 ` Rong, Leyi
2021-05-11 2:39 ` [dpdk-dev] [PATCH v2] " Alvin Zhang
2021-05-11 8:08 ` Rong, Leyi [this message]
2021-05-11 8:45 ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2021-05-11 9:20 ` Rong, Leyi
2021-05-12 8:48 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB26218E4EC805504FBB74C0B0EC539@SN6PR11MB2621.namprd11.prod.outlook.com \
--to=leyi.rong@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).