From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D1B3A0531; Wed, 29 Jan 2020 11:22:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E07C1BFD6; Wed, 29 Jan 2020 11:22:02 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 890871BFD3 for ; Wed, 29 Jan 2020 11:22:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 02:21:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,377,1574150400"; d="scan'208";a="229575676" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga003.jf.intel.com with ESMTP; 29 Jan 2020 02:21:59 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jan 2020 02:21:58 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 29 Jan 2020 02:21:58 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 29 Jan 2020 02:21:58 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Jan 2020 02:21:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jm8bq7JmPIIo9x9PHNPPFiMQwVxeExUleW43GAWfBr4whvIz02+GLHhNCN1WvM0tqQ/0OFey13dWfYdyKqutEH2PC3QsRirjiIHa5zED4kiZW7f/T3MuH8At0Ns3iUOgxfRVuzPtTozA3HIPbK8zRBPpd78rFoskJRvxjADhf0KWKkZhTU0CoIc+Dup+2DBA62lTIO6tdf+BrF4JZOEZON1Hy7Y+QP/C9Gk56Cffr7CCYCmAnNNSnUWgKYmNiAhTS7d5b1I5yB1GYJzur5Zm95k4nEE0ShpUvaQi2fSORePvkR6ayIGaJgEfJHsLna9TFxr6IN/83fYvKM7W7RU9YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJUPWWAQrVQIJa8mPB7iEdMBZhC5a/fBVP6+q70Ie6E=; b=cMbbj7Ko+S/+aJSxQxULZTZlPLNb+HFiX6T2RLzx+kZgGWTS/5u+X9i+AZuKBQ32j5iMGAlWMCjqqYipNzousx4Hu2FrczbVLT3LBMz7hTXaQAJcbYYZyVNtK+nrTPI9eujuxxC4dUgtTcSXWklWX4J8VDDdXCTCaiVrkxrXROQCEU6mNU0nKkCStOxmqQzf9yi8v4VP8lO9vDyuScvG5ALNsAN2YqxfidRp9ljYU0I/vuLxwu0iMaTLxBb3HpXMepJb6rcXszESBdsqWLv9IaQZLhZJCt2siyq+Jhdvkng+gq7G9UpHfurNkIfOrS7SMrDz4D7HOj/Rukw8IP3JjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJUPWWAQrVQIJa8mPB7iEdMBZhC5a/fBVP6+q70Ie6E=; b=Tv+letlfnfKJPEDFVAzz1NDYBgTLpRGRgtG4Rac2MQcAcYdrrSa8b9GB6fnLrw24eBMFhdYW5YTAcCAVm27gDNyti3j5w+cl9vgF1sPU+q475h59Z4O5MssmYfIPi0q3lqPQteQikMSA5kVL8333pCW6ed2aWcU3cW3YtxmjkSM= Received: from SN6PR11MB2622.namprd11.prod.outlook.com (52.135.91.31) by SN6PR11MB2799.namprd11.prod.outlook.com (52.135.97.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Wed, 29 Jan 2020 10:21:56 +0000 Received: from SN6PR11MB2622.namprd11.prod.outlook.com ([fe80::d149:ac01:a9:58ce]) by SN6PR11MB2622.namprd11.prod.outlook.com ([fe80::d149:ac01:a9:58ce%6]) with mapi id 15.20.2665.026; Wed, 29 Jan 2020 10:21:56 +0000 From: "Zhang, Roy Fan" To: Maxime Coquelin , "dev@dpdk.org" Thread-Topic: [PATCH] example/vhost_crypto: fix incorrect fetch size Thread-Index: AQHVpD9+A9QzLT4p7E6sqojPBuZzYafqMfyAgBeg4tA= Date: Wed, 29 Jan 2020 10:21:56 +0000 Message-ID: References: <20191126095410.72395-1-roy.fan.zhang@intel.com> <3ca778f2-eee5-bcf2-61bc-cda6e7271dcb@redhat.com> In-Reply-To: <3ca778f2-eee5-bcf2-61bc-cda6e7271dcb@redhat.com> Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzNhYTc5OWQtMTYyZC00NWE3LTgxYzUtMzE2Y2E2ZDE0Nzc0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiamtWb3BKXC9YXC9vTjk1Wkw5dXJzYkQyWG5Mb3BZMW50dTlTbTlTZ3Y2WEU3UlBIalhcL0Nvc1wvNEtzMCt0TkFcL0pEIn0= x-ctpclassification: CTP_NT dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=roy.fan.zhang@intel.com; x-originating-ip: [192.198.151.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 72104c61-87cf-46bf-a420-08d7a4a5117a x-ms-traffictypediagnostic: SN6PR11MB2799: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(396003)(39860400002)(346002)(136003)(376002)(199004)(189003)(2906002)(316002)(110136005)(5660300002)(6506007)(966005)(76116006)(7696005)(33656002)(53546011)(186003)(52536014)(64756008)(66476007)(66556008)(66946007)(66446008)(55016002)(26005)(9686003)(81156014)(81166006)(86362001)(478600001)(71200400001)(8936002)(8676002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2799; H:SN6PR11MB2622.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IJBsdsaTmNotsTCcgdIP4J1UYN2WmK5aeAtszUAEUJH1nSTXLE+VVTo0e2zNYf/QFAWKBNSnF2x4uRB2XIqrCdVvg+abJCASohSIbCMFSu8w7c8yZrEwoKkabw7M5pWRsZ6dfe0Kpbfv0Fm5w2VLb+k/w4F/813F6bZdc9FsdhcaS9+J5ZSApBRwlSXApCVRSZSImq9aS0a+L6MKYxIGTikjFapvcbn/HoB6t28vWCK3ITeQHWcgb5Vs3yKIjn5n72o7mRYEjXIhKdG2Ez6aSJUcQshgMFwnIv325yyaKP9+YWt2bjYg4UdVt1r4qbB7VfXL9NsKwDDE8gSKlOmKquQM9HNtBMn5FHOhJR3Wo8BIWma21dD79AtSBE37gdYn0VeOfPZkHhHqEAio/z//m84ajVHcQ0BmR29/s2x9PsKilACwxzhzQrUw9ZVmyEIAr4PUUg6zdH92h/h7f5AnFoYxEVvzEiZ5NB6fSHq60z4ZmuhUgI73YfQgTrRONnwGXoPTgh+jRdlrXC4vYUtQSw== x-ms-exchange-antispam-messagedata: HKhxQHa6svATAJFVg5JysthLph9zKaBe1Z4w3+4/uxb/ThFzii49g7QbH4usU9j/ytgXTBN69oU5+4k1GXi8k8yKgTJKi+F/q7PyLuYYPN/gUGGNM3/zcSZkKNwwIlyoBDvL14TCcYoXhHAsLv1eEw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 72104c61-87cf-46bf-a420-08d7a4a5117a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2020 10:21:56.4974 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O9O+34LPhVxLiXenTnYSl8ZpjKfeXhNOU5vRbn7BeaEQZaYdXPtWqB51Aug6Y6oB3/WR2H1xbe8TDS8ORu8F6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2799 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] example/vhost_crypto: fix incorrect fetch size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime, Sorry for the late reply. This patch is incorrect. I have sent the correct version http://patchwork.d= pdk.org/patch/65302/ Regards, Fan > -----Original Message----- > From: Maxime Coquelin > Sent: Tuesday, January 14, 2020 9:30 AM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: Re: [PATCH] example/vhost_crypto: fix incorrect fetch size >=20 > Hi Fan, >=20 > On 11/26/19 10:54 AM, Fan Zhang wrote: > > Coverity issue: 343401 > > > > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") > > Cc: roy.fan.zhang@intel.com > > > > Signed-off-by: Fan Zhang > > --- > > examples/vhost_crypto/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/examples/vhost_crypto/main.c > > b/examples/vhost_crypto/main.c index 1d7ba9419..5d80bcaca 100644 > > --- a/examples/vhost_crypto/main.c > > +++ b/examples/vhost_crypto/main.c > > @@ -387,7 +387,7 @@ vhost_crypto_worker(void *arg) > > continue; > > > > for (j =3D 0; j < NB_VIRTIO_QUEUES; j++) { > > - to_fetch =3D RTE_MIN(burst_size, > > + to_fetch =3D RTE_MAX(burst_size, > > (NB_CRYPTO_DESCRIPTORS > - > > info->nb_inflight_ops)); > > fetched =3D rte_vhost_crypto_fetch_requests( > > >=20 > Could you please add a commit message to explain the change? > With just the patch context, this fix looks weird. >=20 > Thanks! > Maxime