DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Timothy Redaelli <tredaelli@redhat.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10
Date: Wed, 5 Feb 2020 14:21:38 +0000	[thread overview]
Message-ID: <SN6PR11MB2717DB4D76A1A89FCECC2A5EEB020@SN6PR11MB2717.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5de9fca287dbda831bbe11e34ecf89631e3a812f.1580911676.git.tredaelli@redhat.com>



> -----Original Message-----
> From: Timothy Redaelli <tredaelli@redhat.com>
> Sent: Wednesday, February 5, 2020 2:12 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; david.marchand@redhat.com; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10
> 
> GCC 10 defaults to -fno-common, this means a linker error will now be
> reported if the same global variable is defined in more than one
> compilation unit.
> 
> Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark")
> Cc: cristian.dumitrescu@intel.com
> Cc: stable@dpdk.org
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> 
> v2:
>     app is already declared as extern in main.h. (as reported by David)
> 
> ---
>  app/test-pipeline/config.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c
> index 28ac9fcc0..33f3f1c82 100644
> --- a/app/test-pipeline/config.c
> +++ b/app/test-pipeline/config.c
> @@ -42,8 +42,6 @@
> 
>  #include "main.h"
> 
> -struct app_params app;
> -
>  static const char usage[] = "\n";
> 
>  void
> --
> 2.24.1

Yes, app is declared in main.h and defined & initialized in init.c, no need to have it defined the second time in config.c.

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>



  reply	other threads:[~2020-02-05 14:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 13:47 [dpdk-dev] [PATCH 0/3] examples: " Timothy Redaelli
2020-02-05 13:47 ` [dpdk-dev] [PATCH 1/3] examples/vhost_blk: " Timothy Redaelli
2020-02-05 15:12   ` Maxime Coquelin
2020-02-05 14:12 ` [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: " Timothy Redaelli
2020-02-05 14:21   ` Dumitrescu, Cristian [this message]
2020-02-05 17:05 ` [dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: " Timothy Redaelli
2020-02-05 17:05 ` [dpdk-dev] [PATCH 3/3] examples/qos_sched: " Timothy Redaelli
2020-03-04  9:37 ` [dpdk-dev] [PATCH 0/3] examples: " David Marchand
2020-03-04 10:17   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2717DB4D76A1A89FCECC2A5EEB020@SN6PR11MB2717.namprd11.prod.outlook.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=tredaelli@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).