DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "O'loingsigh, Mairtin" <mairtin.oloingsigh@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"O'loingsigh, Mairtin" <mairtin.oloingsigh@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256
Date: Mon, 16 Mar 2020 17:42:06 +0000	[thread overview]
Message-ID: <SN6PR11MB2847802481B26D5055C5E36D84F90@SN6PR11MB2847.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1583313952-9660-1-git-send-email-mairtin.oloingsigh@intel.com>

Hi Mairtin,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Mairtin o Loingsigh
> Sent: Wednesday, March 4, 2020 9:26 AM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256
> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> ---
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index d8609ad..110f1f1 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -314,8 +314,8 @@
>  				.block_size = 16,
>  				.key_size = {
>  					.min = 16,
> -					.max = 16,
> -					.increment = 0
> +					.max = 32,
> +					.increment = 16

Since this is going to be available in release 0.54, you should add a check for the version,
so IMB_VERSION_NUM > IMB_VERSION(0, 53, 0). Otherwise, key_size.min = max = 16.

Thanks,
Pablo
  


  parent reply	other threads:[~2020-03-16 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04  9:25 Mairtin o Loingsigh
2020-03-04  9:25 ` [dpdk-dev] [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test vectors Mairtin o Loingsigh
2020-03-16 17:42 ` De Lara Guarch, Pablo [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-04  9:17 [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256 Mairtin o Loingsigh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2847802481B26D5055C5E36D84F90@SN6PR11MB2847.namprd11.prod.outlook.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=mairtin.oloingsigh@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).