From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7EC8A04B3; Tue, 28 Jan 2020 11:50:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0ABD91C214; Tue, 28 Jan 2020 11:50:04 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 95A2C1BFFE for ; Tue, 28 Jan 2020 11:50:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jan 2020 02:50:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,373,1574150400"; d="scan'208";a="261390816" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 28 Jan 2020 02:50:00 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jan 2020 02:50:00 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jan 2020 02:49:59 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Jan 2020 02:49:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ms1I1rtBdRy/wjaahV7QLbiyvQ46e5Z+aKYnnatlXS3F3ECNx4kale4kQO1uui/Z7aaiAuYc6QyoBqczPxIYdwJ8HIii13BnJwAa0s0RVg5YRoWl0KCq66ejLg3Yph3Se22/GsDNgUUiCnuU5cRIufqSIOZM/zRbxuJX0dUWlRjX/S7AskioKs582SRtDktHRUivBhD/wFCReUR5s2DbVB6AodDQGYY1Qyyomo51/0SF91k1o1BP7qif7R6u8bpW8JePrZHQhe3K4Ff0C4Gk9B/tBVidNd4tS7MtG4Jqnjq5zc2DEZ/cu2LwqFxoaBs2x3Nw7QPHGrlZs2LPNM507g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RWON4A6+SmHCGk/1GeT6SZupN22vf2SmGnhm6/xS1Bk=; b=C8a6coyrY2gj8iZYHNVOuoHVRPsV3K0zKsS+4rZ9wVTvlsudN3gXXcbbdXLlVW3G+q4Iod4oNHFvC7mbTA9X0+okQevuoruQ0OpvTngbjlqveOr2lyRuFN1JTgAGlwOxcmpXAHX4puIW6jPabOWU/Ams4/Bc/1jrN1lUukMIbK8C8iFtBJ0AbgkRKlFvdCtPesk/p57UrQsjocfDmSb2K5+YnO6sdy7XLOH9rTSX9e7aJd0VUdQT0gSnVPPWlDTuMczw6FV2gFAiM4MwUKIt+pAV0GSB9FPfV81K58A456P95SApzKIzXCeFtucgsOMazPeE0mCM2xPGH8d03TfS6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RWON4A6+SmHCGk/1GeT6SZupN22vf2SmGnhm6/xS1Bk=; b=JTEcP+/hBxAw9mzRMQUqkNbiWtFf02qPxB/BElKx6wVkSEY8oM4sCLpCcHrkQDXTs79MeDIPVtkWs5uo2kL2kgu7d5wANaxWNyolZG99uveTrm7pHqVYcnjDmeGt444ubjY25rUUHXc4hq5reNvmYZaE08S9IED5q9LZg4nJFIw= Received: from SN6PR11MB2847.namprd11.prod.outlook.com (52.135.90.31) by SN6PR11MB3423.namprd11.prod.outlook.com (52.135.127.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.19; Tue, 28 Jan 2020 10:49:58 +0000 Received: from SN6PR11MB2847.namprd11.prod.outlook.com ([fe80::3053:f119:eadf:6c7a]) by SN6PR11MB2847.namprd11.prod.outlook.com ([fe80::3053:f119:eadf:6c7a%7]) with mapi id 15.20.2665.026; Tue, 28 Jan 2020 10:49:58 +0000 From: "De Lara Guarch, Pablo" To: "Smoczynski, MarcinX" , "akhil.goyal@nxp.com" , "Ananyev, Konstantin" , "Zhang, Roy Fan" , "Doherty, Declan" , "Nicolau, Radu" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support Thread-Index: AQHV1YnNEn/ySjAo5ke5lRN31C6nV6f/yoIA Date: Tue, 28 Jan 2020 10:49:57 +0000 Message-ID: References: <20200115182832.17012-1-marcinx.smoczynski@intel.com> <20200128031642.15256-1-marcinx.smoczynski@intel.com> <20200128031642.15256-3-marcinx.smoczynski@intel.com> In-Reply-To: <20200128031642.15256-3-marcinx.smoczynski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTM2NDUyYWEtZGU5Mi00MjZiLTkzMjMtZjY5ODEwYzhmZDBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWW1DdUd3V2p1V01RemUwQ1dPNjdJOUNoVkVwUnFTZW03c1p5WWFRMXFWWXhXbmR0Sk1uYmNKUE5POEJuS1RqWSJ9 authentication-results: spf=none (sender IP is ) smtp.mailfrom=pablo.de.lara.guarch@intel.com; x-originating-ip: [192.198.151.180] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7763f345-7e34-4ed8-77cf-08d7a3dfd159 x-ms-traffictypediagnostic: SN6PR11MB3423: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:972; x-forefront-prvs: 029651C7A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(376002)(346002)(39860400002)(396003)(366004)(189003)(199004)(26005)(7696005)(53546011)(186003)(4326008)(71200400001)(55016002)(2906002)(76116006)(9686003)(110136005)(6506007)(66476007)(66446008)(64756008)(316002)(66556008)(6636002)(86362001)(66946007)(33656002)(478600001)(52536014)(5660300002)(8936002)(8676002)(81166006)(81156014)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB3423; H:SN6PR11MB2847.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PwGGuVRZlYbp7qQXQxq6iluIIdO5/SqpHmscKvsbdVbJa4yYA0t7kKugid0GvSu+T/X/G4x4auLTmL+DqRjFSzQMPoPtU3Nsvj/10HOsL4150pwzWU7mA/mr0EJcKqT03vrC+EwK8DaGPMYH9Ufxjncia3xQJV3NhpeudX9/1XVr2M28v8brJvoiXFkG0R1H70YDqM0B2dyjb6Oi+JgxPyAraP6RCeyb9s8v6Pk4CSoiABuk70ySu8Kx9DLz75NmcvoldT6msnyrqUo8nxApOpp8lNZcLNf8BBIumyGC2fFZj2u+iLzezFLH7CcxIPAKsPNS3zUOJFvXGDG7qc0NDfPwD9HDBT6RT2lMZ1oXrRRUUy7lj+SlrnXUC63mDujyMFYOa/Tb4f8ejMWY8dFZ2UuHQYU8HS0Rvu7sAOqeTSP8IrUwz0fv0CCcO5QBM/vfdx1v864kDhi7uF+QoM4yiii1rwTG5eeROltjtYlfJJUNqF+0NTMlCpEixU8uwLW2 x-ms-exchange-antispam-messagedata: pGWpyYrwxyUjM5kLRelOotlsnR0cj4JX9l+FUHE8E6KTBbC82VV+eKCOcFnV+0/V9IESlT1/41mpB2IlTmEHO/cJCYtFDEWDbq2hKrtadfIucJ3FfllchkFf2mIj4oPlMMpc6CNxlDEBtaBhsC47kQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7763f345-7e34-4ed8-77cf-08d7a3dfd159 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2020 10:49:57.9841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ESaWIDRujzFaE9ymNFoRwmFPLaaMRKOW8/H2aSHAF+gOgLSsQH8IZwgu3Vue2X6YoFi6cpkB0cVrwC4tQR5y7heWVNTrTWYUWxUw8p1r3mE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3423 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Smoczynski, MarcinX > Sent: Tuesday, January 28, 2020 3:17 AM > To: akhil.goyal@nxp.com; Ananyev, Konstantin > ; Zhang, Roy Fan ; > Doherty, Declan ; Nicolau, Radu > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Smoczynski, MarcinX > Subject: [PATCH v4 2/8] crypto/aesni_gcm: cpu crypto support >=20 > Add support for CPU crypto mode by introducing required handler. > Crypto mode (sync/async) is chosen during sym session create if an approp= riate > flag is set in an xform type number. >=20 > Authenticated encryption and decryption are supported with tag > generation/verification. >=20 > Signed-off-by: Marcin Smoczynski ... > @@ -331,9 +331,12 @@ struct rte_cryptodev_ops aesni_gcm_pmd_ops =3D { > .queue_pair_release =3D aesni_gcm_pmd_qp_release, > .queue_pair_count =3D aesni_gcm_pmd_qp_count, >=20 > + .sym_cpu_process =3D aesni_gcm_pmd_cpu_crypto_process, > + > .sym_session_get_size =3D > aesni_gcm_pmd_sym_session_get_size, > .sym_session_configure =3D > aesni_gcm_pmd_sym_session_configure, > .sym_session_clear =3D aesni_gcm_pmd_sym_session_clear > }; >=20 > struct rte_cryptodev_ops *rte_aesni_gcm_pmd_ops =3D &aesni_gcm_pmd_ops; > + Minor thing, but you should remove this blank line. Apart from that: Acked-by: Pablo de Lara