Re: [dpdk-dev] [PATCH v2] examples: add multi process crypto application

["Trahe, Fiona" <fiona.trahe@intel.com>]

Hi Akhil, Arek,

> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Friday, July 3, 2020 8:48 AM
> To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Burakov,
> Anatoly <anatoly.burakov@intel.com>
> Subject: RE: [PATCH v2] examples: add multi process crypto application


////
> > Shouldn't this be part of examples/multi_process?
[Fiona] Yes, good idea - we can move in there.
(pending agreement on another comment below)


> > Can we split this patch in some logical way so that it can be reviewed easily?
[Fiona] yes, patch will be split in v3

> > What are the expected results out of this app. Can we have some logs in this
> > doc?
> [Arek] - yes we will add (soon we will send v3), example output would look something like that:
[Fiona] I agree it would be good to have expected output, but think there's too much noise in 
pasting in the whole output. I'd suggest to trim to something like:

Scenario: enqueue only in primary process, dequeue in a secondary
Commands:
 - Xxx primary
 - Xxx secondary
Expected output will include text like:
On Primary:
    > USER1: - Starting PRIMARY process
    > USER1: - Configure Device id 2
    > USER1: Created qp 1 on dev 2
    > USER1: Initialized session = 0
    > USER1: Initialized session = 1
    > USER1: Configuring vector 0, using session 0
    > USER1: Start enqueuing packets on dev 2 qp 1
    > USER1: Enqueuing / (liveness symbol keeps changing until Ctrl-C is input)
    > USER1: STATS: Enqueued on dev 2 = 16337024
On Secondary:
    > USER1: - Starting SECONDARY process
    > USER1: Found Device id 2
    > USER1: Found qp 1 on dev 2
    > USER1: Start dequeueing packets on dev 2 qp 1
    > USER1: Dequeuing / (liveness symbol keeps changing until Ctrl-C is input)
    > USER1: STATS: Dequeued on dev 2 = 16337024
Note, the STATS will be in sync if the process enqueuing is stopped before the process dequeueing, in other cases they may differ.


> >
> > This multi process app is only taking care of  crypto queues while others are
> > for NICs.
> > Is it not worth to have crypto+NIC multi process app instead of this app?
> [Arek] - initially main purpose was to check PMD behavior when:
> 1) configure cryptodev, sessions, queues and do enqueue/dequeue from another different processes
> 2) run enqueue/dequeue from different processes on the same queue pair.
> If it can be done with one app I think it is ok.
> > I believe most common usecases of crypto are with network traffic.
> > Can we modify l2fwd-crypto for multi process?
[Fiona] Yes, it would be a good idea to do that sample app too.
However this app allows standalone validation of cryptodev lib and PMDs,
running in multiple processes, without introducing dependencies on
ethdev APIs, traffic generator, NIC, etc. I think this is useful as is.
One consideration is whether it would be better to treat this as a test tool
and move to the test directory - as you're right, it's not showing
a typical complete application, just allowing to play around with the crypto part.
My preference is to move to under the examples/multi-process, but up to you.