From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] cryptodev: add function to check if qp was setup
Date: Thu, 11 Jun 2020 13:42:32 +0000 [thread overview]
Message-ID: <SN6PR11MB2880243C397057F364F6106AE4800@SN6PR11MB2880.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200610185308.15220-1-arkadiuszx.kusztal@intel.com>
Hi Arek,
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday, June 10, 2020 7:53 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; arkaduszx.kusztal@intel.com
> Subject: [PATCH 1/2] cryptodev: add function to check if qp was setup
>
> From: Fiona Trahe <fiona.trahe@intel.com>
>
> This patch adds function that can check if queue pair
> was already setup. This may be useful when dealing with
> multi process approach in cryptodev.
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.c | 28 ++++++++++++++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev.h | 14 ++++++++++++++
> 2 files changed, 42 insertions(+)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
> index e37b83a..705387b 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -1080,6 +1080,34 @@ rte_cryptodev_close(uint8_t dev_id)
> }
>
> int
> +rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t queue_pair_id)
[Fiona] This should be marked as experimental & added to map file
> +{
> + struct rte_cryptodev *dev;
> +
> + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) {
> + CDEV_LOG_ERR("Invalid dev_id=%" PRIu8, dev_id);
> + return -(ENODEV);
> + }
> +
> + dev = &rte_crypto_devices[dev_id];
> + if (queue_pair_id >= dev->data->nb_queue_pairs) {
> + CDEV_LOG_ERR("Invalid queue_pair_id=%d", queue_pair_id);
> + return -(ENODEV);
[Fiona] -EINVAL would be more appropriate here
> + }
> + void **qps = dev->data->queue_pairs;
> +
> + if (qps[queue_pair_id]) {
> + CDEV_LOG_INFO("qp %d on dev %d is initialised",
[Fiona] This and below should use CDEV_LOG_DEBUG
> + queue_pair_id, dev_id);
> + return 1;
> + }
> +
> + CDEV_LOG_INFO("qp %d on dev %d is not initialised",
> + queue_pair_id, dev_id);
> + return 0;
> +}
> +
> +int
> rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
> const struct rte_cryptodev_qp_conf *qp_conf, int socket_id)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
> index 4aaee73..d01a658 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -727,6 +727,20 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
> const struct rte_cryptodev_qp_conf *qp_conf, int socket_id);
>
> /**
> + * Get the status of queue pairs setup on a specific crypto device
> + *
> + * @param dev_id Crypto device identifier.
> + * @param queue_pair_id The index of the queue pair to check.
> + *
> + * @return
> + * - 0: qp was not configured
> + * - 1: qp was configured
> + * - -ENODEV: device was not configured
> + */
> +int
> +rte_cryptodev_get_qp_status(uint8_t dev_id, uint16_t queue_pair_id);
> +
> +/**
> * Get the number of queue pairs on a specific crypto device
> *
> * @param dev_id Crypto device identifier.
> --
> 2.1.0
prev parent reply other threads:[~2020-06-11 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 18:53 Arek Kusztal
2020-06-10 18:53 ` [dpdk-dev] [PATCH 2/2] cryptodev: add cryptodev trace in multi process function Arek Kusztal
2020-06-11 13:45 ` Trahe, Fiona
2020-07-04 20:08 ` Akhil Goyal
2020-06-11 13:42 ` Trahe, Fiona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2880243C397057F364F6106AE4800@SN6PR11MB2880.namprd11.prod.outlook.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).