From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84987A0526; Wed, 8 Jul 2020 16:10:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C12061DB1F; Wed, 8 Jul 2020 16:10:18 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 22E001DB1F for ; Wed, 8 Jul 2020 16:10:15 +0200 (CEST) IronPort-SDR: OVumP2jsyD4RwFk5Nf2QyIgICwNKqG33IZ4QnBojTM9u7Q+8R+XY9Gg3qyuCxFE8D5gpzUZ8wB CGQrOtXaGf2w== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="146867241" X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="146867241" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 07:10:14 -0700 IronPort-SDR: D2KUB6F21pM4XPWvJtqtjuuXKhxeLBqa23kMi3OL+jpA2Q/pw99l6IBdq2qY9EKmkToIetcHfR TbS8eUzCQLsw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,327,1589266800"; d="scan'208";a="358112940" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga001.jf.intel.com with ESMTP; 08 Jul 2020 07:10:14 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jul 2020 07:10:13 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 8 Jul 2020 07:10:13 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 8 Jul 2020 07:10:13 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jul 2020 07:10:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QULno2Myt4iuAKQsICdCuSn5cM3v002f2qVmlNGGuz6k3jfm60VIJAk6c6mF9litrSmPLwgCW3lnyPbTi/Dcc3cJtfkR6jHav9y63gDGcugDV+SUXHfMmosIUN6pq5hLCTgkHNuDJZ9fSuYgHobZ/XxnejZOloQE9BKktn7f2qhqiBZ4heG6qTCoM5+ieKtDliNsGajVtugAqWjEx+1PlmuIVR/hUo5fiVr2mkbxN68uGVHqcj5zyh5ysC/rAyEt2kJtnJAJzvizE8TU58z9ak6mOFZLUTJYQSsrZGknpxH0+QWHAjausNIA9jVVGIZp3UVHm1q7RhXqLfPQD/iVNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLfS5710C1vaB4VaSsG0i20NA4XDpDGz5OEu/nsIvy4=; b=Wmc+j2et19HvXkoeHTo5Qsde7nI6Z1OROEg9ZIf3AWAQjX005qXGRAUieFyoaSK5AOCbGQpSrM9Uk9i3k/CUH7OH+g493M8wJDR2QOGr/1y+9EhF6onVL+h3I97tBpIsIpV50hSCDSiUG4U1uT7kN9N6jzS3GfzJ23zb2cLoQHjwLpOEX/5AIAImFQI7EWEzFKLh9hl16m6W5RiGBimt1Fi+jPTYx2NweUeI9CCC9U79VofDkytsepKbCoxbYzaJmN0Kuha6T4nhBXYK/2TuemvTXYhUTAJftbspc86N6N2hf+5d+srPIbAhZMUTsvz3bs2uQmBEsKsKvU5WlmxX1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLfS5710C1vaB4VaSsG0i20NA4XDpDGz5OEu/nsIvy4=; b=FNrVXxSBn+7wvDh1G5Q8SUiUEO1BqtdnF5Zy76izZiBIP/fJFVX3eKnAYsN55RZM1XBuoonwA7HJjpkivGrCfZKLJK+meolTQDgOzjOjEsHDPwm6kcPL/wfFszg79BjQ2aK3hujwysoBSHvTetqvk2Z9VfjLnJefXiD1nl+QsT0= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SA0PR11MB4526.namprd11.prod.outlook.com (2603:10b6:806:96::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.23; Wed, 8 Jul 2020 14:10:06 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::ec8b:8f35:800d:13f4]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::ec8b:8f35:800d:13f4%3]) with mapi id 15.20.3153.031; Wed, 8 Jul 2020 14:10:06 +0000 From: "Trahe, Fiona" To: Thomas Monjalon , "akhil.goyal@nxp.com" , "Kusztal, ArkadiuszX" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Richardson, Bruce" , "orika@mellanox.com" , "jerinj@marvell.com" , "stephen@networkplumber.org" , "olivier.matz@6wind.com" , "hemant.agrawal@nxp.com" , "mdr@ashroe.eu" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp was setup Thread-Index: AQHWSjOgoIOtJdI4ikyzq9+AM3Ya5Kj9xYMAgAABCOA= Date: Wed, 8 Jul 2020 14:10:06 +0000 Message-ID: References: <20200624142653.16488-1-arkadiuszx.kusztal@intel.com> <1939387.ZpZeW6HBnj@thomas> In-Reply-To: <1939387.ZpZeW6HBnj@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.191] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e68ba22b-e4d2-4e35-539f-08d823489db2 x-ms-traffictypediagnostic: SA0PR11MB4526: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 04583CED1A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: D069d+dgfy3M5oGHNznKCoka8F+viVlVlQjJCAk23pSIshzvvODc7UpeIugVZ9DwZfi5NLaRSpI3jjjJ2XoE/bi5PZS0tx4twYpEQaG1Ys9a6dHz01TO/M5F/+al4s1iLzSbB5KNUFcsOWg/kLJp1+HC9csJfMwwihXM5pMy7uTtsv9Yo6KjF/+4Syvck2lkFN5bkqQNkR+3a5NKLXGSsYL2H2CUshOvMss2izJRCtej5SQCZyGCHfeQFYYPXyb2ouO0s4qoqsinvvyjVyng7ELMgoV6n7XSOw+hNhRvj9NQctMqEikS3VZGppp0BVhWSNK0c/QvvwBU8TPuo7NiQ5x1Ah+XurK6qespE44lM/ltj76YInRkZ2ga7htHqqoAibNL988K4glVJM/0f4eyvg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(107886003)(9686003)(316002)(26005)(83380400001)(55016002)(33656002)(478600001)(8936002)(186003)(2906002)(71200400001)(6636002)(66446008)(8676002)(110136005)(5660300002)(64756008)(66556008)(53546011)(7696005)(52536014)(6506007)(966005)(86362001)(76116006)(54906003)(4326008)(66476007)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: SHZKDCJgD6Fas0IpaKPYVS4qXZgGB/o8o1qZxmNi/HwswiXa7Y0C+yXm2tdugM5rJOpfvKfTbsI8u37aGlrZxkrMVu8/avVcLmGVahC5o6MBjW6k+R4lB1cFb6dNAG+b7N6GXKXFvIXmgg0K9MCklcGDA36A4fqmQ9KOqs23QzVFqrx752pMfBW2cIi0WoBTItjhi1xjZjYhvJpKQvbvGYlLq29J1jnaWgluwkXmbtk7kWAZOSm9GbDwY51Fmn/iYfGWfZikOgZLdo9WD48f3bNz7RELlte39iSeTWOx/lSf0cBoS9ttBFvrEiuTeonEGlUYClipmC8QdyqODL9nx+VDd8G1KczZYsCNzilV4EIDSVLvFHBJjeT+LVbvV9vyZJY2ciyielEI/Apdz9NFoC27EzRXpSNV/LSt4NZ4UDN3wFZN84I3VZR8l7FZkC9KRwymhGU5LZtJ3ud4ewVBR+5YJ3hg65EDFf1ndz1Sz8azJbxNyq6TsWC9PxwaAUs2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2880.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e68ba22b-e4d2-4e35-539f-08d823489db2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2020 14:10:06.2183 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ku07YKuLbWs64BjqdSnvqM9O8dd/w631w5J4yPcKcvw0dSSCugLlRXzs5wnVSoS05ICbkw2Nj3pOoP2J0Wnbmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4526 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp was setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, July 8, 2020 2:38 PM > To: akhil.goyal@nxp.com; Trahe, Fiona ; Kusztal, A= rkadiuszX > > Cc: dev@dpdk.org; Yigit, Ferruh ; Richardson, Bru= ce > ; orika@mellanox.com; jerinj@marvell.com; > stephen@networkplumber.org; olivier.matz@6wind.com; hemant.agrawal@nxp.co= m; mdr@ashroe.eu > Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp= was setup >=20 > 24/06/2020 16:26, Arek Kusztal: > > From: Fiona Trahe > > > > This patch adds function that can check if queue pair > > was already setup. This may be useful when dealing with > > multi process approach in cryptodev. >=20 > That's all? No more justification? > No usage in example apps? > No addition in test apps? > Is it needed for the application? >=20 > I don't know cryptodev enough, but I can tell with ethdev experience > that we are a lot more demanding when adding a new API in ethdev. > We are still fixing the API errors done years ago in ethdev, > and it is very difficult to deprecate what was used in the past. > I hope my fear is wrong and you are not doing the same errors > as we did in ethdev, it would be a pity. This is used in a new example app which we expect will be applied in rc2. There are use-cases where the primary process creates and configure the dev= ice and queue-pairs and a secondary process uses the queue-pair on the data-path. It seems safer to provide the secondary a way to ensure that the qp it's ab= out to use is setup already rather than it relying on assumptions based on timing or the primary proces= s communicating this to the secondary. It's quite a simple API and fulfils this purpose. If anyone wants to propose any improvements to it feedback would be appreci= ated https://patches.dpdk.org/patch/72157/