Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests

["Trahe, Fiona" <fiona.trahe@intel.com>]

Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, April 15, 2020 7:36 PM
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; dev@dpdk.org; Trahe, Fiona
> <fiona.trahe@intel.com>
> Cc: Shally Verma <shallyv@marvell.com>
> Subject: RE: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests
> 
> Hi Fiona/Adam,
> 
> > This patch adds a new test suite for verification of the "internal
> > QAT IM buffer too small" case handling. These unit tests are
> > specific to the QAT PMD only - that's why they are contained in
> > a separate test suite.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > ---
> 
> Why do we need to have separate testsuite for QAT?
> Can't we have a single one and based on capability of the driver,
> Determine which tests need to be skipped in case they are not supported.
> This would create a mess in the longer run just like cryptodev.
> 
> Please fix this, we cannot take this patch as is.

[Fiona] Yes, I understand your concern and we considered including in the main suite.
However these tests are not based on something that can be
checked in capabilities. They are tests to hone in on a specific corner case
based on a QAT limitation in its intermediate buffer size. So some of the
tests are to validate that the recent changes we made in the PMD correctly
work around that limitation, but other tests are negative and expected to fail
as provoking a corner-case that still exists. Other devices would probably not fail the same tests.
This was why we felt it better to have a qat-specific suite.
We would expect any future tests to go into the main suite,  so don't think this should cause a
mess in the future.