From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B540EA0588; Thu, 16 Apr 2020 12:02:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CD911D69E; Thu, 16 Apr 2020 12:02:53 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AE9EC1D634 for ; Thu, 16 Apr 2020 12:02:51 +0200 (CEST) IronPort-SDR: ap28phjKHk6RNsT46uIQaAv0nIpwrhNtFmI2DNnqvzXKk2NgGqe7OFG99Pio4S46JsybGbLATh nmzDi+d7PpuQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 03:02:50 -0700 IronPort-SDR: F19ESSnZNLIlJW46I8VvrYMVlvDKgTfCNdxcvX3ChiLuVuUZSbNLxhKRto2xYZutDMZrPAbhns tkSlg6W+nOFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="427780104" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 16 Apr 2020 03:02:49 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 03:02:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 03:02:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eNjzzkfG9PLhGa3TlaPCLJsv5ml/0nJdku66C82aKFqLQFRZtv2NbnDd/2sDoaHvTc+kAhD4lIa8fgf5u6luTOUJcF0iCDzymjy5UQoWsPRoXVUCxBORkib+4lL5cD8jC+TbEJdOBRNi2h1QOcQ4+lxW52Cavdlx2pn9alCn2r3HzpcgDn9Vh4aKpz12YwYlQg9qEVPOQs+5q+3D/izdXVbGjOQmVIeP3tl31VI914MOrqjCGNel8I7cXY4FICSTPnM3mkacekvRWM1bkRuKE4NiJ7IVoq55fQlxskQoNiSLvX3rTedTjQKMsBBOS4+EXEx9oEWRpqaOKRqHVKGdjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1N9VUMnzs4Ne09lTcZhWC3PMBOhr/9Y3ecSVC8hoKuM=; b=j0zp240tbakNsvKz8sHWMkf7WIohEVUDtW7Px9EOWJzc44SBhANpApuQkvZ8/nq1EwOPZj3eltAkeH4T2+wGvxTCfsSk09hf0KpL+Mbf/uDfL8oG6P4Vd6+utz4kLRB3vBndCkYwS3Sv1JSpHB6PseSj+px38d9h2RElL31MBOoj7jH7JeSO7hgnvj/VGtaq6ttcgQaZmFXsojuTbb3NM87S6o2RCerL4wn0enadywCq3C31Vp2opYJwY1LiwOuDDGg/5e1OeXQI1l7KAAgBVKYaB6OlWXiRY6GDG+jKapuoanmaYFQoEB2WNk5MXD+vIfV6tJ0ij39+78cK6HNhBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1N9VUMnzs4Ne09lTcZhWC3PMBOhr/9Y3ecSVC8hoKuM=; b=sO6fW5UlmoHujqdC1YbyP+vqsIlfOHHPCiHfwJlghGHXt8419RdUWTjFOKY0u6TA0goysURO/e/8SYmkJasA/VDllvqV2OJ2a/CUGcH8zzbN5KGWQAdxk/qaQIEuh6Rb+qfn7ATJmMjvXpc8gXpenJQRDcQKubW/MUhLX73wQ1k= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SN6PR11MB2815.namprd11.prod.outlook.com (2603:10b6:805:62::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.17; Thu, 16 Apr 2020 10:02:25 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272%7]) with mapi id 15.20.2900.028; Thu, 16 Apr 2020 10:02:25 +0000 From: "Trahe, Fiona" To: Akhil Goyal , "Dybkowski, AdamX" , "dev@dpdk.org" CC: Shally Verma , "Trahe, Fiona" Thread-Topic: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests Thread-Index: AQHWDaR2XE14pvExgk+Y6GTRkWWp36h6jhgAgAD+RzA= Date: Thu, 16 Apr 2020 10:02:25 +0000 Message-ID: References: <20200408125101.25764-1-adamx.dybkowski@intel.com> <20200408125101.25764-3-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f9d1b03-f602-4528-96cf-08d7e1ed43eb x-ms-traffictypediagnostic: SN6PR11MB2815: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(366004)(396003)(376002)(136003)(39860400002)(66946007)(478600001)(86362001)(71200400001)(8676002)(52536014)(81156014)(2906002)(8936002)(66556008)(26005)(9686003)(107886003)(33656002)(316002)(54906003)(7696005)(53546011)(76116006)(64756008)(66476007)(66446008)(5660300002)(6506007)(110136005)(4326008)(55016002)(186003)(160913001)(15963001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sEXXY7cugIPTmcmeBD1ABmxwQ54k9akz2mSehS2zrFsiQ3sNJp/1EIMJqt6t252OY42634wEc+XL4hJXCzS02ZOfxdQNyUZ97vBMg1qoK6J2n9ibDX7eb5e68wMQh6k2IqhOFMwvv13nMh9N/dZEXaieSRvA2ynu5JMmKWFwwb/gEg14l1GdQjkZz0G4hAyWN2WtOMY7yt/cslw7WWIQqoV3jqTwCfoSKwZm4wsn1LTkRcRwAUQZGSq7MrikcEfd3u2xSar7K7+QKNYX5E13XWNlrXGl4oEk5oRk6xApnf39HrGeTVjTp9Vkx1pkwDxTsMJh0l5T7tDqdDz9jyafOBbKmjcncp42pGY9Xm1bFy1zFr2LlypeBe9Pb2S8B4EmqU1T12sSspJ6lkrYdeJ4Pv9t6awDAZbJ3/wTolgxC7tf0gHbUoWuRAMdXY8tyVvXsyTeDEa8/zXLr216AjIWA1J8kRbbKYOYLMxDli8uUlZbf/d8puZga0h4SG/EJMh90id2huEJz76mxbIXIdJy8A== x-ms-exchange-antispam-messagedata: 8TER67bgRKKCrZjH4yHREtfPuBDgrqS2rhCKJMksKN2PFNrXFeHMWqYHGmIfJG46l/1IJwMV+paudUQumkYbeSDHPpizSy0qdI2o2HXS8pl73y7LRHnY5wjF0SxE9tEGte/g4kumcUCqG82FdlkSdg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9d1b03-f602-4528-96cf-08d7e1ed43eb X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 10:02:25.7767 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5bBdIR4uhWbjoL6QEEX6rGP31xXzhpe66L0ofzIt+dSK7zyXjRsDm8sPE+3i/EofonYemN/MNNsepZoZWslD5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2815 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, April 15, 2020 7:36 PM > To: Dybkowski, AdamX ; dev@dpdk.org; Trahe, Fi= ona > > Cc: Shally Verma > Subject: RE: [PATCH v2 2/2] test/compress: im buffer too small - add unit= tests >=20 > Hi Fiona/Adam, >=20 > > This patch adds a new test suite for verification of the "internal > > QAT IM buffer too small" case handling. These unit tests are > > specific to the QAT PMD only - that's why they are contained in > > a separate test suite. > > > > Signed-off-by: Adam Dybkowski > > --- >=20 > Why do we need to have separate testsuite for QAT? > Can't we have a single one and based on capability of the driver, > Determine which tests need to be skipped in case they are not supported. > This would create a mess in the longer run just like cryptodev. >=20 > Please fix this, we cannot take this patch as is. [Fiona] Yes, I understand your concern and we considered including in the m= ain suite. However these tests are not based on something that can be checked in capabilities. They are tests to hone in on a specific corner cas= e based on a QAT limitation in its intermediate buffer size. So some of the tests are to validate that the recent changes we made in the PMD correctly work around that limitation, but other tests are negative and expected to f= ail as provoking a corner-case that still exists. Other devices would probably = not fail the same tests. This was why we felt it better to have a qat-specific suite. We would expect any future tests to go into the main suite, so don't think= this should cause a mess in the future.