* [dpdk-dev] [PATCH] common/qat: fix coverity issue
@ 2020-05-06 21:31 Adam Dybkowski
2020-05-07 11:57 ` Trahe, Fiona
0 siblings, 1 reply; 3+ messages in thread
From: Adam Dybkowski @ 2020-05-06 21:31 UTC (permalink / raw)
To: dev, fiona.trahe, akhil.goyal; +Cc: Adam Dybkowski
This patch fixes Coverity issue #357770 by removing the non-essential
check for NULL pointer.
Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation")
Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
drivers/common/qat/qat_qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index 64dfd85c4..60ef8bf0f 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -864,7 +864,7 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
resp_msg = (uint8_t *)rx_queue->base_addr + head;
- if (ops != NULL && nb_fw_responses) {
+ if (nb_fw_responses) {
/* only move on to next op if one was ready to return
* to API
*/
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] common/qat: fix coverity issue
2020-05-06 21:31 [dpdk-dev] [PATCH] common/qat: fix coverity issue Adam Dybkowski
@ 2020-05-07 11:57 ` Trahe, Fiona
2020-05-09 22:06 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Trahe, Fiona @ 2020-05-07 11:57 UTC (permalink / raw)
To: Dybkowski, AdamX, dev, akhil.goyal
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Wednesday, May 6, 2020 10:31 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] common/qat: fix coverity issue
>
> This patch fixes Coverity issue #357770 by removing the non-essential
> check for NULL pointer.
>
> Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation")
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] common/qat: fix coverity issue
2020-05-07 11:57 ` Trahe, Fiona
@ 2020-05-09 22:06 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-05-09 22:06 UTC (permalink / raw)
To: Trahe, Fiona, Dybkowski, AdamX, dev
> > This patch fixes Coverity issue #357770 by removing the non-essential
> > check for NULL pointer.
> >
> > Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation")
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
The title should showcase the actual issue fixed and not the coverity issue
Changed the title as " common/qat: remove redundant check"
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-09 22:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 21:31 [dpdk-dev] [PATCH] common/qat: fix coverity issue Adam Dybkowski
2020-05-07 11:57 ` Trahe, Fiona
2020-05-09 22:06 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).