From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 845F5A0588; Thu, 16 Apr 2020 16:53:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C1AF01DD3F; Thu, 16 Apr 2020 16:52:24 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4CF6D1DD26 for ; Thu, 16 Apr 2020 16:52:23 +0200 (CEST) IronPort-SDR: HuwljISy9yUsmRWZIBMVx3ra7ks12Sop7tP1ReqtQJnrfSykkCZqWv6lr1CRhuOkauEx0UQ8w8 94Q7wOlkdwFg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 07:52:22 -0700 IronPort-SDR: Trr+eK6enKWA8tQUZYJRD98nYweGXadpOEGwn4OwdR5gU0rjxRlUSFqUm82sDKcAYAhb5ouRqq VeSS76T6dykQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="253883923" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 16 Apr 2020 07:52:21 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 07:52:20 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 07:52:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 07:52:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K0xbOMHVSaa/r8Lrz7jEx96StYMOlDrqvSOW5L60zVoJaXF64/35OGRUPjdYBBIAiuWv6GjFSiDxIPeAtXaYRWymmf68niepAvW2odJ8Jhz0mdsm5u47xYii4R9b1B4UTTvlLG/6kwWUP3fci5qmkDMBlW9raxbRKe+FVIGZWc7+qV/Kc5iXJyuqwuHKajVZeW7AQ2UuSVHEEF/8JVLeAmE47KWq+Hh8OPUFs1voXLR51o8yaJPBIUhfR/v5ybEclnkHRXX3cgrqrM0qvkq0qMUiVm2uApZ+O4PAZWbuJa051a8vNqFNhSPI4CJhB4ZzkKqdwyisHApiptes3dWi3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OXAcbsatjD5EUMj5vcmpaw3RsT0Xw4nNrKBPiZeH/o=; b=R6/jKuv/gYtprpZaOkrAPYudVXNcY+R04He/cxKB9sH2HB9Cgni+RMbLmYKUnq+VKPnfzvuIvAQuF+TFKxId6pOjHHXAmgDgts/2efKcWhnGQIL9ZIu0MWvao+Fv4/01gvDznH7jOM8fHE7QcXJVYsM4t6Eh4LMNWoX1RwD0m5Oc59XwVxGVtA+PdXrp6hdorUh+PXzCzDPcwnMgAuMFOgwXF4NZsbCqyzVmwprq/nuElupGMr5RDhLLGUdRfRaD9pS37HBFA4WJ7f09B6tbjT82gbjfYp4q2taGpeJACZg+4nPcmfP3YRfaz7dQiGhXApJ3mVxsV0vH2g9k9VAFmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OXAcbsatjD5EUMj5vcmpaw3RsT0Xw4nNrKBPiZeH/o=; b=bC/5THb07lyFxh0+LSI+9an0Lhj0LUgCUUW5sYzWmeOe04rsBSsaMXUJgApNMjU2RI5CgQm8vsZkVNFwWPGkxwjIGF/s/b3NdwEO4Ukdz19s3ZwACB2jDhlgKui07gR56ejHmwNunNY8P4b0DtJMoMFh1cbT2htrGSN50DnfV5k= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SN6PR11MB3408.namprd11.prod.outlook.com (2603:10b6:805:bc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.26; Thu, 16 Apr 2020 14:52:19 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272%7]) with mapi id 15.20.2900.028; Thu, 16 Apr 2020 14:52:19 +0000 From: "Trahe, Fiona" To: Akhil Goyal , "Dybkowski, AdamX" , "dev@dpdk.org" CC: Shally Verma , "Trahe, Fiona" Thread-Topic: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests Thread-Index: AQHWDaR2XE14pvExgk+Y6GTRkWWp36h6jhgAgAD+RzCAAAr/gIAAA4fAgABC8QCAAAGDIA== Date: Thu, 16 Apr 2020 14:52:18 +0000 Message-ID: References: <20200408125101.25764-1-adamx.dybkowski@intel.com> <20200408125101.25764-3-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4317a0d7-0ce7-4a01-e998-08d7e215c30b x-ms-traffictypediagnostic: SN6PR11MB3408: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(376002)(366004)(39860400002)(396003)(136003)(76116006)(4326008)(110136005)(66946007)(2906002)(71200400001)(66476007)(64756008)(8936002)(54906003)(33656002)(66446008)(86362001)(9686003)(66556008)(316002)(478600001)(55016002)(8676002)(81156014)(5660300002)(186003)(6506007)(52536014)(7696005)(107886003)(53546011)(26005)(160913001)(15963001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dj1rw/CDEmjm57PpuqGVZHovPdbrI1BSh9VTb4E9lTI1I9ITv56GmN5NGpi/uqvkyNELXZq/hJcYh3pXBz/MoRj+K4edvMvwxNn1P6SvK+X0w168iBzGXt6pSerWaFOg9AkNif2nRldPE+4Xm7G3+TWBe/r0+XESNaI4N1HqQ/+QOUQLnoeuhZVxMHQs4FE4nN4k7dUe6cUTfOaKWhaxxBFjthB/KK+JqHVyh3iOEx/2SuKSBK76rmA856IZqd1xZm3zg6AQCkPxd9WE0qMfZuEaG7AKXAEQs14hEO4EfjDb0zHP5as2Op1v+c9660FoOs/4GGur1N6rcp0EP9x0iApYJvmB7CCbV5MweC2C1Zs2Qn6HVpiWyDv12NBCFxxA3ppX8GkbKqIdiNzgHL4iDR+ps3yeluH7gs6oXsfj0oZMIrB11LIULYiY/dHzwVGbYFpXDqcakGtYggSAjhfpvFmrbV++stjstwDlinKM9PiYxJ5Ec36cq+cAgNPqOKbCU+1I4/LTRqT2QWCKyV2u7Q== x-ms-exchange-antispam-messagedata: YtnczOKmcitS+ORe9cEXw8qPGf+6yFFbnwMYwdd6tuSh1fHta6dgvcRVtq3GiJeZwGFTqjXaN0T4Mzp2umVcVFQcPxx5TdHhL5PGhj9FReIv8MyJFM9nw9v7LHEDvmRbB6EaoAsyxMDpyUbffZpKTg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4317a0d7-0ce7-4a01-e998-08d7e215c30b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 14:52:18.8124 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7tY3t5buhkwY9h5UBhc3DaUQRx641n+OhoxWJiA/T4egsYW8HiBU4YGM4ar12OJjq+Qm1lWzcbWL2PrM+2YLWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3408 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, April 16, 2020 3:38 PM > To: Trahe, Fiona ; Dybkowski, AdamX ; > dev@dpdk.org > Cc: Shally Verma > Subject: RE: [PATCH v2 2/2] test/compress: im buffer too small - add unit= tests >=20 > > > > > > > > Hi Akhil, > > > > > > > > > > > > > > Hi Fiona/Adam, > > > > > > > > > > > This patch adds a new test suite for verification of the "inter= nal > > > > > > QAT IM buffer too small" case handling. These unit tests are > > > > > > specific to the QAT PMD only - that's why they are contained in > > > > > > a separate test suite. > > > > > > > > > > > > Signed-off-by: Adam Dybkowski > > > > > > --- > > > > > > > > > > Why do we need to have separate testsuite for QAT? > > > > > Can't we have a single one and based on capability of the driver, > > > > > Determine which tests need to be skipped in case they are not sup= ported. > > > > > This would create a mess in the longer run just like cryptodev. > > > > > > > > > > Please fix this, we cannot take this patch as is. > > > > > > > > [Fiona] Yes, I understand your concern and we considered including = in the > > main > > > > suite. > > > > However these tests are not based on something that can be > > > > checked in capabilities. They are tests to hone in on a specific co= rner case > > > > based on a QAT limitation in its intermediate buffer size. So some = of the > > > > tests are to validate that the recent changes we made in the PMD co= rrectly > > > > work around that limitation, but other tests are negative and expec= ted to fail > > > > as provoking a corner-case that still exists. Other devices would p= robably not > > fail > > > > the same tests. > > > > > > Does that mean that all PMDs will pass with the newly added testcase = which is > > for > > > A corner case in QAT. If that is the case what is the issue in adding= that in the > > main > > > Test suite. It will get passed in all PMDs, isn't it? Am I missing so= mething? > > > > > > I believe we should not have PMD specific test suites, rather it shou= ld be based > > on > > > Capabilities to identify the cases which should be run for that parti= cular PMD. > > [Fiona] yes, several of the cases should pass on all PMDs. > > So we could move those into the main suite. > > But what to do about the negative tests? > > Example: If a very large data buffer is passed to QAT to compress with = dyn > > compression, it will get > > split in the PMD into many smaller requests to the hardware. However if= the > > number > > of requests is bigger than can fit on the qp then this will never succe= ed. The test > > validates that the PMD behaves appropriately in this expected error cas= e. That > > same > > case would probably not have an error on another device. Maybe we shoul= d just > > leave out > > such negative tests, but I find them useful as they validate the known = behaviour. > > The buffer size used in the test is based on the known size QAT can han= dle and > > the > > corner case in which QAT will return an error. > > > > I see 4 options to handle this: > > 1. Leave out those tests > > 2. Use a qat-specific test suite only for negative cases which are cons= tructed > > based on specific qat internal meta-data. > > 3. Include the negative tests in the main suite, but only run them on Q= AT (by > > checking driver type) > > 4. include the negative tests in the main suite, run them on all, expec= ting a FAIL > > from QAT and a PASS from other devices. > > > > My preference is for 2. > > But up to you. > > > I would say 4 is better. And why do you say negative cases will fail on Q= AT and pass on all other. > The test cases are to test the library APIs which are same for all the PM= Ds and the behavior should > Be same. [Fiona] I've explained above why QAT fails, sorry if it isn't clear. Any device can have errors - it's not an API or capability issue, it's a de= vice limitation in a very unlikely corner case. So 4 is ok? i.e. if there is conditional code in the UT expecting different= result depending on PMD type? If not, we'll revert to 1 and leave out those tests.