From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72EC1A04B8; Tue, 5 May 2020 11:57:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 827D21D150; Tue, 5 May 2020 11:57:39 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D48481D14E for ; Tue, 5 May 2020 11:57:37 +0200 (CEST) IronPort-SDR: ykZ5jgZJJXEawzcij7ntVVg+be3UX4oLqYqtC06pi+ipUOnsM2ISm366Wb0m3zoxh2qwIIxmkL 1LeowdHaMNQA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 02:57:36 -0700 IronPort-SDR: H+OJY5KbV8nMqe/x9tbq9cfdsPJwQjaF6oY5l5EkEizVCDgvDxNeDBL1d4uZGzWB+bKInZ9OwE o6uow4bGjcLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,354,1583222400"; d="scan'208";a="461319324" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 05 May 2020 02:57:36 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 02:57:36 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 02:57:35 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 02:57:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRZ4b3Xco8m5ewmMrsxWqc5xLDYpNapP/ysQkvb/jUNDfhO+d8lCjF0O4w4OkAFXa/PHOpUWGsBngKSbm7JmgIhXUeFbx8stDlgyk1/fF+20Co+gBUEHKUVQz1PLYpCDw5DrUgXNsxMM4gD0Vn21GEbCkrE8fY9w8ubbnXGMMe0qYkW3owhdY1O4yhIkV/2JjudHWiXVFb9Elu/DVUQ6N0Ie8d5K7uT0+vjfvxDz61y7+h257tD6e6uCWf1c9LBGtTGQ0Sw79K22Jvc/hJFXpUbmn+HFO5ENNDN35WLJpLKCnYZW+ksgPtxL8mM16mVpr5vPcheftzVwWO6aiDaIGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2dawXOFmIzeAKR2F65v3zjDjqReSy3ow09I3+2t+QQ=; b=lBdptZWtzYw2gtJlhvsBqZnhN8ak2+WGfnpy6PhRO4BcFG2rUCIcmHTXuXLJ0GtP5zBYdcaEYx3bT4gBxJ9fTWdXRdijbsiKYqSM62X+y/uSWuXC/toNyZ3sV4WiQj1b1wBHH3gb6YeY+Zqlh8ZCK6DJk9YTdmH/ClF6xqB0GBu62Pt9oP6mDfUMYDkSY1XoLpuQ7kD9Dv7f+aJ/nfUwC/TM/0RlyZZEHt38oD3WWc5Rggk2jn/PjGnnvXlB3K331A2c+44ZX2UYkWPtUK5G4PCELjaT4zfYsGUACTGB/5W3OezWpnwb0FJY9DOTixOBcD4t6Yb/n58EiANehzsV8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L2dawXOFmIzeAKR2F65v3zjDjqReSy3ow09I3+2t+QQ=; b=VuNHW7z5+wdeaoNmjgFEsAi9Ec5haCqJVaZmGMaKM5gxF242wMdB6Ud7/BjeZp7vj3lBbTQkyd/Xnce3gxeZmq7ZXOV90mzsgcqvR6v0jBg8uuF7HjBNiiXSuxl/MF2vHZrazmHJ/inT5KdHBm1tOECuWCsVnGD2Oy/u+VbjUAk= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SN6PR11MB3342.namprd11.prod.outlook.com (2603:10b6:805:b9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Tue, 5 May 2020 09:57:33 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::c4ff:6258:78f7:ff90]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::c4ff:6258:78f7:ff90%5]) with mapi id 15.20.2958.030; Tue, 5 May 2020 09:57:33 +0000 From: "Trahe, Fiona" To: Akhil Goyal , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "Doherty, Declan" , "asomalap@amd.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "tdu@semihalf.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "G.Singh@nxp.com" , "hemant.agrawal@nxp.com" , "jianjay.zhou@huawei.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" Thread-Topic: [PATCH 1/9] cryptodev: add feature flag for non-byte aligned data Thread-Index: AQHWImIoN2MITcxt/ESWaDW13zb9U6iZQFcA Date: Tue, 5 May 2020 09:57:33 +0000 Message-ID: References: <20200504215811.15951-1-akhil.goyal@nxp.com> <20200504215811.15951-2-akhil.goyal@nxp.com> In-Reply-To: <20200504215811.15951-2-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.182] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 444d0bdd-b104-49eb-68cf-08d7f0dabb62 x-ms-traffictypediagnostic: SN6PR11MB3342: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0394259C80 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(39860400002)(376002)(346002)(136003)(366004)(33430700001)(8936002)(7696005)(8676002)(33656002)(6506007)(5660300002)(26005)(52536014)(66946007)(86362001)(33440700001)(64756008)(76116006)(66556008)(7416002)(110136005)(55016002)(9686003)(66446008)(478600001)(66476007)(2906002)(107886003)(53546011)(71200400001)(54906003)(316002)(186003)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uk4NzJv0FUgyCl1bnZVShdBHRR1mkuGBbDz1uatzkvSfXPFZqxvg7pj3Xf4guytKscrSu6jCRud3F+fEn4ZvweQ+JXDDCD7ACOQU2fOIIU5h73tNcqOPURm+20Hv1w0sJZUHG9vQORasybQYiA4KOkN8aRy+SfnS8EJ+wIcTm0ctumHrMG4vSZUlx2SIf5VGvTfItlcdFJDxDvAWh8g95CMF4LOd9yG8L6F752sJ1SFF8lTkgx3PlV9pPoWOeowmKEJkudDs/AZef8ulAXS6whzOIP33ujv+LzSPKMQ41suHM91AxK7Shby8cHDD8HWHFFkMKMdhu2PeOA3Sh71Nnmu/v4D/pUVZiti56+nz8zE1+Hj4EAZ+t1pTw+zsaUyUU6SXofKa+qTbCW0G4zFnaPHtvHTzzRp40qq9MjsNFIE56gmedqK1AdCtXbgOmn7BB24YSWK/gZVcsm0TWQ4CDpdryqFBfVTN3LcLQoa/5wXcqqmHVqnJkXnzs7rOTt24VeE8jmpeEH2qEnQiQ54zow== x-ms-exchange-antispam-messagedata: RKRiz+q1r4JeTrI+BPfF8jz/yKQdQI1d8fUdV/4fgyo7hN5QzxGp+FrLiQvH0LQRwwviaETFVtIeemILRk0H8RSAqZI9oUTybnaTzgxraqFEpLTElEVP18VF8pWQ6K5AILyiaaELkkA9cC4lQmGlmbYA1+ffiFKbl9hRKtWpQv4iYF6LuQVHKIeB5Z8p3rao3+Uxn4LyHxdkppc8Y3DkPDrX9aHXzsN0oID3fGhtrcd8KD5/ODIHX29kQj2esQVLayqhybol7SuUOtLLdWJN3Gpi/J4cpsFbXlFSzMbPzn/MdIui3mmA1wf/1SJwfobi8ok7NFksEXvPN1SemIeYdcpeNs4PgNVeeR2Vyb9bOREfU9L4CmS2DUMzXQiO2M9erqEdfo4YR8KcMAfbFNtiZSQeMTS1wMV/SE+o3uY6/OYLRdrR16GTVj7NSbcsO2I8Fz0tJUI/S59KgG+7Ro3f3pk28Xh4vjUK4FiL4Sd8TfOFD8uYC9DyjNbp2xnHyJ2KN6NdW/Y0j5ZIjw1p1rcrYVxxvQgwMY0bOKWoiQiZ9aGhYGk4Mt5PSIV98b6Ir8H/e628+FbHXQSL5EdMGVl/GJ2P58TDmj7NUEeOjuNp0mcdA98WjGO80+AbdPt1rPy251TQjp1RjAeKPouiy3VkkyfMAgjFGOgISOJ7awGr0W4gGHoNEJzqp38/qBKGYBsWyN2z+ga7RCSlGRhfJ+7e1eV12rdkKwgMD/TSw8NYOkGBu1AtBGshBBNEc8kvAUjmUrA4KLMmtZugr7QvU5JG+uqM3oo49VdaXFHUnJ6q8pCV71KgKeN+NW4P7PY5AA5C Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 444d0bdd-b104-49eb-68cf-08d7f0dabb62 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2020 09:57:33.1611 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PovIfF8HYzp3RCC6LcJjUyX0n5pwsv1mZOTSvZ8vgAW8Za36RRgW5LBiWLVw9axasM4v4K9bFlH1a4aCurKURQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3342 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/9] cryptodev: add feature flag for non-byte aligned data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Monday, May 4, 2020 10:58 PM > To: dev@dpdk.org > Cc: Ruifeng.Wang@arm.com; Doherty, Declan ; aso= malap@amd.com; > anoobj@marvell.com; Zhang, Roy Fan ; Trahe, Fion= a > ; tdu@semihalf.com; rnagadheeraj@marvell.com; adwi= vedi@marvell.com; > G.Singh@nxp.com; hemant.agrawal@nxp.com; jianjay.zhou@huawei.com; De Lara= Guarch, Pablo > ; Akhil Goyal > Subject: [PATCH 1/9] cryptodev: add feature flag for non-byte aligned dat= a >=20 > Some wireless algos like SNOW, ZUC may support input > data in bits which are not byte aligned. However, not > all PMDs can support this requirement. Hence added a > new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA > to identify which all PMDs can support non-byte aligned > data. [Fiona] I know it's a bit pedantic, but shouldn't this really be called NON= _BYTE_MULTIPLE? As a non-byte-multiple data set could have its start byte-aligned, but stil= l not be supported. > Signed-off-by: Akhil Goyal > --- > doc/guides/cryptodevs/features/default.ini | 1 + > doc/guides/cryptodevs/features/kasumi.ini | 1 + > doc/guides/cryptodevs/features/snow3g.ini | 1 + > doc/guides/cryptodevs/features/zuc.ini | 1 + > drivers/crypto/kasumi/rte_kasumi_pmd.c | 1 + > drivers/crypto/snow3g/rte_snow3g_pmd.c | 1 + > drivers/crypto/zuc/rte_zuc_pmd.c | 1 + > lib/librte_cryptodev/rte_cryptodev.c | 2 ++ > lib/librte_cryptodev/rte_cryptodev.h | 2 ++ > 9 files changed, 11 insertions(+) >=20 > diff --git a/doc/guides/cryptodevs/features/default.ini b/doc/guides/cryp= todevs/features/default.ini > index 118479db5..fb1ddca71 100644 > --- a/doc/guides/cryptodevs/features/default.ini > +++ b/doc/guides/cryptodevs/features/default.ini > @@ -29,6 +29,7 @@ Digest encrypted =3D > Asymmetric sessionless =3D > CPU crypto =3D > Symmetric sessionless =3D > +Non-Byte aligned data =3D >=20 > ; > ; Supported crypto algorithms of a default crypto driver. > diff --git a/doc/guides/cryptodevs/features/kasumi.ini b/doc/guides/crypt= odevs/features/kasumi.ini > index 99ded0401..8380a5765 100644 > --- a/doc/guides/cryptodevs/features/kasumi.ini > +++ b/doc/guides/cryptodevs/features/kasumi.ini > @@ -7,6 +7,7 @@ > Symmetric crypto =3D Y > Sym operation chaining =3D Y > Symmetric sessionless =3D Y > +Non-Byte aligned data =3D Y >=20 > ; > ; Supported crypto algorithms of the 'kasumi' crypto driver. > diff --git a/doc/guides/cryptodevs/features/snow3g.ini b/doc/guides/crypt= odevs/features/snow3g.ini > index 8b971cc1d..b2caefe3a 100644 > --- a/doc/guides/cryptodevs/features/snow3g.ini > +++ b/doc/guides/cryptodevs/features/snow3g.ini > @@ -7,6 +7,7 @@ > Symmetric crypto =3D Y > Sym operation chaining =3D Y > Symmetric sessionless =3D Y > +Non-Byte aligned data =3D Y >=20 > ; > ; Supported crypto algorithms of the 'snow3g' crypto driver. > diff --git a/doc/guides/cryptodevs/features/zuc.ini b/doc/guides/cryptode= vs/features/zuc.ini > index f7bff4291..21d074f9b 100644 > --- a/doc/guides/cryptodevs/features/zuc.ini > +++ b/doc/guides/cryptodevs/features/zuc.ini > @@ -7,6 +7,7 @@ > Symmetric crypto =3D Y > Sym operation chaining =3D Y > Symmetric sessionless =3D Y > +Non-Byte aligned data =3D Y >=20 > ; > ; Supported crypto algorithms of the 'zuc' crypto driver. > diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd.c b/drivers/crypto/kasu= mi/rte_kasumi_pmd.c > index a20921249..73077e3d9 100644 > --- a/drivers/crypto/kasumi/rte_kasumi_pmd.c > +++ b/drivers/crypto/kasumi/rte_kasumi_pmd.c > @@ -551,6 +551,7 @@ cryptodev_kasumi_create(const char *name, >=20 > dev->feature_flags =3D RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > + RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA | > RTE_CRYPTODEV_FF_SYM_SESSIONLESS; >=20 > mgr =3D alloc_mb_mgr(0); > diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd.c b/drivers/crypto/snow= 3g/rte_snow3g_pmd.c > index 8e82dde55..c939064d5 100644 > --- a/drivers/crypto/snow3g/rte_snow3g_pmd.c > +++ b/drivers/crypto/snow3g/rte_snow3g_pmd.c > @@ -563,6 +563,7 @@ cryptodev_snow3g_create(const char *name, >=20 > dev->feature_flags =3D RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > + RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA | > RTE_CRYPTODEV_FF_SYM_SESSIONLESS; >=20 > mgr =3D alloc_mb_mgr(0); > diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zu= c_pmd.c > index 17926b471..459881873 100644 > --- a/drivers/crypto/zuc/rte_zuc_pmd.c > +++ b/drivers/crypto/zuc/rte_zuc_pmd.c > @@ -470,6 +470,7 @@ cryptodev_zuc_create(const char *name, >=20 > dev->feature_flags =3D RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO | > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > + RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA | > RTE_CRYPTODEV_FF_SYM_SESSIONLESS; >=20 > mb_mgr =3D alloc_mb_mgr(0); > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/= rte_cryptodev.c > index 7693eb69c..f30e3cbff 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -500,6 +500,8 @@ rte_cryptodev_get_feature_name(uint64_t flag) > return "ASYM_SESSIONLESS"; > case RTE_CRYPTODEV_FF_SYM_SESSIONLESS: > return "SYM_SESSIONLESS"; > + case RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA: > + return "NON_BYTE_ALIGNED_DATA"; > default: > return NULL; > } > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/= rte_cryptodev.h > index 3dbb5ceb2..257840ea4 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -456,6 +456,8 @@ rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asy= m_xform_type > *xform_enum, > /**< Support symmetric cpu-crypto processing */ > #define RTE_CRYPTODEV_FF_SYM_SESSIONLESS (1ULL << 22) > /**< Support symmetric session-less operations */ > +#define RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA (1ULL << 23) > +/**< Support operations on data which is not byte aligned */ >=20 >=20 > /** > -- > 2.17.1