From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94161A057B; Tue, 14 Apr 2020 15:52:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78BA71C2BB; Tue, 14 Apr 2020 15:52:10 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 06B7D1C2AB for ; Tue, 14 Apr 2020 15:52:08 +0200 (CEST) IronPort-SDR: Q4gpOsMA24x9CHtZ9YVgUFtX4R/On11L+qk+4S2kd5s3dinTBrLeffANzU8epunxo0P0lOwfZm llXtdl7FkeSQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 06:52:07 -0700 IronPort-SDR: v9jT6N/+JTIs5wm0sGplQbmggu/eX02kqgPx5IBSREyJTxCNTAOjTv8KNMfuNBcuT/W/WuXj8v i6Fzu152ld+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,382,1580803200"; d="scan'208";a="399954644" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 14 Apr 2020 06:52:07 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 06:52:07 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 06:52:07 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 06:52:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOMJu8urKfmkoOr+WuzSiWWGz13jD6jt+whCvJXm7sXkK0UH3Wsi+YfuB0tAYlF5kwKHKyGd3SY1AAQyLbF3fRHKS3zy4YM/tn4x3gY6LAiG9ghVLplUtxhkCO84GBmuuNunLHOiKfX+c6JQwsQ3cv/unatz7p9G0mmzuXS9PhVe+jVCsk/Cpfc+eygytqW+TuOyKzadkM5odPhOw6XEQ3GvECb+cmfnEWl0A4hExUDdKZqr/AqOIOnkzypWudZKCjLCfP19vF7X6jDzGKByIqjoglQ/xsxFPemJpuU92UBNfh1UxoUTdN6crMYuc8g0CdlWtMKZ3C7ywP0TX5aiaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKZ259n2boKF2zyQQRwZ0nvOn4n6RxlQJ1qem88b/YI=; b=gCIBVFcHjIfA8kXRvtljbPIQxMFMtYnleRKIFRygyYuQQq6yZpQ5PGg348pHWPawqrQ8QFA8L9QDwOegEuevrUAH1XZG85MfavRkzDQf+c43LqXzsjyiMupIMr7YYKU/FLAaTebu/DJGe6B4iNIgoeWcug/Vz6w3Gz9qZtZKvjeJRjogLSXTlXrY8owYzZzf2GMO1AGsiL9Vyw3FpJrjB7H9hx3+xB0veUAHe/VHSJ6PD0KMr0n0yGsT/Ssd8Ny/ZMsw82W43bMOrQoPmRXp1HE4lAkmoBepr8kOMVZB2iF+UZYMNLXVEztUwqLpOK7FZVi2mnWcyqwqYR8vImtSZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKZ259n2boKF2zyQQRwZ0nvOn4n6RxlQJ1qem88b/YI=; b=qNefSpnOYPEUXrP95XnnR+3fKaXWjK6o/tbwtWQzTmDeGcZB+nAloHuy4ZPyDXGUaZ0FmziLxywnLeEuH+tGEii9ligHHXR9DU4y2a5DSn3Rx5HDJ4OnKq5aNnHMDYFV8B2Oqhi62Vc9mL4r9NwujvyAGPA1wn2yHnzGMyWLAxo= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SN6PR11MB3440.namprd11.prod.outlook.com (2603:10b6:805:cb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.28; Tue, 14 Apr 2020 13:52:04 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272%7]) with mapi id 15.20.2900.028; Tue, 14 Apr 2020 13:52:04 +0000 From: "Trahe, Fiona" To: Thomas Monjalon , "Kusztal, ArkadiuszX" CC: Ray Kinsella , "Richardson, Bruce" , "dev@dpdk.org" , "dev@dpdk.org" , Akhil Goyal , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function Thread-Index: AQHV/WYkmJcgKZ9CcECXev0/iUBCuKh4sVCAgAAOMACAAAvkgA== Date: Tue, 14 Apr 2020 13:52:03 +0000 Message-ID: References: <20200318204136.10508-1-arkadiuszx.kusztal@intel.com> <3920120.q0ZmV6gNhb@thomas> In-Reply-To: <3920120.q0ZmV6gNhb@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.171] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 888f5eeb-a20e-4f86-dc1a-08d7e07b0393 x-ms-traffictypediagnostic: SN6PR11MB3440: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(376002)(396003)(39850400004)(136003)(366004)(76116006)(66946007)(64756008)(9686003)(53546011)(54906003)(110136005)(186003)(7696005)(26005)(316002)(6506007)(55016002)(66476007)(66556008)(52536014)(2906002)(33656002)(6636002)(478600001)(66446008)(5660300002)(4326008)(8936002)(71200400001)(86362001)(8676002)(107886003)(81156014); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uA7S2fyOgNpHTLXYySKQeMOqe58Bq7bYBUfxENJiS+ufijZGjjrbckgDbSXV8AhiDXnVl/Ht6IVTDE4KiVcmOoRz4bvOIyNz+2NtvnVvz5WmCtzf5fLH+RkYlUQpczE3fFPIJ5ibLFjQY1KDQ9MKVapVLp5N1LR2JBddDTnceKMWD8LP1OAxGIHJFPnrH/0PCxM3gy74TEyLS4U5fh152a0jTN3i8yTXxLA8q7GWVdxUEUCq398uQ6ClsRPe0ayXC6hDZzavhV/npkfJmzTL400JtFj+Mv2iQV8W569k6AugNt3Rry5PuUI/JHhXVBynuPzo6RQHs3+6eQaa00Qkarnlf5k9S/3dqajcvHNjA4D+rh7Cml/lVQHs0VQDi6u+ppypp21LcHRf2PvRVR5NBIPXl7KPE/6jfvhZ44Kk7fHtYfuu1FAyYAhC5S+GuA9N x-ms-exchange-antispam-messagedata: Kq3mZM8LoN2DWI+EnbI32C9MfrTVV0AgrbcAWp2YmecMbQ0NVwhhHDJjUFMzOX9TM3M6mikMyiR56SxPd/dJwDMGrd8xMfhre1xV08kRWiRPx47rab73v0OUeGkYHqiZ1b8eDj7n8Itxn95SCd5dIg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 888f5eeb-a20e-4f86-dc1a-08d7e07b0393 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2020 13:52:03.9686 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EaW2g/UmL/jYNe4Tavu2YXpJ4ueLlaW5wVUbClB27OgWF9Q1N5muZp2/iR07AyWPwZaPt7r6iK7ObvsMBcBBMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3440 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, April 14, 2020 2:04 PM > To: Kusztal, ArkadiuszX > Cc: Ray Kinsella ; Richardson, Bruce ; dev@dpdk.org; > Trahe, Fiona ; dev@dpdk.org; Akhil Goyal > Subject: Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get= function >=20 > 14/04/2020 14:13, Akhil Goyal: > > Hi Ray/Thomas/Bruce, > > > > Could you please help review this patch wrt ABI policy? > > > > > > This patch adds versioned function rte_cryptodev_info_get. > > > Node 20.05 function works the same way it was working before. > > > Node 20.0 function strips capability added in 20.05 release >=20 > What are Nodes 20.05 and 20.0? [Fiona] 20.0 is the designation for the API before 20.05 release. >=20 > > > to prevent some issues with ABI policy. To do that new capability > > > array is allocated per device and returned to user instead of the > > > original array passed by PMD. >=20 > rte_cryptodev_info is provided by the caller of the function. > I don't understand what you explained above, and the code is missing > some comments explaining the reason of the logic. >=20 > I still don't know whether this patch or not because it is missing > some clear explanations. [Fiona] We've identified that we also need to version the rte_cryptodev_cap= ability_get() API as it calls rte_cryptodev_info_get(). And the version handling oly works on direct API calls, but not on calls within the API. We will send a v2 to handle this. And will add more explanation in the comments. =20