From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF4BFA0588; Thu, 16 Apr 2020 13:26:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7AF741DB7C; Thu, 16 Apr 2020 13:26:51 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 90EB71DB7A for ; Thu, 16 Apr 2020 13:26:49 +0200 (CEST) IronPort-SDR: ik7eUQqE0jFVFT5WoaVTHQ/irNRwq9l7nYvjGaDT1i0bjcpq17QavFDk6b0SCVB4mOl1ovo6E0 mvJ23JWgdBWA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 04:26:48 -0700 IronPort-SDR: 2ybPs3UqV9RfHgjzSavUjrZeIaYMSPtV8ZYcGonvxuVUSGB8rKX9ZImb3GmlflJvQ22gHZLkoq 114fcjygMsHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="257185909" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga006.jf.intel.com with ESMTP; 16 Apr 2020 04:26:48 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 04:26:48 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 16 Apr 2020 04:26:48 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 16 Apr 2020 04:26:48 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Apr 2020 04:26:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EZiOt1ff5HK5uQ17xfI8STER7iAqaAHZh1ePp3/V+7A6mQqxirjwefuS9bOCaYfQnwyjBqQ3IfFw5joImB90gNzvbwzt4sQPDSx7hHC0TeQQ0qiXpHKewFxRwJ4Sf+VoBv/sEpiAV8gc6vLPdVjSR7qFGfGJ0hp745XJ1J4KDsJHAmuwy0VxnUhxxN2kUy2Oud24+p32stxcp7ObS5hVBs/R/0U+UQUB7rQ4DvaUDnrwhByowKWLrFiTld2gRTNQxU50x5dIoHre+R3EyoImcSI42wb2T59H/JNy6dE96X6HtwBFmmBTcdfMtcQy5vOODxr6rGyPHkkKzYcGKZC/Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pE1Md9DfWnIb23EnS48Hjw5C3sZr7YkBGD3QMiCGgMY=; b=nu/fSAwwupOmGfS0XWOXUMSJAA6jU0z7T3G2WexHnbqVB4gpLAgrQmDsxxEC3+xy0dQC6OUO0msXc5Uy573jOZRX76gqPsUh9bFu0U7AiKNwtlf81Hf7bgEftSh1XbgE0OT3oDIEAvwwNin6w6WgdvYdJQFe22U5D9/AozA9dHAuUTaFfUmUjoQp+wZMG9D3lAhD3M1zeI/Aj74ToEp9SKf0OoHxYBdRx0G45siHVmzJhjHwQeZUTrGy/AsWvWNBbW+QbjrEn0IwKE5Z+A461FuywA0hIGyJbiWzn5JAc7ArreFMGLg5FXgC65ikU14DA6sAQecqGPXjCOOENFjZwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pE1Md9DfWnIb23EnS48Hjw5C3sZr7YkBGD3QMiCGgMY=; b=DMn9BSlDysewW4UYgrJSj83AfdWgoKLa/0+c//raUECPQN3Ag8FGKudV5dCHLly1iEEa4UHqGkO/RYZheIc0qnvKpsdXGpPmhxAusQHvhNlwkxkNYFwsOXLp0LqqhnUC2z8oQSLvLi0iTCLz0aoxEns4LvtEWSYdWvWopZxJHrM= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SN6PR11MB2991.namprd11.prod.outlook.com (2603:10b6:805:db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Thu, 16 Apr 2020 11:26:46 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272%7]) with mapi id 15.20.2900.028; Thu, 16 Apr 2020 11:26:46 +0000 From: "Trahe, Fiona" To: Akhil Goyal , "Dybkowski, AdamX" , "dev@dpdk.org" CC: Shally Verma , "Trahe, Fiona" Thread-Topic: [PATCH v2 2/2] test/compress: im buffer too small - add unit tests Thread-Index: AQHWDaR2XE14pvExgk+Y6GTRkWWp36h6jhgAgAD+RzCAAAr/gIAAA4fA Date: Thu, 16 Apr 2020 11:26:46 +0000 Message-ID: References: <20200408125101.25764-1-adamx.dybkowski@intel.com> <20200408125101.25764-3-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b6469c3-34ca-44ca-69ea-08d7e1f90c24 x-ms-traffictypediagnostic: SN6PR11MB2991: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0375972289 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(136003)(39860400002)(376002)(346002)(366004)(396003)(66946007)(66476007)(6506007)(53546011)(76116006)(26005)(86362001)(478600001)(66556008)(64756008)(66446008)(7696005)(2906002)(316002)(8936002)(81156014)(110136005)(107886003)(9686003)(55016002)(4326008)(71200400001)(52536014)(33656002)(186003)(54906003)(5660300002)(8676002)(160913001)(15963001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cA9er+gZ0dUMjW71zFoR/vIPCaL+l+viu9dEqraDUJs70mxq4yWlfGhZgeG4a8wrp3sMVl/tOj8RKbHcqb0asbB28G3X6AJb3EugS5xarvOeK2pmd/WQdlHPd2JZnUy/iDRKr4YAv9HV5BDDy5p2LaL+h8dWAOqpILQnJp/DEX0/OEXg8KPiyFCQVKHGkfHXbjaOLqWmZQ9t9C+nbd1d7FGgu9S1EJNdtXWy2Ry/hoy3faJEyTpv8sjOKbYde8Ia+Vin2sxUIxbJUmzOkGpVc3zAgMaIp8CSZrtvnj7DX8td8O+XnoqjRCqoY4VetQexMjEnpfXokxUr6RwhTvr/hm1k4sv3+EIq7LjDZ1QR1uYjIczcX6tTd3KXxXhtxx7rrFVDMiX9e+u8Q4rC6mELS3bkIog7+02Ck4SjBiEbCbLr8CgtxMvMp87czYz+FmD/w1lUojGRHCF/97STIaONZuCJjYAGsgyIWvfDQ91XARouTKYN7vscGUCYc9pqEzsask1IPa3rekBHkd6zdoTafQ== x-ms-exchange-antispam-messagedata: fEctvJ0M24h3Vd63EyfDh3Rf1oesV+3dmaSasjZBruCFz5HIw9DojOTYqgKqE2a6/70kcgYRxdWfG8GPQgSkogPSZWnKOtq9rxwr2mcWzgXNAkeJdhwg71RTZ0Ike1OPDHDwI6j1f+qE+cQz5TK3oQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2b6469c3-34ca-44ca-69ea-08d7e1f90c24 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Apr 2020 11:26:46.2024 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jDhWn21JECgW76q98IHODLAOLjxDMeteI4RYXofdnjZp4VPUxz9SZC+7Q9STi1EBAyL3ljep74TXu27he5Qkqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2991 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] test/compress: im buffer too small - add unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, April 16, 2020 11:25 AM > To: Trahe, Fiona ; Dybkowski, AdamX ; > dev@dpdk.org > Cc: Shally Verma > Subject: RE: [PATCH v2 2/2] test/compress: im buffer too small - add unit= tests >=20 > Hi Fiona, > > > > Hi Akhil, > > > > > > > > Hi Fiona/Adam, > > > > > > > This patch adds a new test suite for verification of the "internal > > > > QAT IM buffer too small" case handling. These unit tests are > > > > specific to the QAT PMD only - that's why they are contained in > > > > a separate test suite. > > > > > > > > Signed-off-by: Adam Dybkowski > > > > --- > > > > > > Why do we need to have separate testsuite for QAT? > > > Can't we have a single one and based on capability of the driver, > > > Determine which tests need to be skipped in case they are not support= ed. > > > This would create a mess in the longer run just like cryptodev. > > > > > > Please fix this, we cannot take this patch as is. > > > > [Fiona] Yes, I understand your concern and we considered including in t= he main > > suite. > > However these tests are not based on something that can be > > checked in capabilities. They are tests to hone in on a specific corner= case > > based on a QAT limitation in its intermediate buffer size. So some of t= he > > tests are to validate that the recent changes we made in the PMD correc= tly > > work around that limitation, but other tests are negative and expected = to fail > > as provoking a corner-case that still exists. Other devices would proba= bly not fail > > the same tests. >=20 > Does that mean that all PMDs will pass with the newly added testcase whic= h is for > A corner case in QAT. If that is the case what is the issue in adding tha= t in the main > Test suite. It will get passed in all PMDs, isn't it? Am I missing someth= ing? >=20 > I believe we should not have PMD specific test suites, rather it should b= e based on > Capabilities to identify the cases which should be run for that particula= r PMD. [Fiona] yes, several of the cases should pass on all PMDs. So we could move those into the main suite. But what to do about the negative tests?=20 Example: If a very large data buffer is passed to QAT to compress with dyn = compression, it will get split in the PMD into many smaller requests to the hardware. However if the= number=20 of requests is bigger than can fit on the qp then this will never succeed. = The test validates that the PMD behaves appropriately in this expected error case. T= hat same case would probably not have an error on another device. Maybe we should ju= st leave out such negative tests, but I find them useful as they validate the known beha= viour. The buffer size used in the test is based on the known size QAT can handle = and the=20 corner case in which QAT will return an error. I see 4 options to handle this: 1. Leave out those tests 2. Use a qat-specific test suite only for negative cases which are construc= ted based on specific qat internal meta-data. 3. Include the negative tests in the main suite, but only run them on QAT (= by checking driver type) 4. include the negative tests in the main suite, run them on all, expecting= a FAIL from QAT and a PASS from other devices. My preference is for 2. But up to you.