From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC65EA057B; Tue, 14 Apr 2020 15:05:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A92511C1F6; Tue, 14 Apr 2020 15:05:13 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6110E1C124 for ; Tue, 14 Apr 2020 15:05:12 +0200 (CEST) IronPort-SDR: c9mlqDUZlBZnBCSsI3E2MlLpVzOJuja4pPa8oJz4IC9h3LrYDwQtoSsF+JOhB7uYWf5JecOY+y jmNFJcoPZb/Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 06:05:11 -0700 IronPort-SDR: I2uEq/S37Gg0p+5N9KR55RHprsyCUKBVvHJXfyaOFADulng/+AmXFxkVZ4kLcd+ivLd3ltcwlY gf9skylFaL7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,382,1580803200"; d="scan'208";a="243806491" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 14 Apr 2020 06:05:11 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 06:05:11 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 06:05:10 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 06:04:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fqQuml0ztFfopS/FkrNB5owTQFwQ8A5BFAl0ljM2qiYLRMH4/jE1X0cpg1Ge2Bz3UStS8K6JBYAOacvAfsMbtvV0YtIEZ0W2qF1gd59De/jwvkKe3iFvP1j/39wGto7Fd1E0n50IK47nnZrHcXEW8phanFriPEPpzDB08rF5ikxxVsSmuhBPMHnzfPW81ITbSsEvwExgEwW69XyBRN/BQ/eVsbu7x00y+MYIMNjydbTjCJEp/oZaegExR2DykMrhglQoayqD8deJnWho6t5oIUPN8QuPSvRnrV43yNdf+C/A3hj4Q0WTfJeHCUsYKAXgAPln/tYNkOPwJ8EJ6id2RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lD6oDQGVph1PIPsrnVlP+GGi0MfSqm1/qzC/42eOv4=; b=WIMb/FjlTdykUHPn6FtAc+p9JrRiPuwV1n691X83QEtrghL0fp0KesckkMmCgn07IU3oCVrhWSD8ariC7QQvmPUuW9EQ5MCtNwAIFlu07MXWmXOz+IZYUMRpqzKXfADGejrUzKCTJxSyuZrZ3ptRI/vJTQE0vb9pN7UZUIKma8HGkp7aVDfSNtYKjqEbGG/IkxgO6YyNoqpZVsefIVaRH3hGhWurGhZ4U8eB7yAP9zDqfpEOMjHE7mz1GQF6iz9o40xik0BL9qxwsTpZB+zu18+nbEbnA/AAfaBjGVGFPAEeNQpSpyt1rf7GT7fklEYTHNqPd4Yg1zyRbtey9Eh6tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lD6oDQGVph1PIPsrnVlP+GGi0MfSqm1/qzC/42eOv4=; b=RRg35Y9//0D2h1Y1DCci8pUtZvKtOzoxQBV5j7XJQhVTJTlHgj/6xIoHOa3jZHG2uXanOFqKtQ5OiBGL836uDmPo4NPh2g2f3bf8XFC5XAEhEN6EoGaXwOtID+qXKdbAHwtJG4wFc0wjpytUVEGLLS7zLYRwnLrrnz7uJCvvf30= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SN6PR11MB2782.namprd11.prod.outlook.com (2603:10b6:805:63::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.26; Tue, 14 Apr 2020 13:04:20 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::1893:aaa5:545f:5272%7]) with mapi id 15.20.2900.028; Tue, 14 Apr 2020 13:04:20 +0000 From: "Trahe, Fiona" To: Thomas Monjalon , "Yigit, Ferruh" CC: "Coyle, David" , "dev@dpdk.org" , "Doherty, Declan" , "De Lara Guarch, Pablo" , "Ryan, Brendan" , "shreyansh.jain@nxp.com" , "hemant.agrawal@nxp.com" , "akhil.goyal@nxp.com" , "Anoob Joseph" , Ruifeng Wang , Liron Himi , Nagadheeraj Rottela , Srikanth Jampala , Gagandeep Singh , Jay Zhou , Ravi Kumar , "Richardson, Bruce" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing Thread-Index: AQHWD0YRSFLEpAnIckmYiJUqrzj+1Khy99iAgAV2poCAAALdAIAAJilA Date: Tue, 14 Apr 2020 13:04:19 +0000 Message-ID: References: <20200410142757.31508-1-david.coyle@intel.com> <4478083.44csPzL39Z@thomas> <3280198.8hb0ThOEGa@thomas> In-Reply-To: <3280198.8hb0ThOEGa@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=fiona.trahe@intel.com; x-originating-ip: [192.198.151.171] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa3b31ca-9d46-4b50-aa00-08d7e0745883 x-ms-traffictypediagnostic: SN6PR11MB2782: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0373D94D15 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(39860400002)(396003)(346002)(376002)(366004)(136003)(5660300002)(26005)(316002)(7696005)(966005)(6506007)(478600001)(4326008)(45080400002)(52536014)(71200400001)(55016002)(9686003)(33656002)(2906002)(107886003)(86362001)(64756008)(66946007)(66556008)(6636002)(53546011)(7416002)(186003)(66446008)(8676002)(54906003)(8936002)(81156014)(66476007)(76116006)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gXAlq2uOUBGpuxzoXddLr4q251OFt534lRexP0EgSRUIMeMhqs7cvraM8upytYRdGd6CLCWb5p8slBNQQkGcUvbjYK8M7YRTtsmA7tYYU/QeGygvHXEYsN1KFlwg2wk/2lsDSGeFpXgaFqwLdyNvyVsNX8Px+fHSPfZLlfdLCcgKopi2PtuhiR3LLyDN/VJ6pTr7aNLoRkP2RvnqAaTLY2uWepMmBABbzBWjkadDLXOyPdANgJMPO8QY4I7wtwMlxM2uwUZ+eH4qHTF2rplB0OtDI6tvuAbYFQs65TGtvwXDQlbTguOvJzMbwhRdFmJ/2oFJc3YgWH4U3XfHzt47Q20Mw91WCJl0GOg5/beth/GHyl4MO0Db+zt53c9guiyzv9jchzRNFyqK7deG6a2AVon93anUcuKcpJbPiRtdgmhM1KUG141kl6dhKiFlyk4FnfYN3RCStLrtXATGKU+gVJy1I39i/OG4KQMK9rEPImlFCJfN/iXVZkqkK+RQ/Kswa/MFbDcqpdf28h0cZKprxA== x-ms-exchange-antispam-messagedata: ahvs/t7qvJJYgIZdb09F5WmE9gGmUrv6cwf211wz4oc2Dd5/zzsHpbzK90SSKAZIJ9Iudld6Bh9WJsCwIK7Q6h2KoyFXMM5PGzuSxl/o55IUNktALv0aAelEi2FAW60H6lZCQ/8cEt5oh+L1CQ2xQw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: fa3b31ca-9d46-4b50-aa00-08d7e0745883 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2020 13:04:19.9288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GZSYkwBCcZp/x02GoldYRsFAzM+pvwbGifgKuOy3qVbTyQ6EduFXR3KXs0deTQm1xlErvvZcUrqGsHaJeVRwTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2782 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, David, Ferruh, > -----Original Message----- > Subject: Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-func= tion processing >=20 > 14/04/2020 12:21, Ferruh Yigit: > > On 4/10/2020 11:55 PM, Thomas Monjalon wrote: > > > Hi, > > > > > > Adding more people (crypto PMD maintainers) as Cc. > > > > > > 10/04/2020 16:27, David Coyle: > > >> Introduction > > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > >> > > >> This patchset adds a new AESNI-MB Multi-Function raw device PMD for > > >> utilizing multi-function capabilities of the Intel IPSec Multi Buffe= r > > >> library. > > >> > > >> The aim of this rawdev PMD is to provide a way of combining one or m= ore > > >> common packet-processing functions into a single operation, focused = on > > >> DOCSIS and GPON MAC workloads. This allows these functions to be per= formed > > >> in parallel by the Intel IPSec Multi Buffer library. These functions > > >> include cryptography and CRC/BIP calculations. Performing these func= tions > > >> in parallel as a single operation can enable a significant performan= ce > > >> improvement. > > > > > > I don't know crypto but I don't think using rawdev for crypto operati= ons > > > is an API improvement. > > > > > > Repeating the initial comments from v1 (because got no reply): > > > " > > > As a first impression, I feel it is not the right API. > > > DPDK is based on classes: ethdev, crypto, compress, baseband, regex > > > I want to understand why your features cannot fit in a class. > > > > Hi Thomas, > > > > I asked similar question, and there is already a detailed answer with s= ome > > background of the issue: >=20 > Good to see that you get some reply, Ferruh. >=20 > > > http://inbox.dpdk.org/dev/MN2PR11MB35507D4B96677A41E66440C5E3C30@MN2PR11M= B3550.na > mprd11.prod.outlook.com/ >=20 > I am not convinced. > I don't like rawdev in general. > Rawdev is good only for hardware support which cannot be generic > like SoC, FPGA management or DMA engine. [Fiona] CRC and BIP are not crypto algorithms, they are error detection pro= cesses. So there is no class in DPDK that these readily fit into. There was resistance to adding another xxxddev, and even if one had been ad= ded for error_detection_dev, there would still have been another layer needed to couple this with cryptodev. Various proposals for this have been discuss= ed on the ML in RFC and recent patches, there doesn't seem to be an appetite for this as= a generic API.=20 So it seems that only Intel has software and hardware engines that provide = this specialised feature coupling. In that case rawdev seems like the most appropriate vehicle to expose this. > Here the intent is to use rawdev because we don't find a good API. > API defeat is a no-go. [Fiona] It's not that we haven't found a good API, but that there doesn't s= eem to be a general requirement for such a specialised API =20