DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check
Date: Thu, 16 Apr 2020 16:26:00 +0000	[thread overview]
Message-ID: <SN6PR11MB2880FBB14D3D16D11F8DECA3E4D80@SN6PR11MB2880.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200416090819.1921843-2-pablo.de.lara.guarch@intel.com>

Hi Pablo,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Pablo de Lara
> Sent: Thursday, April 16, 2020 10:08 AM
> To: Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check

///snip///
> +static int
>  test_blockcipher_one_case(const struct blockcipher_test_case *t,
>  	struct rte_mempool *mbuf_pool,
>  	struct rte_mempool *op_mpool,
> @@ -93,11 +136,13 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
>  		uint64_t feat_flags = dev_info.feature_flags;
>  		uint64_t oop_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT;
> 
> -		if (t->feature_mask && BLOCKCIPHER_TEST_FEATURE_OOP) {
> +		if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_OOP) {
[Fiona] Isn't this a fix which should be a separate patch and should be backported to stable releases?

  parent reply	other threads:[~2020-04-16 16:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 10:22 [dpdk-dev] [PATCH " Pablo de Lara
2020-04-14 10:22 ` [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM Pablo de Lara
2020-04-14 10:34   ` Thomas Monjalon
2020-04-14 17:22     ` De Lara Guarch, Pablo
2020-04-14 17:48       ` Thomas Monjalon
2020-04-22  9:16         ` Thomas Monjalon
2020-04-22  9:43           ` Akhil Goyal
2020-04-22 10:56             ` Thomas Monjalon
2020-04-15 10:28   ` Dybkowski, AdamX
2020-04-14 10:35 ` [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check Pablo de Lara
2020-04-14 10:35   ` [dpdk-dev] [PATCH v2 2/2] test/crypto: do not check for IMB_VERSION_NUM Pablo de Lara
2020-04-15 10:30     ` Dybkowski, AdamX
2020-04-14 17:40   ` [dpdk-dev] [PATCH v3 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-14 17:40     ` [dpdk-dev] [PATCH v3 1/2] test/crypto: add capability check Pablo de Lara
2020-04-15 10:31       ` Dybkowski, AdamX
2020-04-16 11:15       ` De Lara Guarch, Pablo
2020-04-14 17:40     ` [dpdk-dev] [PATCH v3 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-15 10:30       ` Dybkowski, AdamX
2020-04-16  9:08     ` [dpdk-dev] [PATCH v4 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-16  9:08       ` [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check Pablo de Lara
2020-04-16 15:35         ` Ruifeng Wang
2020-04-16 16:26         ` Trahe, Fiona [this message]
2020-04-16 16:44           ` De Lara Guarch, Pablo
2020-04-16  9:08       ` [dpdk-dev] [PATCH v4 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-16 15:35         ` Ruifeng Wang
2020-04-16 17:24       ` [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-16 17:24         ` [dpdk-dev] [PATCH v5 1/2] test/crypto: add capability check Pablo de Lara
2020-04-16 17:53           ` Trahe, Fiona
2020-04-16 17:24         ` [dpdk-dev] [PATCH v5 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-16 17:53           ` Trahe, Fiona
2020-04-19 21:15         ` [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase) Akhil Goyal
2020-04-15 10:29   ` [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check Dybkowski, AdamX
2020-04-15  9:16 ` [dpdk-dev] [PATCH " Dybkowski, AdamX
2020-04-15  9:23 ` Dybkowski, AdamX
2020-04-15 10:29 ` Dybkowski, AdamX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2880FBB14D3D16D11F8DECA3E4D80@SN6PR11MB2880.namprd11.prod.outlook.com \
    --to=fiona.trahe@intel.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).