From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF5CFA04DD; Fri, 20 Nov 2020 11:03:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C395F90; Fri, 20 Nov 2020 11:03:38 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 11ADD2AB for ; Fri, 20 Nov 2020 11:03:35 +0100 (CET) IronPort-SDR: Xg7ht0Mp78FSuWHLHR1TCmx1Zo9U4eA4KB/ExvN0IYILLaYyuQfME6NBnCcLT9vLNe7mH+/dZw zo5NthEgxZ0A== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="167938219" X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="167938219" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2020 02:03:35 -0800 IronPort-SDR: c15y2WiaB6WUEpL4HHSRSnCDVDc+uU3K/KwJ6Lg3lpXtDK1lWAL/EfxSDA2Y2UOEmMIyihWSlS AXBq4/XopRRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,356,1599548400"; d="scan'208";a="431525261" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 20 Nov 2020 02:03:35 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 20 Nov 2020 02:03:34 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 20 Nov 2020 02:03:34 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 20 Nov 2020 02:03:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ckrkU6gNgqc9LhvpCKtGSaoxNnKC6eTc2pU7heL5SykZFofu2Mkg9LfHv3HSEMLJypnqtoeQaKc/jA9sBNHwa33uue0l0xygDkTAaJxDENu+yYL1AkU9rlSAKoC8l17F4bOyG8c5/8s3itOxYel0tUchNL+GM1k9MWjAjtrzGGGR7SIoTnzfyAIEtTSZnVaLuchLO7tmNBXE480RD633Xupcvtq8o52ndEQYwD1OQ4PrYVc9pxSJvUV/SbKau8jecC29+uD/tNbNYtHXQbbgasXeDQ23mVOCiRWH+b2OfXYdb0fM5UGedYYZXfKzV3LF/1viZXhNS/BSPTx0gzy95A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lvWgbaklegmU9E6FYcNwJH6/GBY8Y8bSRNdybqvgYvQ=; b=jepnD2ikXXm37axt845vNWq1qfE18quABRf8UYxIVlBqWO5UPKZRzsfURzemOBAubkuXv7B0rN1k4gOjEkSSasg8hVgljtQD2bOH4TfAsr1vgp12GRujjJwEN9DkjCy8IoIe4jlRZEmmFvCbZDyNgj/Cah9ltw23XzgLjpyHRKQTxInDwJ3u3ff+mLUXYNed8xjVjS0zDE33TjZ494KsV81ygFyDPjnn4Za+Q2mGM63tjJx4kn0mhsQBIjnIyHfBDqQT3JvOaYSsvE8LrIk3ZmVh3n74OOABldJzsiZkW+PRTfj2YUBfHNr+/BNu6YACu0xqdyjisV11jKaAwTGDlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lvWgbaklegmU9E6FYcNwJH6/GBY8Y8bSRNdybqvgYvQ=; b=tAb0ZvdZUff0kdNxfJVWoB+QJvxjH/1h+CYwJlBc+l22dVgFUv0X/nTsTvgeJjTM1Ud0/oucJTrVI6xSW6dzTNBUYyCn7YuQ2KPe1EmEPWIgcyC3ftg77/FCHip5AwIKE91fClZksjLR7Dsin5lqHkrptKhYjxV8qnlHreYaYik= Received: from SN6PR11MB3086.namprd11.prod.outlook.com (2603:10b6:805:d6::14) by SN6PR11MB3087.namprd11.prod.outlook.com (2603:10b6:805:d3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Fri, 20 Nov 2020 10:03:30 +0000 Received: from SN6PR11MB3086.namprd11.prod.outlook.com ([fe80::c43c:823:ed48:f538]) by SN6PR11MB3086.namprd11.prod.outlook.com ([fe80::c43c:823:ed48:f538%6]) with mapi id 15.20.3589.022; Fri, 20 Nov 2020 10:03:30 +0000 From: "Mcnamara, John" To: "McDaniel, Timothy" , "jerinj@marvell.com" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "thomas@monjalon.net" Thread-Topic: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference Thread-Index: AQHWvD+T8V4FAJBJUkSOXNvhsp6J5KnQz0bg Date: Fri, 20 Nov 2020 10:03:29 +0000 Message-ID: References: <1605548439-31240-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1605548439-31240-1-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.22] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54c67849-2325-4e57-d8de-08d88d3b8831 x-ms-traffictypediagnostic: SN6PR11MB3087: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mQU9LI0pdEupYPhHBOH6l3sov9V5knyiUimSrrLh5jcxA28zAt6RZ9KEYRytmE2x4ULH0YNdXnIQ+ALk3Eww8hHbzg7z7A9eUTYV+QAP4s49P0jvnzmYqM4Ce9TEHuZmewG8MYmgbi9NVFvrPJsXyYra3rU3GsQ+1GXduDdBWxT2RYu3XCPwlhPO6ecodatkGIf3LEog4CbLUfR0anroRgt7RwKjot8w6210mdIjGoXridhMhBe0O2O/EHuQJ+u/039fJTpfZUR3GahZL7WW/fMrjXdBnkjiAm+D7UOQFf6HAcbYFEt5OiTIiAuHkivV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3086.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(55016002)(54906003)(9686003)(33656002)(26005)(2906002)(186003)(7696005)(110136005)(6506007)(316002)(52536014)(86362001)(4326008)(66946007)(76116006)(8936002)(5660300002)(83380400001)(66446008)(66556008)(64756008)(66476007)(71200400001)(478600001)(4744005)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: BO0B9nN9reG+6SRwWP2Pf8Yj2XxMaHsYJlXzOtX2yTwGMgzQKmpk76898g1/EKenurj9BM0oM7/vUfL+jxorEDc5MCnZ0RXG6npwh4/XsQaSzClztBqpVALkhyQ4DEMjU3i6TZ0DhV12hEkBwc03owuofApPKzfL95Viek/HJnsKOdOyd7JA4Jka6kP1rj8BA9srlahycMi9+6VvuN2B3plX0lvv2CoAHn+BMI1JmnR1MA8jRkbwS1hl8BuDBUbLwRo32q+G2NzKEx8MRqYtqLeTRU1FuBBVEpxXMjfQaOYTOuyi6R75XEpXEno1NMnkw9LLuUIokWLjBw7HHaGFeitbAcKzkSl2tgxWRZ650lgJSOH+O+4daOcLAo8ozpedCwFemnZyXeAgo2SS2BljYOGfEqI1UyuJerFlNHxRh7Z53jBVpcqCIGLXFPAuYBLnIR8R1mKoZ57Edf/7HU2xrsgWhC45PgFltBFUR1QglMg00PrcB9c2q1F69s81yNskPW7nw9hFoPpTq9/zBdzvCGxWnSx6Q2OqR6AY3w7r7a+JoT7yM6rFye9FwWZrc0yTHyeJEmRWt1ajjOKDewKnvO3XlK1D1VQErucqzIrIYPCl73ebQv/LoXXcpEk6t1NVREpiOrhxR5kkDvRxIczFjtoh3Hj76SulY0zHtvps9OUChZFejwK0JNVO0VZ61HE5sMSSS4nH6Af3FMMB/u4MhN8jOnfSS6w0pIZFLkHxwvgTlRp+wcLUmnx7vUjUck6/oL23MR1PdqOGWzBWPq9G7Ysk9WfiRVx7LFpRv4fCiwD4+PUGXDyYTldlQQ4sfTGEMXpB+6UVgDZU+uOudWZQkbFLqwQkFaLgnVN03cBqDHb4a5YjOg+4ipmQtyWO5MrQjx4bKdrNuSc9u4NLS1do+w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3086.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54c67849-2325-4e57-d8de-08d88d3b8831 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2020 10:03:29.9360 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pJMbNxTSCAuHdSxsHys+heKqeY836VNVPv9CQTrJKwuHvR/RCuMPDloJaHmfZmAoXECciRwD1WW6iiOapPcY8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3087 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Timothy McDaniel > Sent: Monday, November 16, 2020 5:41 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com; thomas@monjalon.net > Subject: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference >=20 > Add NULL check before using t->mbuf_pool. >=20 > Coverity issue: 363719 > Fixes: 83326 ("event/dlb: add PMD self-tests") This is similar to a fix on the dlb2 driver which fixed a similar Coverity = defect (according to the last Coverity run). So, on that basis, I'll ack th= is patch. Jerin, could you try merge this for RC5 if possible. Acked-by: John McNamara