From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F31F6A04A7; Tue, 5 May 2020 19:22:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 491311D68F; Tue, 5 May 2020 19:22:45 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 85C9CA3 for ; Tue, 5 May 2020 19:22:43 +0200 (CEST) IronPort-SDR: 5BDuv/6Zg0v4vZuR8WxnmOynSro0vAzSPGQvhfbUH8nVB9GMrei7skzO6ZEXEswFPtqzgLMHRM ilu1jsZt2H4g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 10:22:42 -0700 IronPort-SDR: 9SuZUEmAkANYk8k9v2BEc4fGh3N6J/UjF2CF2GsM0RIO1crIJCnFgC7a6I680RdIaNNM61ntmC ivH1E/0hmZEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,356,1583222400"; d="scan'208";a="304539978" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by FMSMGA003.fm.intel.com with ESMTP; 05 May 2020 10:22:42 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 10:22:42 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 5 May 2020 10:22:41 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 5 May 2020 10:22:41 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 5 May 2020 10:22:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g/ziqUAI+9JSA/Opmob1PqHyTk9RTnFWKBh/OWMi8RBU9/Gm5rQNcfbk3wAHT4AfILSwTNaxfs1s50RYvTR+X4naWGF5ivLuEW7ce+B9mNngr6YqFvTlIYCRhWaXbbKdrF4GkZoYPuoyY9dFN1lyxkSDBtjPWSEIGv2zcKbFCB7eaySxgYTYittFV/McixyG/o7tppEVlXwYPXCnOXHlgDJs5ARzUakalKb3DnXGxCSYEd+qrMLaCtt/kG4SSNdra+wGrwsltoY6vridugXru1A22vH7EpDWu9bs4P9dVkLAntImHPilvpH0m97a+RbXDyD1nGJneQxX52bfOny20g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zfpi/WLx8q89EiD2SQ+UAvb+G62a9hSuT2xWpW+TcRg=; b=G6NNu9zzk+ryXJ9rX//KnuAuM3/47P7Oi/tL/F3PjrqdFlSUPAN0InlU0vjRI8UQNAgPIhgTTlvzN4XdlaHmuJ8x6YiNTnH0WnSRyGJKqlQuarbIm38RSH/gSRRgqioa2zAmFj7C8Dj0qIUdLAti8c+GnHjLqeoCQdxAJ0pwM7B572vScm2oumr5opW9sT6f9a7JNEQXjHEgdtWn9UQp8vgymPeUSOZgsf0WTLz8NCupZALIe/pPJTdSuzkC/aNG/8jNkmBJbqsweVPa3WkriayZAzit+Q9Xxnr/E99wbdgD0fzsyZsS4FQllzYI2pAmPP1/OGlQIbEZvgUjyJpATw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zfpi/WLx8q89EiD2SQ+UAvb+G62a9hSuT2xWpW+TcRg=; b=Pshg49yz4sXR37DV0ns+Zx6+nqp+jttlfEEF6PRpO09GsTtKOJNDaS8p2zpQ2u60nFMsT68T8BI9Y5RLqa41FWorvT5CFVGNUh4YIXikEqyzisxATDt53urmdKT3pmjWUlvExT0/7MITrQl7hwiYB5952vQ7yiH8tLXKrOV3wQg= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB3453.namprd11.prod.outlook.com (2603:10b6:805:c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Tue, 5 May 2020 17:22:39 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40%7]) with mapi id 15.20.2958.029; Tue, 5 May 2020 17:22:38 +0000 From: "De Lara Guarch, Pablo" To: Kevin Traynor , "dev@dpdk.org" CC: "david.marchand@redhat.com" Thread-Topic: [PATCH] crypto/kasumi: fix gcc 10 fno-common error Thread-Index: AQHWItxuBbamIgqq00a+u1FNPYT0vKiZvY/g Date: Tue, 5 May 2020 17:22:38 +0000 Message-ID: References: <20200505125442.18048-1-ktraynor@redhat.com> In-Reply-To: <20200505125442.18048-1-ktraynor@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2125a01a-b5c2-46f5-516a-08d7f118e930 x-ms-traffictypediagnostic: SN6PR11MB3453: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 0394259C80 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V+W0fqNboQWExykOnTT6Us4sA6OIMMfDDAux8sYoQMKCg+pJ94dPbUH9i3qfjeQH3nSK1tzx5gWagpAiv7sPVCF2+P6wVLcQFL6YwpprErOfvCUNZ04BAhFbGv2kCH43nD8CbiheQY2oE1u4mXWlgV7ByKKPwZC4KfMhX6N5xuO2tYRj3lGMFgoX60cUSsnDS6w2fTkVg6cM+JCcRzxsSaVahXvdAIdCAfhwQ/ezLoU61Y+ZyTofPCfGX2g2Oumb/N3Lpahir+lMictuvtMabqxPTudHFS+stun5SdTZP3deA3MLXfUKRbdpY3/O5X0eOLLNuEf3SQvJ3wZkTwi1pmvcPsbT/kSD7+xxyW9qiwQjbAI6ailEEF4dCEJi4EA2e6X5qxL01rTR/3zdzqgYZniDEN8nJIdj1lIWIDzvyzDRz/fdlXZSQLECRM2giSAKysaTHwr4bHYgKQkrVPwGaSGpCKOKKxV9nCSmQcPq3qCOiPAcmCyf60eJpKdjmreHVnqdsv4x57VC3RJQhhe4Nw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(33430700001)(6506007)(186003)(53546011)(26005)(66946007)(52536014)(7696005)(55236004)(76116006)(66446008)(64756008)(66556008)(66476007)(5660300002)(33656002)(33440700001)(8936002)(2906002)(498600001)(71200400001)(8676002)(4326008)(86362001)(55016002)(110136005)(9686003)(4744005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: N1OusnDRzETvAll4e+KjzyMrRwezrSfSU2vAUkNi8tzzkThDV8V3bmyeyLPyFNRLVExG0r9gWpJn7ztF3EYgm1ssJCz/xb6+Jd2ZiZ5A1GMRfuTV4gBsT3XmHUT9uJkK038QqMH9S3B2zvA9fcFwytkT5qtB2/U89Uizr7l9yolQcDh0ZjW4ytc+YgUkMqaLjudBKpakS2raRxQE0iORhVK2Dnsj8P+COpf4hYeyvOlfM4e9z/B3WmjWurAEbvG+vVOMK9Q2jT1jg6VQ5lspvtqMv/PmS9w/lCYDongGajL2bZtgZDtmzP0Oh+wEkb/uOQtYawaH8tHyiqdrCWJ8hfZrFvkG3meqRtCkuMVhp0AnzFB/kVanO6IbQR1pqFOuK+pv/AzfAl80U5t7UzCepOT0GxqDw8JbmDSQjESWzvCVba2OA19u93bP9004PL/DWrmRwShPFx8sWLftLVTz3KeheQN8+9MGB/sucRrMwcjvbfbBUW89rzQ5u80Y85ziwA8xJZ5/A0db65aJ1bZsvgpcKx91MFFtXrU1jTdfN5IoCLDQk9jiYMr2kNzRVAJ4CDAGnJk8xPemCFTe00murnZuCcWIcciolvINamRyTLC8b7p+xNcgc6xL/bw/xvHDPzdNTod6r/VrtkBk4OME2Uk241YZrLD/OqGO4CrA+WisuMiXYtJi/XSGpDZ+SfZuFWokmRg6W4XyteUYfLtWxP1lnM4bHXXl5b8yM0hYF+Gy6zGt38TvYBImMWQsXaU4lWwhK67a/I3NwLVLGN82NO+vkV4zycwtNruTDuRj06Q= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2125a01a-b5c2-46f5-516a-08d7f118e930 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2020 17:22:38.8452 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KgTHPfJ22SFMyEj8LrT50Hz6eof6jrjCCUwdf5wca6gemsOvtJtqYsoR3PsYN8JKQOAxn1OB3F59UCeAEsSGRY7GnwVaH5Q7JoWi8rewxbo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3453 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kevin, > -----Original Message----- > From: Kevin Traynor > Sent: Tuesday, May 5, 2020 1:55 PM > To: dev@dpdk.org; De Lara Guarch, Pablo > Cc: david.marchand@redhat.com; Kevin Traynor > Subject: [PATCH] crypto/kasumi: fix gcc 10 fno-common error >=20 > gcc 10 defaults to fno-common and it reports: >=20 > crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0): > multiple definition of `rte_kasumi_pmd_ops'; > crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here >=20 > Fix by making rte_kasumi_pmd_ops extern in the header file. >=20 > Signed-off-by: Kevin Traynor Patch looks good, but you are missing fixes line and CC stable, right? Apart from that: Acked-by: Pablo de Lara