DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "akhil.goyal@intel.com" <akhil.goyal@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix out-of-place encryption
Date: Thu, 16 Apr 2020 08:52:48 +0000	[thread overview]
Message-ID: <SN6PR11MB31018BFD276AA39E6A9905B784D80@SN6PR11MB3101.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB3168E7D48A252C881C000350E6DB0@VI1PR04MB3168.eurprd04.prod.outlook.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Akhil Goyal
> Sent: Wednesday, April 15, 2020 8:23 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org;
> akhil.goyal@intel.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] crypto/openssl: fix out-of-place encryption
> 
> Hi Pablo,
> 
> > When authenticating after encrypting, if the operation is
> > out-of-place, the destination buffer is the one that will get
> > authenticated.
> > If the cipher offset is higher than the authentication offset, it
> > means that part of the text to authenticate will be plaintext, so this
> > needs to get copied to the destination buffer, or the result will be
> > incorrect.
> >
> > Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL
> > library")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> 
> Do we have a test case in app/test for this case? If not, we should probably add
> it.

Hi Akhil,

Yes, we do. In test_cryptodev_aes_test_vectors.h, the "AES-128-CBC HMAC-SHA1 Encryption Digest OOP Offset"
is testing this case, in aes_chain_test_cases[].

Thanks,
Pablo

  reply	other threads:[~2020-04-16  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 17:25 Pablo de Lara
2020-04-15 19:22 ` Akhil Goyal
2020-04-16  8:52   ` De Lara Guarch, Pablo [this message]
2020-04-17 20:56     ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB31018BFD276AA39E6A9905B784D80@SN6PR11MB3101.namprd11.prod.outlook.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=akhil.goyal@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).