Re: [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Konstantin,

Just a small comment.

> -----Original Message-----
> From: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Sent: Friday, April 3, 2020 4:56 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Subject: [PATCH v2 1/2] crypto/aesni_mb: support CPU crypto
> 
> Add support for CPU crypto mode by introducing required handler.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  doc/guides/cryptodevs/aesni_mb.rst            |   3 +
>  doc/guides/cryptodevs/features/aesni_mb.ini   |   1 +
>  .../crypto/aesni_mb/aesni_mb_pmd_private.h    |   5 +-
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c    | 386 ++++++++++++++++--
>  .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c    |   2 +
>  5 files changed, 363 insertions(+), 34 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/aesni_mb.rst
> b/doc/guides/cryptodevs/aesni_mb.rst
> index 465d20d88..02a0a499d 100644
> --- a/doc/guides/cryptodevs/aesni_mb.rst
> +++ b/doc/guides/cryptodevs/aesni_mb.rst
> @@ -12,6 +12,9 @@ support for utilizing Intel multi buffer library, see the white
> paper
> 
>  The AES-NI MB PMD has current only been tested on Fedora 21 64-bit with gcc.
> 
> +The AES-NI GCM PMD supports synchronous mode of operation with
> +``rte_cryptodev_sym_cpu_crypto_process`` function call.

This should be AES-NI MB PMD. Also, this patch needs rebasing.

Apart from this, rest looks good:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>