From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBD40A0350; Mon, 11 May 2020 11:54:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 344111C066; Mon, 11 May 2020 11:54:58 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2E4FB1C066 for ; Mon, 11 May 2020 11:54:56 +0200 (CEST) IronPort-SDR: Aq7NWw5XEHqj6YqtHiWKyU/0pNvxEel+R5KXVWCabS+oSPAzdImx7mg/6xh4RAJQDx28p7CUy9 v2s7VHVtJ1Wg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 02:54:55 -0700 IronPort-SDR: piZtZm9Ms3AjP/72sTJeQg56Xy+i1vt/6ujPpSJzu+eLDvPg3ovEiXHzoR/TEYjeFOBssdLeT5 xwimAW8W8Kww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,379,1583222400"; d="scan'208";a="297632379" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga008.jf.intel.com with ESMTP; 11 May 2020 02:54:54 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 02:54:54 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX160.amr.corp.intel.com (10.22.226.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 02:54:54 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 May 2020 02:54:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QeroiFSQ05ipvWOYXpAvlNNc38hT5P5jENo21WftbYb2PacdlYPhmdrWVcwapxc7qZiDK7N7O6xiJ729kkeArtOmUGM7dGKsceeVB4KxoSS45yb5+NgZH4Y5emWO2vi5iESORD2r+vlhjlzQ8RYOksujHMn60qAu5QxGLAjVkGK2D6GW4uVEKbIAp7IgiwiLoVVpbWh7Oqd+3v5qVgOPI5ysBx2vaQrY069RYxHswnnv08AHJC6MT68kl3si6dJKuEoKYUSEOtwq+Q2WAip4WGg1yKAfO+qDfamRdHe243TSkOv3FC1QWdeMG6GGk54dDhm6yyUsxGuwOsg1SrvTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B2hhqPKppm+OIYyupAcuDpfnLWhIPfZ4CxkL+VqxA+g=; b=EkdkR3/zf3cnkTAEj8XAoxc/izxGAdb9vrrJzsmOzKskvwxKkBPjoVuH91sCbUSVkCfoIhY0Nck0ahbQu2TSo+B6YEWryb7BSxA+4WStLLv0+mdb5T7lqChc3qJIIHiTDGBnJbUdVQRJZsO60P14chWqbD6Sm2JzS4RYN8CwtEfAFVpCTWT3RguvVrES+yCj3/c5lHVoSOe6MXf0uC9m94/XjlKIGH9SvqP/9048LvtKO//GmLkzQTcCOoeTyhoGwUJ+DTTmO/4JHqTGmKi5xdcxU6cPBtQTmDduFrayrEiVCoOZfsklToW5eH6BoIP4s7O3UPdsnnUiS2hMC40cUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B2hhqPKppm+OIYyupAcuDpfnLWhIPfZ4CxkL+VqxA+g=; b=Lt8ZvzVzZxZXtVnTUY8jA0j5pw+MKb5nDeI2uhMY7TIRMOAIQNVtFdC6aAkmfBpe4KtqOfzVU0ictnzq84YTUDiIXWxoD3APjZtB7ec4H2wExKhK9Chpyuml36K+HuVF4yWTNfRurCVtE+KSyM0aKAyDxb3/wxuv6scxOLhf19Y= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB2717.namprd11.prod.outlook.com (2603:10b6:805:60::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Mon, 11 May 2020 09:54:52 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40%7]) with mapi id 15.20.2958.035; Mon, 11 May 2020 09:54:52 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "Doherty, Declan" , "asomalap@amd.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Trahe, Fiona" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "G.Singh@nxp.com" , "hemant.agrawal@nxp.com" , "jianjay.zhou@huawei.com" , "Dybkowski, AdamX" , "apeksha.gupta@nxp.com" Thread-Topic: [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data Thread-Index: AQHWJlpeT+rSwW7/K0uGQm7U+o+dHaiipduA Date: Mon, 11 May 2020 09:54:52 +0000 Message-ID: References: <20200504215811.15951-1-akhil.goyal@nxp.com> <20200509231217.8219-1-akhil.goyal@nxp.com> <20200509231217.8219-2-akhil.goyal@nxp.com> In-Reply-To: <20200509231217.8219-2-akhil.goyal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d9a49304-223e-4c27-7688-08d7f5915a04 x-ms-traffictypediagnostic: SN6PR11MB2717: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZDqUDbWNlDw/0qsBz7j8rClevU5cWYRrFHMMgpL6m66oIzNMvjIC9YsJgmLMhd+Ak4ZDG29U7bDKw1paTYJjAlY54A2OFNmyll/rmPBcuBgZN5yetR2wDs6eBls62UPluMFfMCFZZlrwq9wIfe+l80nW1QtsrrGBZ6pm7MiLYnYKCTUL9yUwHlCWrpVVtTApPswccrGbc7GujhwRr6ZcNBB0lOyBUvluae9J+kC11fv6vbzuStB0Yw2aobQ5ppBEUNB/KulaXvQrXmxkCIBKi+mcvv14Uw84LTjsuUw18SxJ2OdaMVexz9Ge9kifya2GowE7r+cdH7Ffo6Mfyy+rNChe49aznpvz+kLR/TeAUKJpIv+8er8X112oG589GgRn3nRdt9fzC0EWbpR3pgrkULaOvtwac0TO2NrGISpqlAxpTP+FjscpOqGnXZDhNqz3sOSQqo7dclonatAVCPp/mgRkbJ1mROP2hjYUmk6TB1bEhYarmETdWy3hirR0EC+9PfwGVkhPM1LU9C3MHfnF9A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(376002)(346002)(396003)(39860400002)(136003)(33430700001)(186003)(55236004)(66946007)(53546011)(2906002)(4326008)(26005)(110136005)(52536014)(55016002)(478600001)(9686003)(6506007)(316002)(54906003)(8676002)(8936002)(7696005)(7416002)(66476007)(66556008)(86362001)(33656002)(71200400001)(66446008)(33440700001)(64756008)(76116006)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 6s5wA0UkjVF9C+/mF+L0ChkhgTS/F+efMC3/GY24tyOjHUe9GNxSgXTUVP/kl40/1PiyPZUny+gFqt+RSs6Idbahas8nD5vzzKOGkKCqeFqT+gKwVP8pNMhL1bz/CNBRtx7bBtKhLAd7Rqs/1MktPqOCfh7XcL2LSCNkXHQQ3WcybmDIf1ndDFguikQFgKBSlHLGxFPvpDGaIR1d29U+tQuJafmmLRy/U2Wif1vO57ffQEuhQednhddOoJlupNfM8XvLbAyIuB19p8KnmY+l3+eMhjAtGjLN4uSLknmScqZVepSaKCArd+zXOGysRK7/KbCDrtqSagQdGC8TPXDVecH6fOgZWDbRGQrSfVxTlcb6AZFCFQiyxQcB6ofuJYBEKJPa2UuwKYjB+YXszOfv/v88Pdq/jCu81C7UXejuyqKk/V/uyNMlEXwhFJnBaErmTcpQZnqQ5DUWxZAjbh0yorYmgOGq6ZWFlHAjfdHux9wA/z7gn/4cuRPFhKV9O8Ya Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d9a49304-223e-4c27-7688-08d7f5915a04 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 09:54:52.4570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9NIcgnKf5zF8CXFGmgreB35qPzAkNh5cmjTQXytq6iZVEPO7LcpF798S41PpG4wBDK+LLr8yLYoXr4aDoDyW1N0IfC6JXs5joJD2T8Ig9FU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2717 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Sunday, May 10, 2020 12:12 AM > To: dev@dpdk.org > Cc: Ruifeng.Wang@arm.com; Doherty, Declan ; > asomalap@amd.com; anoobj@marvell.com; Zhang, Roy Fan > ; Trahe, Fiona ; > rnagadheeraj@marvell.com; adwivedi@marvell.com; G.Singh@nxp.com; > hemant.agrawal@nxp.com; jianjay.zhou@huawei.com; De Lara Guarch, Pablo > ; Dybkowski, AdamX > ; apeksha.gupta@nxp.com; Akhil Goyal > > Subject: [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned = data >=20 > Some wireless algos like SNOW, ZUC may support input data in bits which a= re > not byte aligned. However, not all PMDs can support this requirement. Hen= ce > added a new feature flag RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA > to identify which all PMDs can support non-byte aligned data. >=20 > Signed-off-by: Akhil Goyal > Acked-by: Fiona Trahe On these PMDs, some of these algorithms do not support non byte aligned dat= a. For instance, for ZUC, the cipher algorithm doesn't support length in bits, but the authentication algorithm does. All test pass because in the tests we are doing encryption in bytes and the= n we mask off the bits not used. Wonder if we need two different flags for this, one for cipher and another = one for authentication. Maybe again this is not enough, since we should have a flag per algorithm..= . and starting with this flag is a step forward. What do you think? Thanks for looking into this! Pablo