From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7677DA04DC; Tue, 20 Oct 2020 17:33:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E9EEACDF; Tue, 20 Oct 2020 17:33:57 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 6E934ACDF for ; Tue, 20 Oct 2020 17:33:54 +0200 (CEST) IronPort-SDR: 8wwHTZA9pFYBmVO3OSMBoGVONW2Kkap0WJTvP0N+y0Maqsd56XGqmFUWnU4/pzwCrkQDscjruZ 5WfVWvy3aEyw== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="167319561" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="167319561" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 08:33:51 -0700 IronPort-SDR: 2mBiI47iabFJex/NXz5aZKo92ZeWl1nJ6K8ykwQEdm+mxvmPztPVBPCv6gMmL8vusRuUyjqX/B FVM+rjES6Ibw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="358563309" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2020 08:33:50 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 08:33:50 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 08:33:49 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 08:33:49 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 08:33:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DrP+uMmrRBFiDbU/nP0n0A/HD2PRG+ylBoYUZg83ocLjmzelnDzudWL7lGAmHubA1h5YrvAU3FqjKQWb0d6KMfov86wwmcnEMnD2OdKpmThCNMFIXbQQno8MYVLCl/Ha676HB9e1OmXcqMKI1MXM12Z0DkxFe/EXNBFvMbhcGV1/LxcfKauXPz/PrJMrSsP5aQNzVBCvpJjsXCgoKBIkDi6Gj/tgVSIRT+DaNAh6wZ7eszaIGFQ4UDEWn7s95iiOCFmo5C2mltbDmwi0xxIhhiNIbpxT27mUDr4DvguApiAbdU++0TkT5YzPFCjy3U/wwbN6w0iciExFNtUmua+Liw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWUS6AlE8wSXu6UNW6LD+NDlSVV2jw50/IgHqZ1NOtU=; b=AyTxdyBW2aSB33UJk2vaoEq/68QvTdSyy8RWR2Sjd4XKOH/pG2mS0aQSsQfVdcLoUn9N20QfT4udkQvI6QwU5UNWQg3I4XLCgKGP9Sn9yTU4VyOEJEAt4oY77pnZm3DgmFs5KzEMID2jtfCcvpYEABgq6EugdDAf57KbTkytCIA05Lz6l+XjRkB6Le43lN8iP/UZwefI8JJv2cV07QkSLzpdzROf1LqKr640UcYOc2p6CCgErMKjIr0PHiMCliyTdEewHyh3gxtXR40I3bTa7puwfukl10+jjY/xiG99QwZpTCUhLX0EiRqxXgu5eLqMGa6Qc/cbeaFuAXXSVbBlXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWUS6AlE8wSXu6UNW6LD+NDlSVV2jw50/IgHqZ1NOtU=; b=X0zsObGYomNzRVlP4LXGMzUsQ3qqWCAt79387rxgOgGv5nwDA0gORor41cYpemY3zbeSoU7b7xv5/i9QZbvMEfCIVA448yihYVIxsEH1UzF/qReKywvQbRL/4qQWGXecGkEnfGzwgtHmXPEjAOaIttoklYiIqfJg+KUkCkVUo3g= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SN6PR11MB3487.namprd11.prod.outlook.com (2603:10b6:805:c3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Tue, 20 Oct 2020 15:33:43 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616%7]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 15:33:43 +0000 From: "McDaniel, Timothy" To: Thomas Monjalon , "Eads, Gage" CC: "Richardson, Bruce" , Jerin Jacob , "Mcnamara, John" , "Kovacevic, Marko" , Ray Kinsella , Neil Horman , dpdk-dev , "Carrillo, Erik G" , "Van Haaren, Harry" , Jerin Jacob , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure Thread-Index: AQHWpSuei/E6j1Yiyk6N717ECjYmz6memryAgAICegCAAAGMAIAAAvGg Date: Tue, 20 Oct 2020 15:33:42 +0000 Message-ID: References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> <44534720.QNPfj4FMZr@thomas> In-Reply-To: <44534720.QNPfj4FMZr@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 206b2210-a6dc-4f36-dcff-08d8750d86e0 x-ms-traffictypediagnostic: SN6PR11MB3487: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YmfHkfhf+wocMpLPvVjitRRsPryTcQ4d9YUCI94Zi1v9YU1tJGmQZgQaIgFuzCE5eyzQUYppej8v+97EMSo4389USqMjSu+mvWDUCF39WvGZtjZarJnPNL9Ab0L3b+uKmgLsoJ3Y1G7lSAZ6nVSCqec4yICnuJws4NqG/XLzSYoAIe0hSvpRHcz4GEoWYq+NufEojX5NldFlvD/SLhhGYtpqPmQjYngb29VHgGTzUH3pxkaWgZLCPs6lCCZIt5APpIRClrFO7KeXf5STce0faBHKfYfzyz58jUuwUGXHwzRLWFcC2jiLUR/EPIodr5g3Rgq1YDkHVBoUEBy1P4oYug== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(71200400001)(4326008)(66946007)(9686003)(316002)(2906002)(7696005)(52536014)(53546011)(6506007)(8676002)(6636002)(66476007)(33656002)(86362001)(76116006)(66556008)(478600001)(186003)(8936002)(5660300002)(55016002)(54906003)(83380400001)(64756008)(66446008)(110136005)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: jMmO06vx/NquWAoxsYrkH+SEz/zjX9bFYn7F+k1xgrcy5LBmLmCgE1REYPQ/tw6Z/O6Y3SoUSdGuQchoMQ6i1WF2ywmvhktVXvxCcQlc+A96+jEqHwXo5l2CNF/3VbquuXnMgt80OIKhb7GdnlhPbiGGaHkXs8eqmRU4XMNW50gTfiL8ADNVVZ8N8xNfbNdbkGz/aL+QH5pR0BEuXkSeUGmHE6G71QVWALeNA/hVDuYRSuJgacsCcnxHIYud7GDGVpZx51c9i4Dz4/cln+Tb5B9p6KqZoB54nO9GSbrTp7gGErGae8FjdtyNWOxCGE70QWJcar1mCpkX9tchHTKQzrN2JGqETfSGv8k/MnfBGpK/rarEysVNPGP4kMbmoBjKJ720KssV2mS3aDX2fQQBw8ceQKIwSDEPjHMqG1ajR/TtEtVkt+r3gUpYW4PTNEZ4zTQVxPAvir9B+07VQFyNr8rReCO+GLMw/85iVjbx3Y0TAx32fe3OqOtIugMVnqr3JliDMLFCKGYmF05jPLKRbQFdDQmKBvfBN0lQMJ1O26GLDmNM/+PdwJc3PIekuXEaBoXT+YHwc2gVlZoi3kuOJR3GrtHNzUr+aVuTAUAe3pwpLTogLvzIn26FPPvRouESbl8hgjN5XMgF8rZj9nwGBg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 206b2210-a6dc-4f36-dcff-08d8750d86e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 15:33:42.9014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Qe67lKdcy5+6iellYTNuhnEL0OZsrcFgMT9D1GedPl+cPnauCVEnetHiOXhe+PQYSetb4IOtiXflcCCsNMM9J7vYtaR0jmHX19tjnlY/bCg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3487 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, October 20, 2020 10:21 AM > To: McDaniel, Timothy ; Eads, Gage > > Cc: Richardson, Bruce ; Jerin Jacob > ; Mcnamara, John ; > Kovacevic, Marko ; Ray Kinsella > ; Neil Horman ; dpdk-dev > ; Carrillo, Erik G ; Van Haaren,= Harry > ; Jerin Jacob ; > david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation an= d > meson build infrastructure >=20 > 20/10/2020 17:17, McDaniel, Timothy: > > From: Bruce Richardson > > > On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > > > > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > > > > wrote: > > > > > > > > > > Adds the meson build infrastructure, which includes > > > > > compile-time constants in rte_config.h. DLB2 is > > > > > only supported on Linux X86 platforms at this time. > > > > > > > > > > Signed-off-by: Timothy McDaniel > > > > > Reviewed-by: Gage Eads > > > > > --- > > > > > --- a/drivers/event/meson.build > > > > > +++ b/drivers/event/meson.build > > > > > @@ -10,6 +10,9 @@ if not (toolchain =3D=3D 'gcc' and > > > cc.version().version_compare('<4.8.6') and > > > > > dpdk_conf.has('RTE_ARCH_ARM64')) > > > > > drivers +=3D 'octeontx' > > > > > endif > > > > > +if (dpdk_conf.has('RTE_ARCH_X86_64') and is_linux) > > > > > + drivers +=3D 'dlb2' > > > > > +endif > > > > > > > > Please add the message in "Content Skipped" section, > > > > Reference: grep "reason" in drivers/vdpa/mlx5/meson.build > > > > > > > > > > The octeontx case is also wrong in this file, IMHO. Rather than check= ing > > > things in the event level and adding things to the list, the list sho= uld > > > just be static. If something should be optionally compiled, then chec= k the > > > conditions in the driver meson.build file itself and add "build=3Dfal= se" to > > > disable, setting "reason" to the cause of it being disabled. This kee= ps all > > > the logic about a driver in the other file, rather than someone havin= g to > > > look in multiple places for why something is or isn't getting built > > > properly. > > > > > > Regards, > > > /Bruce > > > > Due to time constraints, I would prefer to take these issues up in a fu= ture > release. >=20 > If you have strong time constraints to complete everything, > then it is better to postpone the feature to the next release. >=20 You read too much into my comment.=20 My point is that there does not seem to be community consensus on this issu= e, so why are we debating it at this point in the release cycle. There are pl= enty of examples doing exactly what I am doing.