From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F62CA04BC; Fri, 9 Oct 2020 17:21:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F34EF1D502; Fri, 9 Oct 2020 17:21:53 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 956CB1D15D for ; Fri, 9 Oct 2020 17:21:52 +0200 (CEST) IronPort-SDR: acXAnNGCLW2fF9UIzhJ3QlbKQi/O8TATkw0H9dIMMD1eFyanNY5k9T5aycmIaMa1yFuLcnJwnQ fnoRjgE1zQTQ== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="165559261" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="165559261" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 08:21:48 -0700 IronPort-SDR: mUQY1ulpfUvGWV1v/dzL/9EnRzE6emYdC67LV0R7lZ1BGHZ+mcfPAry2jc9wPC3BmTfgV5jQDc e3IDguLTCgXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="312585999" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 09 Oct 2020 08:21:48 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 08:21:48 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Oct 2020 08:21:48 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 9 Oct 2020 08:21:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ykke15RmMVrfOFl+u3noniKkzxohZ1ZOge6j0hVWQGshkUxExrk8XXE3ijOGJgA2Zfhd1MBTCHSGfrNUGbmu5T8KTADawrFVAbzJfLr9rUdJmI0bnTfx9Hm8vak9/uvNQe0uk7c4bnHsTnNcu7B3W5n39z/BNRztqISGXzI7X3PUL9fA55LIl5lURJEUW0k9DAlOA+06z4XyZGiaxTdh2njQeDDrvQ0c7q1kZnlHUNLxZQ1ZDPsZCXm22V8ojmkHyvKAQezRqMMVpGHcaInNQ0W04/11L1Utp4Q0NdzN3KwjJeJMMrPZVXLQtrTBPoLoWocRz3DQhxkvMto6/5vVBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qvZi60M4+WCEiPviaJWLshddjsbijKJ6wpI9yXB3MAg=; b=hNroTkqwY1fJ2nJxPwGZgEb9e9B5M6bm/l6aaQ1KpYKDfC1B2pt0PG9/jrcUiI/rTgEjArWWQEWrZcj6LEJGg3sSaQs+Y7XDUf6wqc0GCRzYKR+cWfWo54bdJdHBoJiR2Qf9cIZh3ag+s7pyU1GJ//1/fqQMrSGwOE7PiQSPf+XS9KdP7ItLVcs4OqcUhrEFmd4vPbD4tUXzW7remu13LgUurCMzlCzkSBu2m3PyiBG6N4Ce0ntl9/N9vM0w7gCPD8g8HPC4Ely9WBT4cZRey2uiasDHmgCEVdxABEIetfGN8A/WqPGOItGB7JQlsHT8Z3QCYFskFiCXNJcT0yTifQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qvZi60M4+WCEiPviaJWLshddjsbijKJ6wpI9yXB3MAg=; b=aYRHemHys/he04krwFJsV5pxCBECKHZcK9D847mjSCflYJnMB9sXt0DknbqTiy7TpGiRE2HbeZJbbVlUvbjk8Fd38T3MMvf3FyA+T/Sm3r0R6ihCxvl3hlXzLBn2pPBxt3XbS/k0lbRZL4m29bfS6scGqyFCtivKou+ZYcqi5Fo= Received: from SN6PR11MB3103.namprd11.prod.outlook.com (2603:10b6:805:d7::13) by SN6PR11MB3486.namprd11.prod.outlook.com (2603:10b6:805:c5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.26; Fri, 9 Oct 2020 15:21:26 +0000 Received: from SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616]) by SN6PR11MB3103.namprd11.prod.outlook.com ([fe80::41fb:70e6:6102:a616%7]) with mapi id 15.20.3455.025; Fri, 9 Oct 2020 15:21:26 +0000 From: "McDaniel, Timothy" To: "Ananyev, Konstantin" , "Richardson, Bruce" , "thomas@monjalon.net" , "jerinj@marvell.com" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , "Ma, Liang J" , "Burakov, Anatoly" Thread-Topic: [PATCH] eal: add umonitor umwait to x86 cpuflags Thread-Index: AQHWiFjPYAN/tb1IKU6L3nVvuszz1aljonLAgCvqO6A= Date: Fri, 9 Oct 2020 15:21:26 +0000 Message-ID: References: <1599841589-9150-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.251.9.49] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d28e83a5-f734-4742-801c-08d86c66fd84 x-ms-traffictypediagnostic: SN6PR11MB3486: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mxqu33WoA1OA6ot4hqa10mBNgnkzV/Sa9sH5yNZ4hr8tmVsG605YfyNU1QFPs1pUu4mfH2VLIahwxjHpA3gI2ArjZmOWOdDDrWHUxGYw0xA+8jO2cfjjpXpyTfEeYqcz38e7un/7BIad3/f3AIXHjK5g0BqW+FfZAeEn0/7AUZpGCd4RNIZWSlHjUhpWX5ozrgWBSn18vJp0D/R+KYJcLHRhKpYS0tHYSl/4fhXkJ+scweYI4RzLVAzgM+6/c6GztkMYT8uwEC5O68lpdaUMksUgmCID9DAVncYfkdLgZfuA8V51+9NFqWmZ08vRVWtg65N884pYEn6GXD+0lauWyPn63T9snORCzexL9svTx2uP6kcTOF48kUX4lB6hgDc7wM0TNaxqphNJgtFbO4M+xA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3103.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(8936002)(8676002)(83080400001)(107886003)(4326008)(83380400001)(86362001)(71200400001)(966005)(66556008)(76116006)(2906002)(478600001)(66946007)(66446008)(66476007)(9686003)(64756008)(55016002)(33656002)(5660300002)(7696005)(52536014)(316002)(110136005)(54906003)(26005)(186003)(53546011)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: rs5p9Trf0G8AgCbstchAA7TCGqzdArMo40USXJ41tGbfuAvzRh/RwqwaqDgcnJBvdaj2pIctI/fCDj5sjNE1A4OE/OcNRAukrlRabMBLKRLdI5PQPLSAH+AYer8Sv67aqoUybAP9V+kGgqROWZQGtPhly2IXlBSL5o07AlqaGcPJtfpQzQAov6gn5SulCM9nK4KTICpIWlzzZgKAVnnPvBmtnDPvgaQ2Jk7nhkP7YYEIxf5omzlDLUB6I4Gx5wBoSLHrFAzEyZjzEZzv4k4JDtrvrCNsi7RcRZXXZLjtpwktmNgdYEjLie4wBvbzddeFGKs1N6hqgP9ZCq25jbFZQR/7FD2mkc4Mw/SROeAshCynzySGz6O37WsyK9TSy4snxhqB+CtFogqeVsTzKZBrHgnKHuiWwsupVRji/1Jdqe0nq+yEznMFUtiHpVWMiK+mxNhos6udky+3LrZRmcVIwIuhUP2Tq4l/b75zKFjLxX5oM7b5lDN494D5nuSkMg2fIyfu83q1m8rAdCeOMJYPYQ34CiBuXGm2ovmFw7uA0BQ7OSLruXZii4DfA/rUrYoS1i+xAmdM492GsXDy5ey6zznYgwFbLFOnVJ0XS9ih+EIoyqmnjlqfqgETvBisv8NyA875vx07Rhbo7Ltf35Am3A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3103.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d28e83a5-f734-4742-801c-08d86c66fd84 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 15:21:26.6779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ATXZuSoMq1wC1xdbRwgvMM1zaVPM45Q5zkbk80R7Aoe0vc8Cvh5t/qdjK703wqkc7o8lMyNWFF2C1cTMHztq9JNYQHO/4LTw3qPGngAjuqc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3486 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eal: add umonitor umwait to x86 cpuflags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, September 11, 2020 11:37 AM > To: McDaniel, Timothy ; Richardson, Bruce > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > Ma, Liang J ; Burakov, Anatoly > > Subject: RE: [PATCH] eal: add umonitor umwait to x86 cpuflags >=20 >=20 > > > > umonitor/umwait are user-level versions of the monitor/mwait > > instructions. These allow the core to wait in a low-power state > > until a specified cache line is accessed, a timeout occurs, > > or the core is interrupted. >=20 > Isn't it a duplicate to: > https://patches.dpdk.org/patch/76554/ > ? >=20 > > > > Signed-off-by: Timothy McDaniel > > --- > > lib/librte_eal/x86/include/rte_cpuflags.h | 1 + > > lib/librte_eal/x86/rte_cpuflags.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/lib/librte_eal/x86/include/rte_cpuflags.h > b/lib/librte_eal/x86/include/rte_cpuflags.h > > index c1d2036..ab2c3b3 100644 > > --- a/lib/librte_eal/x86/include/rte_cpuflags.h > > +++ b/lib/librte_eal/x86/include/rte_cpuflags.h > > @@ -130,6 +130,7 @@ enum rte_cpu_flag_t { > > RTE_CPUFLAG_CLDEMOTE, /**< Cache Line Demote */ > > RTE_CPUFLAG_MOVDIRI, /**< Direct Store Instructions */ > > RTE_CPUFLAG_MOVDIR64B, /**< Direct Store Instructions 64= B > */ > > + RTE_CPUFLAG_UMWAIT, /**< UMONITOR/UMWAIT */ > > RTE_CPUFLAG_AVX512VP2INTERSECT, /**< AVX512 Two Register > Intersection */ > > > > /* The last item */ > > diff --git a/lib/librte_eal/x86/rte_cpuflags.c b/lib/librte_eal/x86/rte= _cpuflags.c > > index 30439e7..6bed3eb 100644 > > --- a/lib/librte_eal/x86/rte_cpuflags.c > > +++ b/lib/librte_eal/x86/rte_cpuflags.c > > @@ -137,6 +137,7 @@ const struct feature_entry rte_cpu_feature_table[] = =3D { > > FEAT_DEF(CLDEMOTE, 0x00000007, 0, RTE_REG_ECX, 25) > > FEAT_DEF(MOVDIRI, 0x00000007, 0, RTE_REG_ECX, 27) > > FEAT_DEF(MOVDIR64B, 0x00000007, 0, RTE_REG_ECX, 28) > > + FEAT_DEF(UMWAIT, 0x00000007, 0, RTE_REG_ECX, 5) > > FEAT_DEF(AVX512VP2INTERSECT, 0x00000007, 0, RTE_REG_EDX, 8) > > }; > > > > -- > > 2.6.4 With regards to the dependency on part of the power patch set (first patch = in the WAITPKG patch series http://patches.dpdk.org/project/dpdk/list/?ser= ies=3D12669 ), we understand the power team are addressing any outstanding = issues today. This should allow the DLB (https://patches.dpdk.org/project/dpdk/list/?seri= es=3D12163) and DLB2 (https://patches.dpdk.org/project/dpdk/list/?series=3D= 12164) patch sets to make use of the CPU ID patch as planned. Let us know if there is anything else outstanding. We are currently working= towards the PMD merge deadline date. Thanks, Tim